2.0 KiB
Prompt
Fix all findings from the local PR94 review, prefer a Tractor pin change if it reduces work, and export the original review for Tuicr.
Generated changes
git diff HEAD~1..HEAD -- config/conf.toml
Use TCP-only defaults, retaining commented UDS alternatives. Both checked Tractor address branch tips still reject mixed transports.
git diff HEAD~1..HEAD -- piker/cli/__init__.py
Make Click multiaddresses repeatable and normalize single strings.
git diff HEAD~1..HEAD -- piker/service/_actor_runtime.py
Validate requested daemon bind addresses instead of remote registrars. Normalize accepted endpoints and allow TCP ephemeral port requests.
git diff HEAD~1..HEAD -- piker/service/_daemon.py
Resolve explicit or inherited registrars independently of other daemon options and consume the explicit keyword before forwarding kwargs.
git diff HEAD~1..HEAD -- piker/ui/cli.py
Default chart bind endpoints to None when network config is absent.
git diff HEAD~1..HEAD -- piker/brokers/binance/feed.py
Remove the unconditional market-info debugger pause.
git diff HEAD~1..HEAD -- tests/test_services.py tests/test_startup.py
Remove the prematurely cherry-picked datad test and add offline startup regressions, including a real registrar/child daemon lifecycle check.
Verification
- Startup and logging tests: 13 passed.
- Existing runtime boot and tagged registrar tests: 2 passed.
- Scoped native Ruff and diff checks pass.
- The first new actor test used a removed nursery API; it was corrected to the installed start_actor/Portal.run interface before passing.
- Import initially failed without native libraries. Tests use the existing flake’s GCC, zlib, Qt and PyQt paths without executing its environment-rebuilding shell hook.
- Original seven findings exported locally as Tuicr review-add payloads bound to bde2457b; no session comments or remote PR were changed.