1.6 KiB
Prompt
The human supplied 14 comments from the local Tuicr review session fsp_backfill_sync@wkt-fsp_backfill_sync/staged/fadab3d and invoked /code-review-changes -r. They asked that comments already addressed by unstaged behavioral work be recognized when choosing each response.
Response
The review was correlated one-to-one with its persisted Tuicr records. The resulting adjustments clarify the existing dict wire schema and a future paired msgspec.Struct migration, and rename the broad Quote and HistoryOutput types to FeedQuote and FspHistory.
git diff HEAD~1..HEAD -- piker/data/__init__.py
git diff HEAD~1..HEAD -- piker/data/ticktools.py
git diff HEAD~1..HEAD -- piker/fsp/_api.py
git diff HEAD~1..HEAD -- piker/fsp/_engine.py
The FSP decorator now documents its PEP 695 parameter specification and its bare and configured return forms. Momentum types use explicit NDArray[np.float64] annotations, and WMA locals and the ignored tick target are named and typed explicitly. The WAP tuple return is split across documented fields.
git diff HEAD~1..HEAD -- piker/fsp/_momo.py
git diff HEAD~1..HEAD -- piker/fsp/_volume.py
git diff HEAD~1..HEAD -- tests/test_fsp_sync.py
The focused FSP regression file passed with 29 tests. Ruff, Ruff’s E501 line-length selection, compileall, and diff whitespace checks passed. The production Numba call shape was also executed successfully with all three arguments; its pre-existing explicit signature does not accept omitted defaults.