41 lines
1.4 KiB
Markdown
41 lines
1.4 KiB
Markdown
---
|
|
model: gpt-5.6-sol
|
|
service: opencode
|
|
session: tuicr-fsp-api-review
|
|
timestamp: 2026-09-08T02:06:19Z
|
|
git_ref: fadab3d2
|
|
scope: code
|
|
substantive: true
|
|
raw_file: 20260908T020619Z_fadab3d2_prompt_io.raw.md
|
|
---
|
|
|
|
## Prompt
|
|
|
|
Address all 14 comments from the local staged FSP Tuicr review, account
|
|
for relevant unstaged behavior changes, verify the fixes, and add local
|
|
responses without staging or committing repository changes.
|
|
|
|
## Response summary
|
|
|
|
Clarified typed wire-schema and generic-decorator intent, adopted more
|
|
specific FSP and feed type names, made momentum array typing explicit,
|
|
documented the WAP tuple fields, and verified both FSP regressions and
|
|
the production Numba call shape.
|
|
|
|
## Files changed
|
|
|
|
- `piker/data/__init__.py` - export the renamed feed quote type.
|
|
- `piker/data/ticktools.py` - clarify wire dicts and future structs.
|
|
- `piker/fsp/_api.py` - clarify history and decorator types.
|
|
- `piker/fsp/_engine.py` - consume the renamed public types.
|
|
- `piker/fsp/_momo.py` - make array and stream types explicit.
|
|
- `piker/fsp/_volume.py` - document WAP return fields.
|
|
- `tests/test_fsp_sync.py` - consume the renamed feed quote type.
|
|
|
|
## Human edits
|
|
|
|
The human reviewed the staged API boundary in Tuicr, requested the type
|
|
renames and documentation, rejected an opaque NumPy alias, identified
|
|
missing local annotations, required per-field tuple comments, and asked
|
|
that existing unstaged fixes be considered when responding.
|