pikers
/
piker
3
0
Fork 0
Code Issues 2 Pull Requests 5 Packages Projects Releases Wiki Activity

kucoin_and_binance_fix #9

Open
ntorres wants to merge 4 commits from kucoin_and_binance_fix into nix-qt6-fix
pull from: kucoin_and_binance_fix
merge into: pikers:nix-qt6-fix
Conversation 0 Commits 4 Files Changed 3
ntorres commented 2024-09-23 20:29:32 +00:00
Collaborator

Added missing kucoinPair fields and deleted unnecessary field from binance FutesPair.

Added missing kucoinPair fields and deleted unnecessary field from binance FutesPair.
ntorres added 2 commits 2024-09-23 20:29:33 +00:00
9890ab2811 Added missing fields for kucoin. 
feeCategory, makerFeeCoefficient, takerFeeCoefficient and st.
goodboy added 2 commits 2024-10-09 20:11:21 +00:00
df34791d2f `kucoin`: repair live quotes streaming.. 
This must have broke at some point during the new `MktPair` and thus
`.fqme: str` updates; mas-o-menos the symbol key in the quote-msg-`dict`
was NOT set to the `MktPair.bs_fqme: str` value and thus wasn't being
processed by the downstream sampling and feed subsys.

So fix that as well as a few other refinements,
- set the `topic: mkt.bs_fqme` in quote msgs obvi.
- drop the "wait for first clearing vlm" quote poll loop; going to fix
  the sampler to handle a `first_quote` without a `'last'` key.
- add some typing around calls to `get_mkt_info()`.
- rename `stream_messages()` -> `iter_normed_quotes()`.
27df649fbf .clearing._ems: Don't require `first_quote['last']` 
Instead just check for the field (which i'm not huge on the key-name for
anyway) and if not found get the "last price" from the real-time shm
buffer's latest 'close' sample.

Unrelatedly, use a `subs.copy()` in the `Router.client_broadcast()` loop
such that if a `client_stream` is popped on connection failure, we don't
RTE for the "size changed on iteration".
This pull request can be merged automatically.
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b kucoin_and_binance_fix nix-qt6-fix
git pull origin kucoin_and_binance_fix

Step 2:

Merge the changes and update on Gitea.
git checkout nix-qt6-fix
git merge --no-ff kucoin_and_binance_fix
git push origin nix-qt6-fix
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: pikers/piker#9
There is no content yet.
Delete Branch "kucoin_and_binance_fix"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?