pikers
/
piker
4
1
Fork 0
Code Issues 14 Pull Requests 15 Packages Projects Releases Wiki Activity

tractor_struct_and_godw_mod #72

Merged
goodboy merged 8 commits from tractor_struct_and_godw_mod into main 2026-02-22 23:39:11 +00:00
Conversation 0 Commits 8 Files Changed 12
goodboy commented 2026-02-22 21:10:21 +00:00
Owner

Various Qt6 and thus piker.ui.* tweaks factored out of pending feat/dev branches which can be landed in ahead of them.

Particularly of note,

  • moving the GodWidget + a new singleton-getter to piker.ui._widget
  • redirecting all the old piker.types.Struct -> tractor.msg.pretty_struct.Struct
  • various typing-annots styling.
  • various log message content format improvements.
  • general (multiline) code stylings.
Various Qt6 and thus `piker.ui.*` tweaks factored out of pending feat/dev branches which can be landed in ahead of them. Particularly of note, - moving the `GodWidget` + a new singleton-getter to `piker.ui._widget` - redirecting all the old `piker.types.Struct` -> `tractor.msg.pretty_struct.Struct` - various typing-annots styling. - various log message content format improvements. - general (multiline) code stylings.
goodboy added 8 commits 2026-02-22 21:10:21 +00:00
5020266bd5 Add `get_godw()` singleton getter for `GodWidget` 
Expose `get_godw()` helper to retrieve the central `GodWidget`
instance from anywhere in the UI code. Set the singleton in
`_async_main()` on startup.

Also,
- add docstring to `run_qtractor()` explaining trio guest mode
- type annotate `instance: GodWidget` in `run_qtractor()`
- import reorg in `._app` for cleaner grouping
- whitespace cleanup: `Type | None` -> `Type|None` throughout
- fix bitwise-or alignment: `Flag | Other` -> `Flag|Other`

(this commit-msg was generated in some part by [`claude-code`][claude-code-gh])
[claude-code-gh]: https://github.com/anthropics/claude-code
ad37ebabb2 Cleanups and doc tweaks to `.ui._fsp` 
Expand read-race warning log for clarity, add TODO for reading
`tractor` transport config from `conf.toml`, and reflow docstring
in `open_vlm_displays()`.

Also,
- whitespace cleanup: `Type | None` -> `Type|None`
- clarify "Volume" -> "Vlm (volume)" in docstr

(this commit msg was generated in some part by [`claude-code`][claude-code-gh])
[claude-code-gh]: https://github.com/anthropics/claude-code
8fb47f761a Point `.types.Struct` to `tractor.msg.pretty_struct` 
Drop the local (and original) `Struct` impl from `piker.types` in favour
of `tractor`'s version now that it's been upstreamed.

(this commit msg was generated in some part by [`claude-code`][claude-code-gh])
[claude-code-gh]: https://github.com/anthropics/claude-code
0b63a73954 Move `GodWidget` to new `._widget` mod 
Extract root-most widget to resolve (various) `.ui` import cycles
when the type is declared on `Struct`s..

Deats,
- flip to `from ._widget import GodWidget`.
- move `Feed` + `Flume` imports to TYPE_CHECKING in `._chart`
- drop unused `trio` import from `._chart`
- fix docstring typo: "datums```" -> "`datums``"
- change `print()` to `log.warning()` for global step msg

(this commit msg was generated in some part by [`claude-code`][claude-code-gh])
[claude-code-gh]: https://github.com/anthropics/claude-code
goodboy merged commit 600636784c into main 2026-02-22 23:39:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: pikers/piker#72
There is no content yet.
Delete Branch "tractor_struct_and_godw_mod"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?