pikers
/
piker
4
1
Fork 0
Code Issues 12 Pull Requests 11 Packages Projects Releases Wiki Activity

binance: mk AggTrade.nq optional.. #67

Merged
goodboy merged 2 commits from binance_nq_hotfix into main 2026-01-22 03:20:27 +00:00
Conversation 1 Commits 2 Files Changed 1
goodboy commented 2026-01-22 01:00:03 +00:00
Owner

Oof! my bad on this one.

Turns out @momo you had reported it right!

Oof! my bad on this one. Turns out @momo you had reported it right!
goodboy added 1 commit 2026-01-22 01:00:04 +00:00
b7cdbd89d4 binance: mk `AggTrade.nq` optional.. 
Oof! my bad.
Turns out spot pairs don't provide the `.nq` field looks like..
i guess i should not just test `.perp.` pairs all the time!

Bp
goodboy requested review from momo 2026-01-22 01:00:11 +00:00
momo approved these changes 2026-01-22 02:49:21 +00:00
Dismissed
goodboy added 1 commit 2026-01-22 03:19:20 +00:00
goodboy dismissed momo’s review 2026-01-22 03:19:21 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

goodboy merged commit d146060d5c into main 2026-01-22 03:20:27 +00:00
goodboy commented 2026-01-22 03:23:20 +00:00
Poster
Owner

For clarification, the PR was “dismissed” due to stupid main merge settings. The PR was definitely “accepted by moi” i just tossed in a link to the binance API changelog that @momo sent me in chat.

For clarification, the PR was "dismissed" due to stupid `main` merge settings. The PR was definitely "accepted by moi" i just tossed in a link to the binance API changelog that @momo sent me in chat.
Sign in to join this conversation.
Reviewers
No reviewers
momo
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: pikers/piker#67
There is no content yet.
Delete Branch "binance_nq_hotfix"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?