pikers
/
piker
4
1
Fork 0
Code Issues 12 Pull Requests 11 Packages Projects Releases Wiki Activity

pdbp_bump: to latest version, readme/pyproject tweaks #66

Merged
goodboy merged 3 commits from pdbp_bump into main 2026-01-15 19:17:30 +00:00
Conversation 1 Commits 3 Files Changed 3
goodboy commented 2026-01-14 20:40:11 +00:00
Owner

Fixed a regression that is already landed in latest pdbp, fixed the readme to use dev deps-group flags, more tidying of the pyproject.toml.

Fixed a regression that is already landed in latest `pdbp`, fixed the readme to use dev deps-group flags, more tidying of the `pyproject.toml`.
goodboy added 3 commits 2026-01-14 20:40:12 +00:00
eab9dfcd13 Update `pdbp` to latest release 
Since i fixed a UX regression that's critical for our dev tooling.
See the patch @ https://github.com/mdmintz/pdbp/pull/83
6f0f926259 Fix `uv sync` flags in readme 
Much thx to @momo for pointing out that we were still documenting the
old `--extra` flags (which are for `[optional-dependencies]`, see docs
https://docs.astral.sh/uv/concepts/projects/dependencies/#optional-dependencies)
but we're now using "dev dependency-groups"
(https://docs.astral.sh/uv/concepts/projects/dependencies/#dependency-groups)
which instead use the `--group` flag.
664be2cd0b Another little `pyproject` rejig 
Adding links to `uv` stuff and cleaning up old cruft from before recent
flash landing of various feature/dev branches.
momo approved these changes 2026-01-15 18:55:50 +00:00
momo left a comment
Collaborator

lgtm! if we add dev to default-groups i think we’re not gonna need uv sync –dev , uv sync can include uis and dev.

lgtm! if we add dev to default-groups i think we're not gonna need uv sync --dev , uv sync can include uis and dev.
goodboy commented 2026-01-15 19:11:01 +00:00
Poster
Owner

lgtm! if we add dev to default-groups i think we’re not gonna need uv sync –dev , uv sync can include uis and dev.

Agreed but i switched it to just uis for now bc dev shouldn’t really be installed by default imo, only the bare set of deps to get the charting going i’m thinking; the rest is really only if you’re hacking on the project.

> lgtm! > if we add dev to default-groups i think we're not gonna need uv sync --dev , uv sync can include uis and dev. > > Agreed but i switched it to just `uis` for now bc `dev` shouldn't really be installed by default imo, only the bare set of deps to get the charting going i'm thinking; the rest is really only if you're hacking on the project.
goodboy reviewed 2026-01-15 19:12:01 +00:00
README.rst
@ -96,3 +96,3 @@
include all GUIs (ex. for charting)::
uv sync --extra uis
uv sync --group uis
goodboy commented 2026-01-15 19:12:01 +00:00
Poster
Owner

Yeah i realize uis is the default group installed now but i think it’s to be explicit with this as well as the fact this instruction will continue to work despite changing the default group in the future.

Yeah i realize `uis` is the default group installed now but i think it's to be explicit with this as well as the fact this instruction will continue to work despite changing the default group in the future.
goodboy reviewed 2026-01-15 19:14:02 +00:00
pyproject.toml
@ -83,1 +83,3 @@
# service tree in distributed mode B)
# [optional-dependencies]
# uis = []
# ?TODO? really we should be able to mv this `uis` group
goodboy commented 2026-01-15 19:14:02 +00:00
Poster
Owner

This is an outstanding question which we should follow whenever we get to the point where we’re actually publishing a pkg (like on pypi), since only optional-dependencies actually are included in the disti..

The thing is if we go back to uis as opt-deps then we can’t nicely “nested include” them in the dev group.. 🤷

So for now i’m just leaving the todo.

This is an outstanding question which we should follow whenever we get to the point where we're actually publishing a pkg (like on pypi), since only `optional-dependencies` actually are included in the disti.. The thing is if we go back to `uis` as opt-deps then we can't nicely "nested include" them in the `dev` group.. 🤷 So for now i'm just leaving the todo.
goodboy reviewed 2026-01-15 19:16:56 +00:00
goodboy left a comment
Poster
Owner

Yeah gonna land this B)

Yeah gonna land this B)
pyproject.toml
@ -98,4 +110,0 @@
"qdarkstyle >=3.0.2, <4.0.0",
"pyqt6 >=6.7.0, <7.0.0",
"pyqtgraph",
goodboy commented 2026-01-15 19:14:24 +00:00
Poster
Owner

i guess that duplication musta been from my own sloppy rebasing Bp

i guess that duplication musta been from my own sloppy rebasing Bp
goodboy reviewed 2026-01-15 19:17:11 +00:00
pyproject.toml
@ -146,3 +154,4 @@
# now.
]
dbs = [
"elasticsearch >=8.9.0, <9.0.0",
goodboy commented 2026-01-15 19:17:11 +00:00
Poster
Owner

this likely will be dropped down the road when we finally move to @guille’s new lib:

https://github.com/guilledk/native-db

this likely will be dropped down the road when we finally move to @guille's new lib: https://github.com/guilledk/native-db
goodboy merged commit bd812bd2dd into main 2026-01-15 19:17:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
momo
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: pikers/piker#66
There is no content yet.
Delete Branch "pdbp_bump"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?