pikers
/
piker
4
1
Fork 0
Code Issues 10 Pull Requests 15 Packages Projects Releases Wiki Activity

fix DpiAwareFont default size calculation #48

Open
momo wants to merge 1 commits from dpi-font-auto-calc into how_to_show_ur_pp
pull from: dpi-font-auto-calc
merge into: pikers:how_to_show_ur_pp
Conversation 0 Commits 1 Files Changed 4
4 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
piker/ui/_style.py
View File

@ -182,7 +182,7 @@ class DpiAwareFont:
# always going to hit that error in range mapping from inches:
# float to px size: int.
self._font_inches = inches
font_size = math.floor(inches * dpi)
font_size = math.floor(inches * pdpi)
goodboy commented 2025-12-03 22:19:22 +00:00
Review

Yeah, it’s funny that this worked for you since the non-physical DPI is supposed to be the one that “you perceive on screen given DE scaling compensation” ..

so it does indeed look like we might always want/need to do from-scratch analysis of every display’s reported DPI and totally ignore OS-dependent metrix/reports including those with supposed auto-scaling.

Yeah, it's funny that this worked for you since the non-physical DPI is supposed to be the one that "you perceive on screen given DE scaling compensation" .. so it does indeed look like we might **always** want/need to do from-scratch analysis of every display's reported DPI and totally ignore OS-dependent metrix/reports including those with supposed auto-scaling.
log.debug(
f"screen:{screen.name()}\n"

3
pyproject.toml
View File

@ -77,6 +77,9 @@ dependencies = [
"trio-typing>=0.10.0",
"numba>=0.61.0",
"pyvnc",
"pyqt6>=6.8.0",
goodboy commented 2025-12-03 22:10:29 +00:00
Review

@momo let’s not add these deps to the core set and instead add them to the dev set since we only need them for running this new test suite 🙏

i also wonder if we might want to even consider making a new testing = [] dependency group eventually?

I think for now tossing it into dev is sufficient. Also not sure if uv has a way for deps-groups to depend on others?

Maybe do a quick check for that in their docs too?

@momo let's not add these deps to the core set and instead add them to the `dev` set since we only need them for running this new test suite 🙏 i also wonder if we might want to even consider making a new `testing = []` dependency group eventually? I think for now tossing it into `dev` is sufficient. Also not sure if `uv` has a way for deps-groups to depend on others? Maybe do a quick check for that in their docs too?
goodboy commented 2025-12-03 22:12:02 +00:00
Review

Also not sure if uv has a way for deps-groups to depend on others?

looks like nope says gemini Xp

uv does not currently support nesting dependency groups directly within the pyproject.toml file in a way that one group explicitly “includes” another in the same manner as, for example, extras can be defined to include other extras. However, you can achieve a similar effect by managing your uv commands to include multiple groups when performing operations like sync or pip install.

> Also not sure if uv has a way for deps-groups to depend on others? looks like nope says gemini Xp > uv does not currently support nesting dependency groups directly within the pyproject.toml file in a way that one group explicitly "includes" another in the same manner as, for example, extras can be defined to include other extras. However, you can achieve a similar effect by managing your uv commands to include multiple groups when performing operations like sync or pip install.
"pyqtgraph>=0.12.3",
"qdarkstyle>=3.2.3",
]
[project.optional-dependencies]

18
tests/test_dpi_font.py 100644
View File

@ -0,0 +1,18 @@
from PyQt6 import QtGui
from piker.ui._style import DpiAwareFont
class MockScreen:
def physicalDotsPerInch(self):
return 169 # example HiDPI
def logicalDotsPerInch(self):
return 96
def name(self):
return "MockScreen"
# create font instance
font = DpiAwareFont()
# pass the mock screen to configure_to_dpi
font.configure_to_dpi(screen=MockScreen())
print("Computed pixel size:", font.px_size)
goodboy commented 2025-12-03 22:14:29 +00:00
Review

woo nice!

this is a good start but we should wrap this in a pytest test-fn (function) so that it will report like the rest of the test suites ;)

https://docs.pytest.org/en/stable/getting-started.html#create-your-first-test

woo nice! this is a good start but we should wrap this in a `pytest` test-fn (function) so that it will report like the rest of the test suites ;) https://docs.pytest.org/en/stable/getting-started.html#create-your-first-test

6
uv.lock
View File

@ -811,7 +811,10 @@ dependencies = [
{ name = "polars-fuzzy-match" },
{ name = "pyarrow" },
{ name = "pygments" },
{ name = "pyqt6" },
{ name = "pyqtgraph" },
{ name = "pyvnc" },
{ name = "qdarkstyle" },
{ name = "rapidfuzz" },
{ name = "rich" },
{ name = "tomli" },
@ -866,9 +869,12 @@ requires-dist = [
{ name = "polars-fuzzy-match", specifier = ">=0.1.5" },
{ name = "pyarrow", specifier = ">=18.0.0" },
{ name = "pygments", specifier = ">=2.16.1,<3.0.0" },
{ name = "pyqt6", specifier = ">=6.8.0" },
{ name = "pyqt6", marker = "extra == 'uis'", specifier = ">=6.7.0,<7.0.0" },
{ name = "pyqtgraph", git = "https://github.com/pikers/pyqtgraph.git" },
{ name = "pyqtgraph", marker = "extra == 'uis'", git = "https://github.com/pikers/pyqtgraph.git" },
{ name = "pyvnc", git = "https://github.com/regulad/pyvnc.git" },
{ name = "qdarkstyle", specifier = ">=3.2.3" },
{ name = "qdarkstyle", marker = "extra == 'uis'", specifier = ">=3.0.2,<4.0.0" },
{ name = "rapidfuzz", specifier = ">=3.5.2,<4.0.0" },
{ name = "rapidfuzz", marker = "extra == 'uis'", specifier = ">=3.2.0,<4.0.0" },