pikers
/
piker
3
1
Fork 0
Code Issues 8 Pull Requests 13 Packages Projects Releases Wiki Activity

mp_fomo_polish: some feat additions, code styling corrections, general fixes #43

Open
goodboy wants to merge 4 commits from mp_fomo_polish into max_pain_storage
pull from: mp_fomo_polish
merge into: pikers:max_pain_storage
Conversation 0 Commits 4 Files Changed 4
goodboy commented 2025-04-24 15:34:01 +00:00
Owner

The idea being to merge this into any of #21, #23, but likely #42

Feat additions by fomo

Continuing with a small summary of ideas from #23, reported in #23 (comment)

  • instead for expiry selection we should use a terminal selection UX like fzf or something similar offered as a python pkg
    • possibly integrate our existing piker search <fqme> supporting machinery to be able to fuzzy search both the symbol and expiry from either a running daemon or already existing symbology-caches?

Bug fixes that should land here

  • proper fix for #31, likely needs some possible sync with #44 which will likely be rebased to main beforehand.

  • examples/max_pain.py should not crash when you quote the expiry typed to the input() prompt.

TO-CHERRY from downstream branches

TO-DROP from current state

  • 17aebf44a Add note to .brokers.ib.api about removing _bar_load_dtype
    • should move to #40
The idea being to merge this into any of #21, #23, but likely #42 --- #### Feat additions by fomo Continuing with a small summary of ideas from #23, reported in https://pikers.dev/pikers/piker/pulls/23#issuecomment-918 - [ ] instead for expiry selection we should use a terminal selection UX like [fzf](https://github.com/junegunn/fzf) or something similar offered as a python pkg - [ ] possibly integrate our existing `piker search <fqme>` supporting machinery to be able to fuzzy search both the symbol and expiry from either a running daemon or already existing symbology-caches? --- #### Bug fixes that should land here - [ ] proper fix for #31, likely needs some possible sync with #44 which will likely be rebased to `main` beforehand. - [ ] `examples/max_pain.py` should not crash when you quote the expiry typed to the `input()` prompt. --- #### TO-CHERRY from downstream branches - [ ] bc72e3d20 Drop unused `assets: dict` --- #### TO-DROP from current state - [ ] 17aebf44a Add note to `.brokers.ib.api` about removing `_bar_load_dtype` * should move to #40
goodboy added 4 commits 2025-04-24 15:34:02 +00:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b mp_fomo_polish max_pain_storage
git pull origin mp_fomo_polish

Step 2:

Merge the changes and update on Gitea.
git checkout max_pain_storage
git merge --no-ff mp_fomo_polish
git push origin max_pain_storage
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: pikers/piker#43
There is no content yet.
Delete Branch "mp_fomo_polish"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?