pikers
/
piker
3
0
Fork 0
Code Issues 2 Pull Requests 5 Packages Projects Releases Wiki Activity

Fix: missing field in SpotPair class for binance and added note in exception thrown #4

Closed
ntorres wants to merge 2 commits from fix-binance-venues into nix-monkeys-fix
pull from: fix-binance-venues
merge into: pikers:nix-monkeys-fix
Conversation 1 Commits 2 Files Changed 2
ntorres commented 2024-05-22 03:13:50 +00:00
Collaborator

Now when missing field in SpotPair class for binane venue throws an exception similar to this::

    |   File "/home/nelson/repos/piker/piker/brokers/binance/api.py", line 437, in _cache_pairs
    |     pair: Pair = pair_type(**item)
    |                  ^^^^^^^^^^^^^^^^^
    | TypeError: Unexpected keyword argument 'otoAllowed'
    |
    | Don't panic, check out this https://binance-docs.github.io/apidocs/spot/en/#exchange-information
    |
    +------------------------------------
Now when missing field in SpotPair class for binane venue throws an exception similar to this:: ``` | File "/home/nelson/repos/piker/piker/brokers/binance/api.py", line 437, in _cache_pairs | pair: Pair = pair_type(**item) | ^^^^^^^^^^^^^^^^^ | TypeError: Unexpected keyword argument 'otoAllowed' | | Don't panic, check out this https://binance-docs.github.io/apidocs/spot/en/#exchange-information | +------------------------------------ ```
ntorres added 2 commits 2024-05-22 03:13:50 +00:00
ntorres added 1 commit 2024-05-22 03:39:48 +00:00
ntorres force-pushed fix-binance-venues from fcdab0fc4e to 31653277a4 2024-05-22 05:52:16 +00:00 Compare
ntorres changed title from Fix missing field in SpotPair class for binance to Fix: missing field in SpotPair class for binance and added note in exception thrown 2024-05-22 14:03:45 +00:00
ntorres closed this pull request 2024-06-12 18:55:19 +00:00
goodboy commented 2024-06-12 18:56:33 +00:00
Owner

Ok so I already git merged in the needed commits from this branch. So I don’t think we need this open either. You can see the equivalent hashes in the history on that branch.

Ok so I already `git merge`d in the needed commits from this branch. So I don't think we need this open either. You can see the equivalent hashes in the history on that branch.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: pikers/piker#4
There is no content yet.
Delete Branch "fix-binance-venues"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?