Commit Graph

3191 Commits (e4db20f55d1293e706d61915802c9a1423a315aa)

Author SHA1 Message Date
Tyler Goodlet e4db20f55d Drop `._index_step` from formatters and instead defer to `Viz.index_step()` 2023-01-30 11:49:06 -05:00
Tyler Goodlet 2dc4aa8a2e Further fixes `Viz.default_view()` and `.index_step()`
Use proper uppx scaling when either of scaling the data to the x-domain
index-range or when the uppx is < 1 (now that we support it) such that
both the fast and slow chart always appropriately scale and offset to
the y-axis with the last datum graphic just adjacent to the order line
arrow markers.

Further this fixes the `.index_step()` calc to use the "earliest" 16
values to compute the expected sample step diff since the last set often
contained gaps due to start up race conditions and generated
unexpected/incorrect output.

Further this drops the `.curve_width_pxs()` method and replaces it with
`.px_width()`, taken from the graphics object API and instead returns
the pixel account for the whole view width instead of the
x-domain-data-range within the view.
2023-01-30 11:49:06 -05:00
Tyler Goodlet b371abc14b Make `FlowGraphic.x_last()` be optionally `None`
In the case where the last-datum-graphic hasn't been created yet, simply
return a `None` from this method so the caller can choose to ignore the
output. Further, drop `.px_width()` since it makes more sense defined on
`Viz` as well as the previously commented `BarItems.x_uppx()` method.
Also, don't round the `.x_uppx()` output since it can then be used when
< 1 to do x-domain scaling during high zoom usage.
2023-01-30 11:49:06 -05:00
Tyler Goodlet 23a4561b06 Drop edge case from `slice_from_time()`
Doesn't seem like we really need to handle the situation where the start
or stop input time stamps are outside the index range of the data since
the new binary search handling via `numpy.searchsorted()` covers this
case at minimal runtime cost and with an equally correct output. Allows
us to drop some other indexing endpoint internal variables as well.
2023-01-30 11:49:06 -05:00
Tyler Goodlet 971eef3a22 Use left-style index search on RHS scan as well 2023-01-30 11:49:06 -05:00
Tyler Goodlet 29613a62a8 Use static `L1Label._x_br_offset` as l1 label length 2023-01-30 11:49:06 -05:00
Tyler Goodlet 0615e618a2 Add a parent-type for graphics: `FlowGraphic`
Factor some common methods into the parent type:
- `.x_uppx()` for reading the horizontal units-per-pixel.
- `.x_last()` for reading the "closest to y-axis" last datum coordinate
  for zooming "around" during mouse interaction.
- `.px_width()` for computing the max width of any curve in view in
  pixels.

Adjust all previous derived `pg.GraphicsObject` child types to now
inherit from this new parent and in particular enable proper `.x_uppx()`
support to `BarItems`.
2023-01-30 11:49:06 -05:00
Tyler Goodlet 4291707a32 Just-offset-from-arrow-marker on slow chart
We want the fast and slow chart to behave the same on calls to
`Viz.default_view()` so adjust the offset calc to make both work:
- just offset by the line len regardless of step / uppx
- add back the `should_line: bool` output from `render_bar_items()` (and
  use it to set a new `ds_allowed: bool` guard variable) so that we can
  bypass calling the m4 downsampler unless the bars have been switched
  to the interpolation line graphic (which we normally required before
  any downsampling of OHLC graphics data).

Further, this drops use of the `use_vr: bool` flag from all rendering
since we pretty much always use it by default.
2023-01-30 11:49:06 -05:00
Tyler Goodlet 0b37b3c107 Drop l1 labels attr from chart widget 2023-01-30 11:49:06 -05:00
Tyler Goodlet 1d612efebf Handle empty `indexes` input edge case.. 2023-01-30 11:49:06 -05:00
Tyler Goodlet 9367badea6 TOSQUASH: 84f19308 (l1 rework) 2023-01-30 11:49:06 -05:00
Tyler Goodlet faa4206907 Set cursor label color to "bracket" 2023-01-30 11:49:06 -05:00
Tyler Goodlet 83012d618f Don't set y-axis label colors to curve's, use the default from global scheme 2023-01-30 11:49:06 -05:00
Tyler Goodlet a9963ef4ee Simplify L1 labels for multicharts
Instead of having the l1 lines be inside the view space, move them to be
inside their respective axis (with only a 16 unit portion inside the
view) such that the clear price label can overlay with them nicely
without obscuring; this is much better suited to multiple adjacent
y-axes and in general is simpler and less noisy.

Further `L1Labels` + `LevelLabel` style tweaks:
- adjust `.rect` positioning to be "right" (i.e. inside the parent
  y-axis) with a slight 16 unit shift toward the viewbox (using the new
  `._x_br_offset`) to allow seeing each level label's line even when the
  clearing price label is positioned at that same level.
- add a newline's worth of vertical space to each of the bid/ask labels
  so that L1 labels' text content isn't ever obscured by the clear price
  label.
- set a low (10) z-value to ensure l1 labels are always placed
  underneath the clear price label.
- always fill the label rect with the chosen background color.
- make labels fully opaque so as to always make them hide the parent
  axes' `.tickStrings()` contents.
- make default color the "default" from the global scheme.
- drop the "price" part from the l1 label text contents, just show the
  book-queue's amount (in dst asset's units, aka the potential clearing vlm).
2023-01-30 11:49:06 -05:00
Tyler Goodlet 49451a7c24 Fix x-axis labelling when using an epoch domain
Previously with array-int indexing we had to map the input x-domain
"indexes" passed to `DynamicDateAxis._indexes_to_timestr()`. In the
epoch-time indexing case we obviously don't need to lookup time stamps
from the underlying shm array and can instead just cast to `int` and
relay the values verbatim.

Further, this patch includes some style adjustments to `AxisLabel` to
better enable multi-feed chart overlays by avoiding L1 label clutter
when multiple y-axes are stacked adjacent:
- adjust the `Axis` typical max string to include a couple spaces suffix
 providing for a bit more margin between side-by-side y-axes.
- make the default label (fill) color the "default" from the global
 color scheme and drop it's opacity to .9
- add some new label placement options and use them in the
 `.boundingRect()` method:
 * `._x/y_br_offset` for relatively shifting the overall label relative
   to it's parent axis.
 * `._y_txt_h_scaling` for increasing the bounding rect's height
   without including more whitespace in the label's text content.
- ensure labels have a high z-value such that by default they are always
 placed "on top" such that when we adjust the l1 labels they can be set
 to a lower value and thus never obscure the last-price label.
2023-01-30 11:49:06 -05:00
Tyler Goodlet ecbca1089b Add commented append slice-len sanity check 2023-01-30 11:49:06 -05:00
Tyler Goodlet 95fd7c3c91 Use `np.diff()` on last 16 samples instead of only last datum pair 2023-01-30 11:49:06 -05:00
Tyler Goodlet 96b5dfdc3e Enable the experimental `QPrivatePath` functionality from latest `pyqtgraph` 2023-01-30 11:49:06 -05:00
Tyler Goodlet 2a76dd81cd Fix overlayed slow chart "treading"
Turns out we were updating the wrong ``Viz``/``DisplayState`` inside the
closure style `increment_history_view()`` (probably due to looping
through the flumes and dynamically closing in that task-func).. Instead
define the history incrementer at module level and pass in the
`DisplayState` explicitly. Further rework the `DisplayState` attrs to be
more focused around the `Viz` associated with the fast and slow chart
and be sure to adjust output from each `Viz.incr_info()` call to latest
update. Oh, and just tweaked the line palette for the moment.

FYI "treading" here is referring to  the x-shifting of the curve when
the last datum is in view such that on new sampled appends the "last"
datum is kept in the same x-location in UI terms.
2023-01-30 11:49:06 -05:00
Tyler Goodlet 53dd4ebf42 Make `.increment_view()` take in a `datums: int` and always scale it by sample step size 2023-01-30 11:49:06 -05:00
Tyler Goodlet 46925b72ad Make `Viz.incr_info()` do treading with time-index, and appending with array-index 2023-01-30 11:49:06 -05:00
Tyler Goodlet dbd5857a7e Rename `reset` -> `reset_cache` 2023-01-30 11:49:06 -05:00
Tyler Goodlet 827a0a8536 Fix gap detection on RHS; always bin-search on overshot time range 2023-01-30 11:49:06 -05:00
Tyler Goodlet 42502f3c60 Add type annots to vars inside `Render.render()` 2023-01-30 11:49:06 -05:00
Tyler Goodlet 6b805a8497 Drop coordinate cacheing from `BarItems`, causes weird jitter on pan 2023-01-30 11:49:06 -05:00
Tyler Goodlet b565080d55 Add `ChartPlotWidget.main_viz: Viz` convenience `@property` 2023-01-30 11:49:06 -05:00
Tyler Goodlet 8f764542d5 Make `Viz.incr_info()` sample rate agnostic
Mainly it was the global (should we )increment logic that needs to be
independent for the fast vs. slow chart such that the slow isn't
update-shifted by the fast and vice versa. We do this using a new
`'i_last_slow'` key in the `DisplayState.globalz: dict` which is
singleton for each sample-rate-specific chart and works for both time
and array indexing.

Also, we drop some old commented `graphics.draw_last_datum()` code that
never ended up being needed again inside the coordinate cache reset
bloc.
2023-01-30 11:49:06 -05:00
Tyler Goodlet 5892c79737 Use array-`int`-indexing on single feed
Might as well since it makes the chart look less gappy and we can easily
flip the index switch now B)

Also adds a new `'i_slow_last'` key to `DisplayState` for a singleton
across all slow charts and thus no more need for special case logic in
`viz.incr_info()`.
2023-01-30 11:49:06 -05:00
Tyler Goodlet 95e7c8648c Align step curves the same as OHLC bars 2023-01-30 11:49:06 -05:00
Tyler Goodlet 1b258d1bd6 Add `IncrementalFormatter.x_offset: np.ndarray`
Define the x-domain coords "offset" (determining the curve graphics
per-datum placement) for each formatter such that there's only on place
to change it when needed. Obviously each graphics type has it's own
dimensionality and this is reflected by the array shapes on each
subtype.
2023-01-30 11:49:06 -05:00
Tyler Goodlet f79efd4ca9 Adjust OHLC bar x-offsets to be time span matched
Previously we were drawing with the middle of the bar on each index with
arms to either side: +/- some arm length. Instead this changes so that
each bar is drawn *after* each index/timestamp such that in graphics
coords the bar span more correctly matches the time span in the
x-domain. This makes the linked region between slow and fast chart
directly match (without any transform) for epoch-time indexing such that
the last x-coord in view on the fast chart is no more then the
next time step in (downsampled) slow view.

Deats:
- adjust in `._pathops.path_arrays_from_ohlc()` and take an `bar_w` bar
  width input (normally taken from the data step size).
- change `.ui._ohlc.bar_from_ohlc_row()` and
  `BarItems.draw_last_datum()` to match.
2023-01-30 11:49:06 -05:00
Tyler Goodlet 6412b4ab5a `Viz._index_field` a `typing.Literal[str]` 2023-01-30 11:49:06 -05:00
Tyler Goodlet 045a1a6acc Set `path_arrays_from_ohlc(use_time_index=True)` on epoch indexing
Allows easily switching between normal array `int` indexing and time
indexing by just flipping the `Viz._index_field: str`.

Also, guard all the x-data audit breakpoints with a time indexing
condition.
2023-01-30 11:49:06 -05:00
Tyler Goodlet da3f74e28e Ugh, use `bool` flag to determine index field.. 2023-01-30 11:49:06 -05:00
Tyler Goodlet 9dd4945580 Make `LinearRegion` link using epoch-time index
Turned out to be super simple to get the first draft to work since the
fast and slow chart now use the same domain, however, it seems like
maybe there's an offset issue still where the fast may be a couple
minutes ahead of the slow?

Need to dig in a bit..
2023-01-30 11:49:06 -05:00
Tyler Goodlet cb78f0921c Add global `i_step` per overlay to `DisplayState`
Using a global "last index step" (via module var) obviously has problems
when working with multiple feed sets in a single global app instance:
any separate feed-set will be incremented according to an app-global
index-step and thus won't correctly calc per-feed-set-step update info.

Impl deatz:
- drop `DisplayState.incr_info()` (since previously moved to `Viz`) and
  call that method on each appropriate `Viz` instance where necessary;
  further ensure the appropriate `DisplayState` instance is passed in to
  each call and make sure to pass a `state: DisplayState`.
- add `DisplayState.hist_vars: dict` for history chart (sets) to
  determine the per-feed (not set) current slow chart (time) step.
- add `DisplayState.globalz: dict` to house a common per-feed-set state
  and use it inside the new `Viz.incr_info()` such that
  a `should_increment: bool` can be returned and used by the display
  loop to determine whether to x-shift the current chart.
2023-01-30 11:49:06 -05:00
Tyler Goodlet bd23d254da Move `DisplayState.incr_info()` -> `Viz` 2023-01-30 11:49:06 -05:00
Tyler Goodlet 89b6fde1ef Move `Viz` layer to new `.ui` mod 2023-01-30 11:49:06 -05:00
Tyler Goodlet 95325b22f0 Fix line -> bars on 6x UPPX
Read the `Viz.index_step()` directly to avoid always reading 1 on the
slow chart; this was completely broken before and resulting in not
rendering the bars graphic on the slow chart until at a true uppx of
1 which obviously doesn't work for 60 width bars XD

Further cleanups to `._render` module:
- drop `array` output from `Renderer.render()`, `read_from_key` input
  and fix type annot.
- drop `should_line`, `changed_to_line` and `render_kwargs` from
  `render_baritems()` outputs and instead calc `should_redraw` logic
  inside the func body and return as output.
2023-01-30 11:49:06 -05:00
Tyler Goodlet c9f2ca3f76 Drop unused `read_src_from_key: bool` to `.format_to_1d()` 2023-01-30 11:49:06 -05:00
Tyler Goodlet 9152babf2d Right, do index lookup for int-index as well.. 2023-01-30 11:49:06 -05:00
Tyler Goodlet b056e4bf17 Fix formatter xy ndarray first prepend case
First allocation vs. first "prepend" of source data to an xy `ndarray`
format **must be mutex** in order to avoid a double prepend.

Previously when both blocks were executed we'd end up with
a `.xy_nd_start` that was decremented (at least) twice as much as it
should be on the first `.format_to_1d()` call which is obviously
incorrect (and causes problems for m4 downsampling as discussed below).
Further, since the underlying `ShmArray` buffer indexing is managed
(i.e. write-updated) completely independently from the incremental
formatter updates and internal xy indexing, we can't use
`ShmArray._first.value` and instead need to use the particular `.diff()`
output's prepend length value to decrement the `.xy_nd_start` on updates
after initial alloc.

Problems this resolves with m4:
- m4 uses a x-domain diff to calculate the number of "frames" to
  downsample to, this is normally based on the ratio of pixel columns on
  screen vs. the size of the input xy data.
- previously using an int-index (not epoch time) the max diff between
  first and last index would be the size of the input buffer and thus
  would never cause a large mem allocation issue (though it may have
  been inefficient in terms of needed size).
- with an epoch time index this max diff could explode if you had some
  near-now epoch time stamp **minus** an x-allocation value: generally
  some value in `[0.5, -0.5]` which would result in a massive frames and
  thus internal `np.ndarray()` allocation causing either a crash in
  `numba` code or actual system mem over allocation.

Further, put in some more x value checks that trigger breakpoints if we
detect values that caused this issue - we'll remove em after this has
been tested enough.
2023-01-30 11:49:06 -05:00
Tyler Goodlet 49acaf12d1 Handle time-indexing for fill arrows
Call into a reworked `Flume.get_index()` for both the slow and fast
chart and do time index clipping to last datum where necessary.
2023-01-30 11:49:06 -05:00
Tyler Goodlet ff09625d83 Restore coord-cache resetting
Turns out we can't seem to avoid the artefacts when click-drag-scrolling
(results in weird repeated "smeared" curve segments) so just go back to
the original code.
2023-01-30 11:49:06 -05:00
Tyler Goodlet 28ca38ba87 Add some commented debug prints for default fmtr 2023-01-30 11:49:06 -05:00
Tyler Goodlet dc81d82d37 Slicec to an extra index around each timestamp input 2023-01-30 11:49:06 -05:00
Tyler Goodlet 8a295eba51 Drop passing `render_data` to `Curve.draw_last_datum()` 2023-01-30 11:49:06 -05:00
Tyler Goodlet 0516e7d6f2 Add back `.default_view()` slice logic for `int` indexing 2023-01-30 11:49:06 -05:00
Tyler Goodlet b9844f020f Block out `do_print` stuff inside `Viz.maxmin()` 2023-01-30 11:49:06 -05:00
Tyler Goodlet 44a3285367 Implement `stop_t` gap adjustments; the good lord said it is the problem 2023-01-30 11:49:05 -05:00