47 lines
1.8 KiB
Markdown
47 lines
1.8 KiB
Markdown
|
---
|
|||
|
|
created_at: 2026-10-19T12:37:25Z
|
|||
|
|
generated_by:
|
|||
|
|
harness: opencode
|
|||
|
|
provider: openai
|
|||
|
|
model: openai/gpt-6.1-sol
|
|||
|
|
git_ref: eed58566
|
|||
|
|
diff_cmd: git diff HEAD -- piker/log.py piker/service/_daemon.py piker/data/_daemon.py piker/brokers/_daemon.py piker/clearing/_ems.py
|
|||
|
|
---
|
|||
|
|
|
|||
|
|
## Captured response
|
|||
|
|
|
|||
|
|
Found it: downstream `c07e3cbd` (“Preserve exact `piker`
|
|||
|
|
logger namespaces”) removes this assertion and the equivalent
|
|||
|
|
ones in data, broker and EMS startup. It also fixes the logger
|
|||
|
|
prefix handling.
|
|||
|
|
|
|||
|
|
That compatibility patch was present in our earlier evaluation
|
|||
|
|
stack but is absent from this base. I’ll apply its code and
|
|||
|
|
existing regression tests here as an unstaged patch.
|
|||
|
|
|
|||
|
|
## Patch provenance
|
|||
|
|
|
|||
|
|
The five production-file changes and tests/test_logging.py reproduce
|
|||
|
|
the code/test changes from c07e3cbde21807a4e193b3527ef8686a22cf4d96.
|
|||
|
|
This is a working-tree transplant, not a new commit or cherry-pick.
|
|||
|
|
The test file's Git blob is 437554461de44833940b24d77a565160fc3ac6e0,
|
|||
|
|
matching the original commit. piker/log.py matches that commit.
|
|||
|
|
|
|||
|
|
## Verification output
|
|||
|
|
|
|||
|
|
Logger tests with --noconftest: 4 passed in 0.36s.
|
|||
|
|
Normal pytest startup failed before collection because both Piker and
|
|||
|
|
modern Tractor register --ll. The logger tests use no project fixtures.
|
|||
|
|
An external disposable-registrar smoke script exercised open_pikerd(),
|
|||
|
|
maybe_spawn_datad('kraken'), registration and teardown successfully:
|
|||
|
|
Data daemon startup: OK
|
|||
|
|
|
|||
|
|
## Follow-up response
|
|||
|
|
|
|||
|
|
Yep—the traceback shows the window’s `closeEvent()` explicitly
|
|||
|
|
sending SIGINT to its own process, which raises `KeyboardInterrupt`.
|
|||
|
|
Continuing a post-mortem REPL lets the original assertion unwind;
|
|||
|
|
it doesn’t resume successful startup. The resulting window close
|
|||
|
|
then adds that KBI. It’s secondary shutdown behaviour, and it
|
|||
|
|
makes the original failure harder to read.
|