Attempt at a .trionics.TaskMngr #23

goodboy · 2025-03-27T18:37:04Z

goodboy commented

2025-03-27 18:37:04 +00:00

Original prototype as proposed in https://github.com/goodboy/tractor/pull/363.

Not sure if i’m gonna move the PR content here or not yet.

Original prototype as proposed in https://github.com/goodboy/tractor/pull/363. --- Not sure if i'm gonna move the PR content here or not yet.

goodboy added 12 commits 2025-03-27 18:37:04 +00:00

8e20353ef6 Initial idea-notes dump and @singleton factory idea from `trio`-gitter

3ecdf8eea0 Mv over `ServiceMngr` from `piker` with mods

Namely distinguishing service "IPC contexts" (opened in a
subactor via a `Portal`) from just local `trio.Task`s started
and managed under the `.service_n` (more or less wrapping in the
interface of a "task-manager" style nursery - aka a one-cancels-one
supervision start).

API changes from original (`piker`) impl,
- mk `.start_service_task()` do ONLY that, start a task with a wrapping
  cancel-scope and completion event.
  |_ ideally this gets factored-out/re-implemented using the
    task-manager/OCO-style-nursery from GH #363.
- change what was the impl of `.start_service_task()` to `.start_service_ctx()`
  since it more explicitly defines the functionality of entering
  `Portal.open_context()` with a wrapping cs and completion event inside
  a bg task (which syncs the ctx's lifetime with termination of the
  remote actor runtime).
- factor out what was a `.start_service_ctx()` closure to a new
  `_open_and_supervise_service_ctx()` mod-func holding the meat of
  the supervision logic.

`ServiceMngr` API brief,
- use `open_service_mngr()` and `get_service_mngr()` to acquire the
  actor-global singleton.
- `ServiceMngr.start_service()` and `.cancel_service()` which allow for
  straight forward mgmt of "service subactor daemons".

8870f8da63 Better separate service tasks vs. ctxs via methods

Namely splitting the handles for each in 2 separate tables and adding
a `.cancel_service_task()`.

Also,
- move `_open_and_supervise_service_ctx()` to mod level.
- rename `target` -> `ctx_fn` params througout.
- fill out method doc strings.

b4acc371c6 Use shorthand nursery var-names per convention in codebase

062586a3b5 Initial prototype for a one-cancels-one style supervisor, nursery thing..

22e3912cdf Alias to `@acm` in broadcaster mod

3239dfa210 Do renaming, implement lowlevel `Outcome` sending

As was listed in the many todos, this changes the `.start_soon()` impl
to instead (manually) `.send()` into the user defined
`@task_scope_manager` an `Outcome` from the spawned task. In this case
the task manager wraps that in a user defined (and renamed)
`TaskOutcome` and delivers that + a containing `trio.CancelScope` to the
`.start_soon()` caller. Here the user defined `TaskOutcome` defines
a `.wait_for_result()` method that can be used to await the task's exit
and handle it's underlying returned value or raised error; the
implementation could be different and subject to the user's own whims.

Note that by default, if this was added to `trio`'s core, the
`@task_scope_manager` would simply be implemented as either a `None`
yielding single-yield-generator but more likely just entirely ignored
by the runtime (as in no manual task outcome collecting, generator
calling and sending is done at all) by default if the user does not provide
the `task_scope_manager` to the nursery at open time.

cfaf84d5d0 Facepalm, don't pass in unecessary cancel scope

5e31806770 Ensure user-allocated cancel scope just works!

Turns out the nursery doesn't have to care about allocating a per task
`CancelScope` since the user can just do that in the
`@task_scope_manager` if desired B) So just mask all the nursery cs
allocating with the intention of removal.

Also add a test for per-task-cancellation by starting the crash task as
a `trio.sleep_forever()` but then cancel it via the user allocated cs
and ensure the crash propagates as expected 💥

3d1b1d5bd8 More refinements and proper typing

- drop unneeded (and commented) internal cs allocating bits.
- bypass all task manager stuff if no generator is provided by the
  caller; i.e. just call `.start_soon()` as normal.
- fix `Generator` typing.
- add some prints around task manager.
- wrap in `TaskOutcome.lowlevel_task: Task`.

a664112405 Go all in on "task manager" naming

1b4129ac6d Add `debug_mode: bool` control to task mngr

Allows dynamically importing `pdbp` when enabled and a way for
eventually linking with `tractor`'s own debug mode flag.

goodboy changed title from ~~Attempt at a `trionics.TaskMngr`~~ to Attempt at a `.trionics.TaskMngr`

2025-03-27 18:37:16 +00:00

goodboy force-pushed oco_supervisor_prototype from 1b4129ac6d to c362603d15

2025-03-27 19:53:26 +00:00

Compare

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b oco_supervisor_prototype ext_type_plds

git pull origin oco_supervisor_prototype

Step 2:

Merge the changes and update on Gitea.

git checkout ext_type_plds

git merge --no-ff oco_supervisor_prototype

git push origin ext_type_plds

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: goodboy/tractor#23

Attempt at a .trionics.TaskMngr #23

Step 1:

Step 2:

Attempt at a `.trionics.TaskMngr` #23