Address Copilot review nits on PR #461 (round 2)
Apply the genuinely-valid items from the latest GH Copilot pass; the rest are house-style/local-convenience and get a reply instead, - drop the stray space before the colon in `test_no_runtime`'s `pytest.raises(...)` (one-off typo). - drop the unused `cffi` binding in `test_ringbuf` — the `importorskip` side-effect is all we need. - declare the `run-tests` skill's process-cleanup commands in `allowed-tools` (`ss`/`pgrep`/`pkill`/`sleep` + a scoped `rm -f /tmp/registry@*.sock`). Review: PR #461 (copilot-pull-request-reviewer) https://github.com/goodboy/tractor/pull/461#pullrequestreview-4519551472 (this patch was generated in some part by [`claude-code`][claude-code-gh]) [claude-code-gh]: https://github.com/anthropics/claude-codetrionics_start_or_cancel
parent
c0fdfa4c7b
commit
26f2b23da2
|
|
@ -16,6 +16,13 @@ allowed-tools:
|
||||||
- Bash(ls *)
|
- Bash(ls *)
|
||||||
- Bash(cat *)
|
- Bash(cat *)
|
||||||
- Bash(jq * .pytest_cache/*)
|
- Bash(jq * .pytest_cache/*)
|
||||||
|
# process inspection + SIGINT-first cleanup ladder (see
|
||||||
|
# the zombie-actor pre-flight / teardown steps below).
|
||||||
|
- Bash(ss *)
|
||||||
|
- Bash(pgrep *)
|
||||||
|
- Bash(pkill *)
|
||||||
|
- Bash(sleep *)
|
||||||
|
- Bash(rm -f /tmp/registry@*.sock)
|
||||||
- Read
|
- Read
|
||||||
- Grep
|
- Grep
|
||||||
- Glob
|
- Glob
|
||||||
|
|
|
||||||
|
|
@ -23,7 +23,7 @@ def test_no_runtime():
|
||||||
async with tractor.find_actor('doggy'):
|
async with tractor.find_actor('doggy'):
|
||||||
pass
|
pass
|
||||||
|
|
||||||
with pytest.raises(tractor._exceptions.NoRuntime) :
|
with pytest.raises(tractor._exceptions.NoRuntime):
|
||||||
trio.run(main)
|
trio.run(main)
|
||||||
|
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -6,7 +6,7 @@ import pytest
|
||||||
import tractor
|
import tractor
|
||||||
|
|
||||||
# XXX `cffi` dun build on py3.14 yet..
|
# XXX `cffi` dun build on py3.14 yet..
|
||||||
cffi = pytest.importorskip("cffi")
|
pytest.importorskip("cffi")
|
||||||
|
|
||||||
from tractor.ipc._ringbuf import (
|
from tractor.ipc._ringbuf import (
|
||||||
open_ringbuf,
|
open_ringbuf,
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue