From 26f2b23da28a22fd6e050ec2b5ffb434ba642c45 Mon Sep 17 00:00:00 2001
From: goodboy <goodboy_foss@protonmail.com>
Date: Wed, 17 Jun 2026 17:16:36 -0400
Subject: [PATCH] Address Copilot review nits on PR #461 (round 2)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Apply the genuinely-valid items from the latest GH Copilot
pass; the rest are house-style/local-convenience and get a
reply instead,

- drop the stray space before the colon in
  `test_no_runtime`'s `pytest.raises(...)` (one-off typo).
- drop the unused `cffi` binding in `test_ringbuf` — the
  `importorskip` side-effect is all we need.
- declare the `run-tests` skill's process-cleanup commands
  in `allowed-tools` (`ss`/`pgrep`/`pkill`/`sleep` + a
  scoped `rm -f /tmp/registry@*.sock`).

Review: PR #461 (copilot-pull-request-reviewer)
https://github.com/goodboy/tractor/pull/461#pullrequestreview-4519551472

(this patch was generated in some part by [`claude-code`][claude-code-gh])
[claude-code-gh]: https://github.com/anthropics/claude-code
---
 .claude/skills/run-tests/SKILL.md | 7 +++++++
 tests/test_local.py               | 2 +-
 tests/test_ringbuf.py             | 2 +-
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/.claude/skills/run-tests/SKILL.md b/.claude/skills/run-tests/SKILL.md
index 1c047332..ea0d4ae6 100644
--- a/.claude/skills/run-tests/SKILL.md
+++ b/.claude/skills/run-tests/SKILL.md
@@ -16,6 +16,13 @@ allowed-tools:
   - Bash(ls *)
   - Bash(cat *)
   - Bash(jq * .pytest_cache/*)
+  # process inspection + SIGINT-first cleanup ladder (see
+  # the zombie-actor pre-flight / teardown steps below).
+  - Bash(ss *)
+  - Bash(pgrep *)
+  - Bash(pkill *)
+  - Bash(sleep *)
+  - Bash(rm -f /tmp/registry@*.sock)
   - Read
   - Grep
   - Glob
diff --git a/tests/test_local.py b/tests/test_local.py
index 12be5ace..765ff796 100644
--- a/tests/test_local.py
+++ b/tests/test_local.py
@@ -23,7 +23,7 @@ def test_no_runtime():
         async with tractor.find_actor('doggy'):
             pass
 
-    with pytest.raises(tractor._exceptions.NoRuntime) :
+    with pytest.raises(tractor._exceptions.NoRuntime):
         trio.run(main)
 
 
diff --git a/tests/test_ringbuf.py b/tests/test_ringbuf.py
index 1fc0b8c1..56c4eae8 100644
--- a/tests/test_ringbuf.py
+++ b/tests/test_ringbuf.py
@@ -6,7 +6,7 @@ import pytest
 import tractor
 
 # XXX `cffi` dun build on py3.14 yet..
-cffi = pytest.importorskip("cffi")
+pytest.importorskip("cffi")
 
 from tractor.ipc._ringbuf import (
     open_ringbuf,