From 9721451d5a6288f9e15c05c1f70deb000a540c1b Mon Sep 17 00:00:00 2001
From: Tyler Goodlet <jgbt@protonmail.com>
Date: Mon, 3 Feb 2025 10:48:37 -0500
Subject: [PATCH] Drop unused `as err`, suggest `logging.exception()`

---
 skynet/ipfs/docker.py | 2 ++
 skynet/ipfs/pinner.py | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)
 mode change 100644 => 100755 skynet/ipfs/pinner.py

diff --git a/skynet/ipfs/docker.py b/skynet/ipfs/docker.py
index 7cdb3e9..69f564a 100755
--- a/skynet/ipfs/docker.py
+++ b/skynet/ipfs/docker.py
@@ -63,6 +63,8 @@ def open_ipfs_node(
         if ec != 0:
             logging.error(out)
 
+    # TODO, why not deliver some kinda API here for controlling the
+    # ipfs node?
     yield
 
     if teardown and container:
diff --git a/skynet/ipfs/pinner.py b/skynet/ipfs/pinner.py
old mode 100644
new mode 100755
index 0cc2836..a50acb0
--- a/skynet/ipfs/pinner.py
+++ b/skynet/ipfs/pinner.py
@@ -118,7 +118,8 @@ class SkynetPinner:
                     for cid in cids:
                         n.start_soon(self.task_pin, cid)
 
-                except OSError as e:
+                except OSError:
+                    # TODO, use `logging.exception()` here instead ??
                     traceback.print_exc()
 
                 except KeyboardInterrupt: