diff --git a/skynet/ipfs/docker.py b/skynet/ipfs/docker.py index 7cdb3e9..69f564a 100755 --- a/skynet/ipfs/docker.py +++ b/skynet/ipfs/docker.py @@ -63,6 +63,8 @@ def open_ipfs_node( if ec != 0: logging.error(out) + # TODO, why not deliver some kinda API here for controlling the + # ipfs node? yield if teardown and container: diff --git a/skynet/ipfs/pinner.py b/skynet/ipfs/pinner.py old mode 100644 new mode 100755 index 0cc2836..a50acb0 --- a/skynet/ipfs/pinner.py +++ b/skynet/ipfs/pinner.py @@ -118,7 +118,8 @@ class SkynetPinner: for cid in cids: n.start_soon(self.task_pin, cid) - except OSError as e: + except OSError: + # TODO, use `logging.exception()` here instead ?? traceback.print_exc() except KeyboardInterrupt: