From 5d67b3cd60d42f4cc1f5e332c8315936ce2fcd36 Mon Sep 17 00:00:00 2001 From: Guillermo Rodriguez Date: Fri, 7 Feb 2025 22:43:40 -0300 Subject: [PATCH] Address last of fomo\'s comments, related to pinner logging, cleanup ipfs module --- skynet/ipfs/__init__.py | 2 +- skynet/ipfs/pinner.py | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/skynet/ipfs/__init__.py b/skynet/ipfs/__init__.py index 125c225..af77da9 100644 --- a/skynet/ipfs/__init__.py +++ b/skynet/ipfs/__init__.py @@ -24,7 +24,7 @@ class AsyncIPFSHTTP: raise IPFSClientException(resp.text) return resp.json() -#!/usr/bin/python + async def add(self, file_path: Path, **kwargs): files = { 'file': (file_path.name, file_path.open('rb')) diff --git a/skynet/ipfs/pinner.py b/skynet/ipfs/pinner.py index dc9fe2d..dd53219 100755 --- a/skynet/ipfs/pinner.py +++ b/skynet/ipfs/pinner.py @@ -1,6 +1,4 @@ import logging -import traceback - from datetime import datetime, timedelta import trio @@ -117,8 +115,7 @@ class SkynetPinner: n.start_soon(self.task_pin, cid) except OSError: - # TODO, use `logging.exception()` here instead ?? - traceback.print_exc() + logging.exception('OSError while trying to pin?') except KeyboardInterrupt: break