pikers
/
piker
4
1
Fork 0
Code Issues 19 Pull Requests 15 Packages Projects Releases Wiki Activity

Swap tractor.to_asyncio.open_channel_from() yield-pair order #90

Merged
goodboy merged 2 commits from to_asyncio_api_update into main 2026-03-17 21:58:16 +00:00
Conversation 0 Commits 2 Files Changed 6
goodboy commented 2026-03-17 19:51:28 +00:00
Owner

Currently the piker_pin branch is still pointing to the commit pre-breaking-change, but landing this will pin us to main.

We’ll only go back to using the piker_pin branch again if upstream dev get’s complex again but hopefully that will be minimized going forward :praying:!

If you run into issues with your env and feel like you need the prior state again you can pin to any of,

  • the explicit commit hash e89fe03d
  • the gitea/piker_pin which i will leave as is until a week or so has passed.

Summary of breaking changes,

Match upstream tractor API change where .to_asyncio.open_channel_from() now yields (chan, first) instead of (first, chan) — i.e. tuple[LinkedTaskChannel, Any].

The following mods were changed to match,

  • brokers/ib/api.py
  • brokers/ib/broker.py
  • brokers/ib/feed.py
  • brokers/deribit/api.py
Currently the `piker_pin` branch is still pointing to the commit pre-breaking-change, but landing this will pin us to `main`. We'll only go back to using the `piker_pin` branch again if upstream dev get's complex again but hopefully that will be minimized going forward :praying:! If you run into issues with your env and feel like you need the prior state again you can pin to any of, - the explicit commit hash e89fe03d - the `gitea/piker_pin` which i will leave as is until a week or so has passed. --- ### Summary of breaking changes, Match upstream `tractor` API change where `.to_asyncio.open_channel_from()` now yields `(chan, first)` instead of `(first, chan)` — i.e. `tuple[LinkedTaskChannel, Any]`. The following mods were changed to match, - `brokers/ib/api.py` - `brokers/ib/broker.py` - `brokers/ib/feed.py` - `brokers/deribit/api.py`
goodboy added 1 commit 2026-03-17 19:51:29 +00:00
b22c59e7a0 Swap `open_channel_from()` yield-pair order 
Match upstream `tractor` API change where
`open_channel_from()` now yields `(chan, first)`
instead of `(first, chan)` — i.e.
`tuple[LinkedTaskChannel, Any]`.

- `brokers/ib/api.py`
- `brokers/ib/broker.py`
- `brokers/ib/feed.py`
- `brokers/deribit/api.py` (2 sites)

(this patch was generated in some part by [`claude-code`][claude-code-gh])
[claude-code-gh]: https://github.com/anthropics/claude-code
goodboy added 1 commit 2026-03-17 20:51:23 +00:00
goodboy requested review from guille 2026-03-17 20:55:01 +00:00
goodboy requested review from dnks 2026-03-17 20:55:01 +00:00
goodboy requested review from momo 2026-03-17 20:55:01 +00:00
goodboy reviewed 2026-03-17 21:20:04 +00:00
pyproject.toml
@ -203,9 +203,8 @@ pyvnc = { git = "https://github.com/regulad/pyvnc.git" }
# xonsh = { git = 'https://github.com/xonsh/xonsh.git', branch = 'main' }
# XXX since, we're like, always hacking new shite all-the-time. Bp
tractor = { git = "https://github.com/goodboy/tractor.git", branch ="piker_pin" }
goodboy commented 2026-03-17 21:20:04 +00:00
Poster
Owner

So y’all can’t complain if something breaks with this, but it definitely shouldn’t!

So y'all can't complain if something breaks with this, but it definitely shouldn't!
👍 1
guille approved these changes 2026-03-17 21:39:59 +00:00
goodboy removed review request for dnks 2026-03-17 21:57:52 +00:00
goodboy removed review request for momo 2026-03-17 21:58:04 +00:00
goodboy merged commit c23d034935 into main 2026-03-17 21:58:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
guille
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: pikers/piker#90
There is no content yet.
Delete Branch "to_asyncio_api_update"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?