macos_support #82
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "macos_support"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
Replaces #78 with a reduced history providing only the minimal patch set to avoid crashes/make-things-baseline-work on macos.
Still to check before landing
verify everything still works on linux.
UI looks right on an actual mac (thx for the help @dnks!)
(NO) do we actually need the symcache toml cleaning commit?
61bef6d5f5is there anything in
.data._sharedmem.pythat we’re missing but which is required??.tsp._history, https://pikers.dev/pikers/piker/pulls/82/files#issuecomment-14013ae41d6da4tractor.ipc._shm(finally) and pretty sure i patched in those change via themacos_supportrecently landed intractor’s, https://github.com/goodboy/tractor/pull/406Shorten SHM buffer key names to fit Darwin's 31 char filename limit by hashing the `fqme`/content portion with `md5` and truncating to 8 hex chars. Deats, - `.fsp._api`: replace `piker.{actor}[{uuid}].{sym}` format with `{uuid[:8]}_{hash}.fsp` - `.tsp._history`: add `platform.system()` check to conditionally shorten `.hist`/`.rt` keys on Darwin while keeping the full key format on Linux (this commit msg was generated in some part by [`claude-code`][claude-code-gh]) [claude-code-gh]: https://github.com/anthropics/claude-code NOTE that this patch was orig by @dnks and broken out from a larger commit which added unnecessary/out-of-scope changes we didn't end up requiring.41f9e45af9toa3ed73a40da3ed73a40dtod404568ff3@ -1380,13 +1381,20 @@ async def manage_history(service: str = name.rstrip(f'.{mod.name}')fqme: str = mkt.get_fqme(delim_char='')key: str = f'piker.{service}[{uuid[:16]}].{fqme}'Ahh yeah we don’t need the stuff from @dnks’ other patch in #64 bc we already handle key/file-name shortening right here 😎