README.rst

@@ -90,14 +90,6 @@ bc why install with `python` when you can faster with `rust` ::
 
     uv lock
 
-with all GUI support as well::
-
-    uv lock --extra uis
-
-AND with all dev (hacking) tools::
-
-    uv lock --dev --extra uis
-
 
 hacky install on nixos
 **********************

examples/max_pain.py

@@ -1,338 +0,0 @@
-#!/usr/bin/env python
-from decimal import (
-    Decimal,
-)
-from pathlib import Path
-
-import numpy as np
-# import polars as pl
-import trio
-import tractor
-from datetime import datetime
-# from pprint import pformat
-from piker.brokers.deribit.api import (
-    get_client,
-    maybe_open_oi_feed,
-)
-from piker.storage import open_storage_client, StorageClient
-from piker.log import get_logger
-import sys
-import pyqtgraph as pg
-from PyQt6 import QtCore
-from pyqtgraph import ScatterPlotItem, InfiniteLine
-from PyQt6.QtWidgets import QApplication
-from cryptofeed.symbols import Symbol
-
-
-log = get_logger(__name__)
-# XXX, use 2 newlines between top level LOC (even between these
-# imports and the next function line ;)
-
-def check_if_complete(
-        oi: dict[str, dict[str, Decimal | None]]
-    ) -> bool:
-    return all(
-        oi[strike]['C'] is not None
-        and
-        oi[strike]['P'] is not None for strike in oi
-    )
-
-
-async def max_pain_daemon(
-) -> None:
-    oi_by_strikes: dict[str, dict[str, Decimal | None]]
-    instruments: list[Symbol] = []
-    expiry_dates: list[str]
-    expiry_date: str
-    currency: str = 'btc'
-    kind: str = 'option'
-
-    async with get_client(
-    ) as client:
-        expiry_dates: list[str] = await client.get_expiration_dates(
-            currency=currency,
-            kind=kind
-        )
-
-        log.info(
-            f'Available expiries for {currency!r}-{kind}:\n'
-            f'{expiry_dates}\n'
-        )
-        expiry_date: str = input(
-            'Please enter a valid expiration date: '
-        ).upper()
-        print('Starting little daemon...')
-
-        # maybe move this type annot down to the assignment line?
-        oi_by_strikes: dict[str, dict[str, Decimal]]
-        instruments = await client.get_instruments(
-            expiry_date=expiry_date,
-        )
-        oi_by_strikes = client.get_strikes_dict(instruments)
-
-
-    def get_total_intrinsic_values(
-        oi_by_strikes: dict[str, dict[str, Decimal]]
-    ) -> dict[str, dict[str, Decimal]]:
-        call_cash: Decimal = Decimal(0)
-        put_cash: Decimal = Decimal(0)
-        intrinsic_values: dict[str, dict[str, Decimal]] = {}
-        closes: list = sorted(Decimal(close) for close in oi_by_strikes)
-
-        for strike, oi in oi_by_strikes.items():
-            s = Decimal(strike)
-            call_cash = sum(max(0, (s - c) * oi_by_strikes[str(c)]['C']) for c in closes)
-            put_cash = sum(max(0, (c - s) * oi_by_strikes[str(c)]['P']) for c in closes)
-
-            intrinsic_values[strike] = {
-                'C': call_cash,
-                'P': put_cash,
-                'total': call_cash + put_cash,
-            }
-
-        return intrinsic_values
-
-    def get_intrinsic_value_and_max_pain(
-        intrinsic_values: dict[str, dict[str, Decimal]]
-        ):
-        # We meed to find the lowest value, so we start at
-        # infinity to ensure that, and the max_pain must be
-        # an amount greater than zero.
-        total_intrinsic_value: Decimal = Decimal('Infinity')
-        max_pain: Decimal = Decimal(0)
-
-        for strike, oi in oi_by_strikes.items():
-            s = Decimal(strike)
-            if intrinsic_values[strike]['total'] < total_intrinsic_value:
-                total_intrinsic_value = intrinsic_values[strike]['total']
-                max_pain = s
-
-        return total_intrinsic_value, max_pain
-
-    def plot_graph(
-        oi_by_strikes: dict[str, dict[str, Decimal]],
-        plot,
-    ):
-        """Update the bar graph with new open interest data."""
-        plot.clear()
-
-        intrinsic_values = get_total_intrinsic_values(oi_by_strikes)
-
-        for strike_str in sorted(oi_by_strikes, key=lambda x: int(x)):
-            strike = int(strike_str)
-            calls_val = float(oi_by_strikes[strike_str]['C'])
-            puts_val  = float(oi_by_strikes[strike_str]['P'])
-
-            bar_c = pg.BarGraphItem(
-                x=[strike - 100],
-                height=[calls_val],
-                width=200,
-                pen='w',
-                brush=(0, 0, 255, 150)
-            )
-            plot.addItem(bar_c)
-
-            bar_p = pg.BarGraphItem(
-                x=[strike + 100],
-                height=[puts_val],
-                width=200,
-                pen='w',
-                brush=(255, 0, 0, 150)
-            )
-            plot.addItem(bar_p)
-
-            total_val = float(intrinsic_values[strike_str]['total']) / 100000
-
-            scatter_iv = ScatterPlotItem(
-                x=[strike],
-                y=[total_val],
-                pen=pg.mkPen(color=(0, 255, 0), width=2),
-                brush=pg.mkBrush(0, 255, 0, 150),
-                size=3,
-                symbol='o'
-            )
-            plot.addItem(scatter_iv)
-
-        _, max_pain = get_intrinsic_value_and_max_pain(intrinsic_values)
-
-        vertical_line = InfiniteLine(
-            pos=max_pain,
-            angle=90,
-            pen=pg.mkPen(color='yellow', width=1, style=QtCore.Qt.PenStyle.DotLine),
-            label=f'Max pain: {max_pain:,.0f}',
-            labelOpts={
-                'position': 0.85,
-                'color': 'yellow',
-                'movable': True
-            }
-        )
-        plot.addItem(vertical_line)
-
-    def update_oi_by_strikes(msg: tuple):
-        nonlocal oi_by_strikes
-        if 'oi' == msg[0]:
-            strike_price = msg[1]['strike_price']
-            option_type = msg[1]['option_type']
-            open_interest = msg[1]['open_interest']
-            oi_by_strikes.setdefault(
-                strike_price, {}
-            ).update(
-                {option_type: open_interest}
-            )
-
-    # Define the structured dtype
-    dtype = np.dtype([
-        ('time', int),
-        ('oi', float),
-        ('oi_calc', float),
-    ])
-    async def write_open_interest_on_file(msg: tuple, client: StorageClient):
-        if 'oi' == msg[0]:
-            nonlocal expiry_date
-            timestamp = msg[1]['timestamp']
-            strike_price = msg[1]["strike_price"]
-            option_type = msg[1]['option_type'].lower()
-            col_sym_key = f'btc-{expiry_date.lower()}-{strike_price}-{option_type}'
-
-            # Create the numpy array with sample data
-            data = np.array([
-                (
-                    int(timestamp),
-                    float(msg[1]['open_interest']),
-                    np.nan,
-                ),
-            ], dtype=dtype)
-
-            path: Path = await client.write_oi(
-                col_sym_key,
-                data,
-            )
-            # TODO, use std logging like this throughout for status
-            # emissions on console!
-            log.info(f'Wrote OI history to {path}')
-
-    def get_max_pain(
-        oi_by_strikes: dict[str, dict[str, Decimal]]
-    ) -> dict[str, str | Decimal]:
-        '''
-        This method requires only the strike_prices and oi for call
-        and puts, the closes list are the same as the strike_prices
-        the idea is to sum all the calls and puts cash for each strike
-        and the ITM strikes from that strike, the lowest value is what we
-        are looking for the intrinsic value.
-
-        '''
-
-        nonlocal timestamp
-
-        intrinsic_values = get_total_intrinsic_values(oi_by_strikes)
-
-        total_intrinsic_value, max_pain = get_intrinsic_value_and_max_pain(intrinsic_values)
-
-        return {
-            'timestamp': timestamp,
-            'expiry_date': expiry_date,
-            'total_intrinsic_value': total_intrinsic_value,
-            'max_pain': max_pain,
-        }
-
-    async with (
-        open_storage_client() as (_, storage),
-
-        maybe_open_oi_feed(
-            instruments,
-        ) as oi_feed,
-    ):
-        # Initialize QApplication
-        app = QApplication(sys.argv)
-
-        win = pg.GraphicsLayoutWidget(show=True)
-        win.setWindowTitle('Calls (blue) vs Puts (red)')
-
-        plot = win.addPlot(title='OI by Strikes')
-        plot.showGrid(x=True, y=True)
-        print('Plot initialized...')
-
-        async for msg in oi_feed:
-
-            # In memory oi_by_strikes dict, all message are filtered here
-            # and the dict is updated with the open interest data
-            update_oi_by_strikes(msg)
-
-            # Write on file using storage client
-            await write_open_interest_on_file(msg, storage)
-
-            # Max pain calcs, before start we must gather all the open interest for
-            # all the strike prices and option types available for a expiration date
-            if check_if_complete(oi_by_strikes):
-                if 'oi' == msg[0]:
-                    # Here we must read for the filesystem all the latest open interest value for
-                    # each instrument for that specific expiration date, that means look up for the
-                    # last update got the instrument btc-{expity_date}-*oi1s.parquet (1s because is
-                    # hardcoded to something, sorry.)
-                    timestamp = msg[1]['timestamp']
-                    max_pain = get_max_pain(oi_by_strikes)
-                    # intrinsic_values = get_total_intrinsic_values(oi_by_strikes)
-
-                    # graph here
-                    plot_graph(oi_by_strikes, plot)
-
-                    # TODO, use a single multiline string with `()`
-                    # and drop the multiple `print()` calls (this
-                    # should be done elsewhere in this file as well!
-                    #
-                    # As per the docs,
-                    # https://docs.python.org/3/reference/lexical_analysis.html#string-literal-concatenation
-                    # you could instead do,
-                    # print(
-                    #   '-----------------------------------------------\n'
-                    #   f'timestamp: {datetime.fromtimestamp(max_pain['timestamp'])}\n'
-                    # )
-                    # WHY?
-                    # |_ less ctx-switches/calls to `print()`
-                    # |_ the `str` can then be modified / passed
-                    #   around as a variable more easily if needed in
-                    #   the future ;)
-                    #
-                    # ALSO, i believe there already is a stdlib
-                    # module to do "alignment" of text which you
-                    # could try for doing the right-side alignment,
-                    # https://docs.python.org/3/library/textwrap.html#textwrap.indent
-                    #
-                    print('-----------------------------------------------')
-                    print(f'timestamp:             {datetime.fromtimestamp(max_pain['timestamp'])}')
-                    print(f'expiry_date:           {max_pain['expiry_date']}')
-                    print(f'max_pain:              {max_pain['max_pain']:,.0f}')
-                    print(f'total intrinsic value: {max_pain['total_intrinsic_value']:,.0f}')
-                    print('-----------------------------------------------')
-
-            # Process GUI events to keep the window responsive
-            app.processEvents()
-
-
-async def main():
-
-    async with tractor.open_nursery(
-        debug_mode=True,
-        loglevel='info',
-    ) as an:
-        from tractor import log
-        log.get_console_log(level='info')
-
-        ptl: tractor.Portal = await an.start_actor(
-            'max_pain_daemon',
-            enable_modules=[__name__],
-            infect_asyncio=True,
-            # ^TODO, we can actually run this in the root-actor now
-            # if needed as per 2nd "section" in,
-            # https://pikers.dev/goodboy/tractor/pulls/2
-            #
-            # NOTE, will first require us porting to modern
-            # `tractor:main` though ofc!
-
-        )
-        await ptl.run(max_pain_daemon)
-
-
-if __name__ == '__main__':
-    trio.run(main)

examples/max_pain_readme.rst

@@ -1,29 +0,0 @@
-## Max Pain Calculation for Deribit Options
-
-This feature, which calculates the max pain point for options traded
-on the Deribit exchange using cryptofeed library.
-
-- Functions in the api module for fetching options data from Deribit.
-  [commit](https://pikers.dev/pikers/piker/commit/da55856dd2876291f55a06eb0561438a912d8241)
-
-- Compute the max pain point based on open interest data using
-  deribit's api.
-  [commit](https://pikers.dev/pikers/piker/commit/0d9d6e15ba0edeb662ec97f7599dd66af3046b94)
-
-### How to test it?
-
-**Before start:** in order to get this working with `uv`,  you
-**must** use my [`tractor` fork](https://pikers.dev/ntorres/tractor/src/branch/aio_abandons)
-and this branch: `aio_abandons`, the reason is that I cherry-pick the
-`uv_migration` that guille made, for some reason that a didn't dive
-into, in my system y need tractor using `uv` too. quite hacky
-I guess.
-
-1. `uv lock`
-
-2. `uv run --no-dev python examples/max_pain.py`
-
-3. A message should be display, enter one of the expiration date
-   available.
-
-4. The script should be up and running.

piker/accounting/__init__.py

@@ -42,6 +42,7 @@ from ._mktinfo import (
     dec_digits,
     digits_to_dec,
     MktPair,
+    Symbol,
     unpack_fqme,
     _derivs as DerivTypes,
 )
@@ -59,6 +60,7 @@ __all__ = [
     'Asset',
     'MktPair',
     'Position',
+    'Symbol',
     'Transaction',
     'TransactionLedger',
     'dec_digits',

piker/accounting/_mktinfo.py

@@ -390,8 +390,8 @@ class MktPair(Struct, frozen=True):
         cls,
         fqme: str,
 
-        price_tick: float|str,
+        price_tick: float | str,
-        size_tick: float|str,
+        size_tick: float | str,
         bs_mktid: str,
 
         broker: str | None = None,
@@ -677,3 +677,90 @@ def unpack_fqme(
         # '.'.join([mkt_ep, venue]),
         suffix,
     )
+
+
+class Symbol(Struct):
+    '''
+    I guess this is some kinda container thing for dealing with
+    all the different meta-data formats from brokers?
+
+    '''
+    key: str
+
+    broker: str = ''
+    venue: str = ''
+
+    # precision descriptors for price and vlm
+    tick_size: Decimal = Decimal('0.01')
+    lot_tick_size: Decimal = Decimal('0.0')
+
+    suffix: str = ''
+    broker_info: dict[str, dict[str, Any]] = {}
+
+    @classmethod
+    def from_fqme(
+        cls,
+        fqsn: str,
+        info: dict[str, Any],
+
+    ) -> Symbol:
+        broker, mktep, venue, suffix = unpack_fqme(fqsn)
+        tick_size = info.get('price_tick_size', 0.01)
+        lot_size = info.get('lot_tick_size', 0.0)
+
+        return Symbol(
+            broker=broker,
+            key=mktep,
+            tick_size=tick_size,
+            lot_tick_size=lot_size,
+            venue=venue,
+            suffix=suffix,
+            broker_info={broker: info},
+        )
+
+    @property
+    def type_key(self) -> str:
+        return list(self.broker_info.values())[0]['asset_type']
+
+    @property
+    def tick_size_digits(self) -> int:
+        return float_digits(self.tick_size)
+
+    @property
+    def lot_size_digits(self) -> int:
+        return float_digits(self.lot_tick_size)
+
+    @property
+    def price_tick(self) -> Decimal:
+        return Decimal(str(self.tick_size))
+
+    @property
+    def size_tick(self) -> Decimal:
+        return Decimal(str(self.lot_tick_size))
+
+    @property
+    def broker(self) -> str:
+        return list(self.broker_info.keys())[0]
+
+    @property
+    def fqme(self) -> str:
+        return maybe_cons_tokens([
+            self.key,  # final "pair name" (eg. qqq[/usd], btcusdt)
+            self.venue,
+            self.suffix,  # includes expiry and other con info
+            self.broker,
+        ])
+
+    def quantize(
+        self,
+        size: float,
+    ) -> Decimal:
+        digits = float_digits(self.lot_tick_size)
+        return Decimal(size).quantize(
+            Decimal(f'1.{"0".ljust(digits, "0")}'),
+            rounding=ROUND_HALF_EVEN
+        )
+
+    # NOTE: when cast to `str` return fqme
+    def __str__(self) -> str:
+        return self.fqme

piker/brokers/__init__.py

@@ -51,7 +51,6 @@ __brokers__: list[str] = [
     'ib',
     'kraken',
     'kucoin',
-    'deribit',
 
     # broken but used to work
     # 'questrade',
@@ -62,6 +61,7 @@ __brokers__: list[str] = [
     # wstrade
     # iex
 
+    # deribit
     # bitso
 ]
 

piker/brokers/binance/api.py

@@ -374,14 +374,9 @@ class Client:
                 pair: Pair = pair_type(**item)
             except Exception as e:
                 e.add_note(
-                    f'\n'
+                    "\nDon't panic, prolly stupid binance changed their symbology schema again..\n"
-                    f'New or removed field we need to codify!\n'
+                    'Check out their API docs here:\n\n'
-                    f'pair-type: {pair_type!r}\n'
+                    'https://binance-docs.github.io/apidocs/spot/en/#exchange-information'
-                    f'\n'
-                    f"Don't panic, prolly stupid binance changed their symbology schema again..\n"
-                    f'Check out their API docs here:\n'
-                    f'\n'
-                    f'https://binance-docs.github.io/apidocs/spot/en/#exchange-information\n'
                 )
                 raise
             pair_table[pair.symbol.upper()] = pair

piker/brokers/binance/venues.py

@@ -97,8 +97,6 @@ class Pair(Struct, frozen=True, kw_only=True):
     baseAsset: str
     baseAssetPrecision: int
 
-    permissionSets: list[list[str]]
-
     filters: dict[
         str,
         str | int | float,
@@ -144,11 +142,7 @@ class SpotPair(Pair, frozen=True):
     defaultSelfTradePreventionMode: str
     allowedSelfTradePreventionModes: list[str]
     permissions: list[str]
-
+    permissionSets: list[list[str]]
-    # can the paint botz creat liq gaps even easier on this asset?
-    # Bp
-    # https://developers.binance.com/docs/binance-spot-api-docs/faqs/order_amend_keep_priority
-    amendAllowed: bool
 
     # NOTE: see `.data._symcache.SymbologyCache.load()` for why
     ns_path: str = 'piker.brokers.binance:SpotPair'

piker/brokers/deribit/__init__.py

@@ -25,7 +25,6 @@ from .api import (
     get_client,
 )
 from .feed import (
-    get_mkt_info,
     open_history_client,
     open_symbol_search,
     stream_quotes,
@@ -35,20 +34,15 @@ from .feed import (
     # open_trade_dialog,
     # norm_trade_records,
 # )
-from .venues import (
-    OptionPair,
-)
 
 log = get_logger(__name__)
 
 __all__ = [
     'get_client',
 #    'trades_dialogue',
-    'get_mkt_info',
     'open_history_client',
     'open_symbol_search',
     'stream_quotes',
-    'OptionPair',
 #    'norm_trade_records',
 ]
 

piker/brokers/deribit/feed.py

@@ -18,59 +18,38 @@
 Deribit backend.
 
 '''
-from __future__ import annotations
 from contextlib import asynccontextmanager as acm
 from datetime import datetime
-from typing import (
+from typing import Any, Optional, Callable
-    # Any,
-    # Optional,
-    Callable,
-)
-# from pprint import pformat
 import time
 
-import cryptofeed
 import trio
 from trio_typing import TaskStatus
-from pendulum import (
+import pendulum
-    from_timestamp,
+from rapidfuzz import process as fuzzy
-)
 import numpy as np
 import tractor
 
-from piker.accounting import (
+from piker.brokers import open_cached_client
-    Asset,
+from piker.log import get_logger, get_console_log
-    MktPair,
+from piker.data import ShmArray
-    unpack_fqme,
+from piker.brokers._util import (
-)
+    BrokerError,
-from piker.brokers import (
-    open_cached_client,
-    NoData,
     DataUnavailable,
 )
-from piker._cacheables import (
-    async_lifo_cache,
-)
-from piker.log import (
-    get_logger,
-    mk_repr,
-)
-from piker.data.validate import FeedInit
 
+from cryptofeed import FeedHandler
+from cryptofeed.defines import (
+    DERIBIT, L1_BOOK, TRADES, OPTION, CALL, PUT
+)
+from cryptofeed.symbols import Symbol
 
 from .api import (
-    Client,
+    Client, Trade,
-    # get_config,
+    get_config,
-    piker_sym_to_cb_sym,
+    str_to_cb_sym, piker_sym_to_cb_sym, cb_sym_to_deribit_inst,
-    cb_sym_to_deribit_inst,
-    str_to_cb_sym,
     maybe_open_price_feed
 )
-from .venues import (
-    Pair,
-    OptionPair,
-    Trade,
-)
 
 _spawn_kwargs = {
     'infect_asyncio': True,
@@ -85,215 +64,90 @@ async def open_history_client(
     mkt: MktPair,
 ) -> tuple[Callable, int]:
 
+    fnstrument: str = mkt.bs_fqme
     # TODO implement history getter for the new storage layer.
     async with open_cached_client('deribit') as client:
 
-        pair: OptionPair = client._pairs[mkt.dst.name]
-        # XXX NOTE, the cuckers use ms !!!
-        creation_time_s: int = pair.creation_timestamp/1000
-
         async def get_ohlc(
-            timeframe: float,
+            end_dt: Optional[datetime] = None,
-            end_dt: datetime | None = None,
+            start_dt: Optional[datetime] = None,
-            start_dt: datetime | None = None,
 
         ) -> tuple[
             np.ndarray,
             datetime,  # start
             datetime,  # end
         ]:
-            if timeframe != 60:
-                raise DataUnavailable('Only 1m bars are supported')
 
-            array: np.ndarray = await client.bars(
+            array = await client.bars(
-                mkt,
+                instrument,
                 start_dt=start_dt,
                 end_dt=end_dt,
             )
             if len(array) == 0:
-                if (
+                raise DataUnavailable
-                    end_dt is None
-                ):
-                    raise DataUnavailable(
-                        'No history seems to exist yet?\n\n'
-                        f'{mkt}'
-                    )
-                elif (
-                    end_dt
-                    and
-                    end_dt.timestamp() < creation_time_s
-                ):
-                    # the contract can't have history
-                    # before it was created.
-                    pair_type_str: str = type(pair).__name__
-                    create_dt: datetime = from_timestamp(creation_time_s)
-                    raise DataUnavailable(
-                        f'No history prior to\n'
-                        f'`{pair_type_str}.creation_timestamp: int = '
-                        f'{pair.creation_timestamp}\n\n'
-                        f'------ deribit sux ------\n'
-                        f'WHICH IN "NORMAL PEOPLE WHO USE EPOCH TIME" form is,\n'
-                        f'creation_time_s: {creation_time_s}\n'
-                        f'create_dt: {create_dt}\n'
-                    )
-                raise NoData(
-                    f'No frame for {start_dt} -> {end_dt}\n'
-                )
 
-            start_dt = from_timestamp(array[0]['time'])
+            start_dt = pendulum.from_timestamp(array[0]['time'])
-            end_dt = from_timestamp(array[-1]['time'])
+            end_dt = pendulum.from_timestamp(array[-1]['time'])
-
-            times = array['time']
-            if not times.any():
-                raise ValueError(
-                    'Bad frame with null-times?\n\n'
-                    f'{times}'
-                )
-
-            if end_dt is None:
-                inow: int = round(time.time())
-                if (inow - times[-1]) > 60:
-                    await tractor.pause()
 
             return array, start_dt, end_dt
 
-        yield (
+        yield get_ohlc, {'erlangs': 3, 'rate': 3}
-            get_ohlc,
-            {  # backfill config
-                'erlangs': 3,
-                'rate': 3,
-            }
-        )
-
-
-@async_lifo_cache()
-async def get_mkt_info(
-    fqme: str,
-
-) -> tuple[MktPair, Pair|OptionPair] | None:
-
-    # uppercase since kraken bs_mktid is always upper
-    if 'deribit' not in fqme.lower():
-        fqme += '.deribit'
-
-    mkt_mode: str = ''
-    broker, mkt_ep, venue, expiry = unpack_fqme(fqme)
-
-    # NOTE: we always upper case all tokens to be consistent with
-    # binance's symbology style for pairs, like `BTCUSDT`, but in
-    # theory we could also just keep things lower case; as long as
-    # we're consistent and the symcache matches whatever this func
-    # returns, always!
-    expiry: str = expiry.upper()
-    venue: str = venue.upper()
-    # venue_lower: str = venue.lower()
-
-    mkt_mode: str = 'option'
-
-    async with open_cached_client(
-        'deribit',
-    ) as client:
-
-        assets: dict[str, Asset] = await client.get_assets()
-        pair_str: str = mkt_ep.lower()
-
-        pair: Pair = await client.exch_info(
-            sym=pair_str,
-        )
-        mkt_mode = pair.venue
-        client.mkt_mode = mkt_mode
-
-        dst: Asset | None = assets.get(pair.bs_dst_asset)
-        src: Asset | None = assets.get(pair.bs_src_asset)
-
-        mkt = MktPair(
-            dst=dst,
-            src=src,
-            price_tick=pair.price_tick,
-            size_tick=pair.size_tick,
-            bs_mktid=pair.symbol,
-            venue=mkt_mode,
-            broker='deribit',
-            _atype=mkt_mode,
-            _fqme_without_src=True,
-
-            # expiry=pair.expiry,
-            # XXX TODO, currently we don't use it since it's
-            # already "described" in the `OptionPair.symbol: str`
-            # and if we slap in the ISO repr it's kinda hideous..
-            # -[ ] figure out the best either std
-        )
-        return mkt, pair
 
 
 async def stream_quotes(
+
     send_chan: trio.abc.SendChannel,
     symbols: list[str],
     feed_is_live: trio.Event,
+    loglevel: str = None,
 
     # startup sync
     task_status: TaskStatus[tuple[dict, dict]] = trio.TASK_STATUS_IGNORED,
 
 ) -> None:
-    '''
+    # XXX: required to propagate ``tractor`` loglevel to piker logging
-    Open a live quote stream for the market set defined by `symbols`.
+    get_console_log(loglevel or tractor.current_actor().loglevel)
 
-    Internally this starts a `cryptofeed.FeedHandler` inside an `asyncio`-side
+    sym = symbols[0]
-    task and relays through L1 and `Trade` msgs here to our `trio.Task`.
-
-    '''
-    sym = symbols[0].split('.')[0]
-    init_msgs: list[FeedInit] = []
-
-    # multiline nested `dict` formatter (since rn quote-msgs are
-    # just that).
-    pfmt: Callable[[str], str] = mk_repr(
-        # so we can see `deribit`'s delightfully mega-long bs fields..
-        maxstring=100,
-    )
 
     async with (
         open_cached_client('deribit') as client,
         send_chan as send_chan
     ):
-        mkt: MktPair
-        pair: Pair
-        mkt, pair = await get_mkt_info(sym)
 
-        # build out init msgs according to latest spec
+        init_msgs = {
-        init_msgs.append(
+            # pass back token, and bool, signalling if we're the writer
-            FeedInit(
+            # and that history has been written
-                mkt_info=mkt,
+            sym: {
-            )
+                'symbol_info': {
-        )
+                    'asset_type': 'option',
-        # build `cryptofeed` feed-handle
+                    'price_tick_size': 0.0005
-        cf_sym: cryptofeed.Symbol = piker_sym_to_cb_sym(sym)
+                },
+                'shm_write_opts': {'sum_tick_vml': False},
+                'fqsn': sym,
+            },
+        }
 
-        from_cf: tractor.to_asyncio.LinkedTaskChannel
+        nsym = piker_sym_to_cb_sym(sym)
-        async with maybe_open_price_feed(sym) as from_cf:
 
-            # load the "last trades" summary
+        async with maybe_open_price_feed(sym) as stream:
-            last_trades_res: cryptofeed.LastTradesResult = await client.last_trades(
-                cb_sym_to_deribit_inst(cf_sym),
-                count=1,
-            )
-            last_trades: list[Trade] = last_trades_res.trades
 
-            # TODO, do we even need this or will the above always
+            cache = await client.cache_symbols()
-            # work?
-            # if not last_trades:
-            #     await tractor.pause()
-            #     async for typ, quote in from_cf:
-            #         if typ == 'trade':
-            #             last_trade = Trade(**(quote['data']))
-            #             break
 
-            # else:
+            last_trades = (await client.last_trades(
-            last_trade = Trade(
+                cb_sym_to_deribit_inst(nsym), count=1)).trades
-                **(last_trades[0])
-            )
 
-            first_quote: dict = {
+            if len(last_trades) == 0:
+                last_trade = None
+                async for typ, quote in stream:
+                    if typ == 'trade':
+                        last_trade = Trade(**(quote['data']))
+                        break
+
+            else:
+                last_trade = Trade(**(last_trades[0]))
+
+            first_quote = {
                 'symbol': sym,
                 'last': last_trade.price,
                 'brokerd_ts': last_trade.timestamp,
@@ -304,84 +158,13 @@ async def stream_quotes(
                     'broker_ts': last_trade.timestamp
                 }]
             }
-            task_status.started((
+            task_status.started((init_msgs,  first_quote))
-                init_msgs,
-                first_quote,
-            ))
 
             feed_is_live.set()
 
-            # NOTE XXX, static for now!
+            async for typ, quote in stream:
-            # => since this only handles ONE mkt feed at a time we
+                topic = quote['symbol']
-            # don't need a lookup table to map interleaved quotes
+                await send_chan.send({topic: quote})
-            # from multiple possible mkt-pairs
-            topic: str = mkt.bs_fqme
-
-            # deliver until cancelled
-            async for typ, ref in from_cf:
-                match typ:
-                    case 'trade':
-                        trade: cryptofeed.types.Trade = ref
-
-                        # TODO, re-impl this according to teh ideal
-                        # fqme for opts that we choose!!
-                        bs_fqme: str = cb_sym_to_deribit_inst(
-                            str_to_cb_sym(trade.symbol)
-                        ).lower()
-
-                        piker_quote: dict = {
-                            'symbol': bs_fqme,
-                            'last': trade.price,
-                            'broker_ts': time.time(),
-                            # ^TODO, name this `brokerd/datad_ts` and
-                            # use `time.time_ns()` ??
-                            'ticks': [{
-                                'type': 'trade',
-                                'price': float(trade.price),
-                                'size': float(trade.amount),
-                                'broker_ts': trade.timestamp,
-                            }],
-                        }
-                        log.info(
-                            f'deribit {typ!r} quote for {sym!r}\n\n'
-                            f'{trade}\n\n'
-                            f'{pfmt(piker_quote)}\n'
-                        )
-
-                    case 'l1':
-                        book: cryptofeed.types.L1Book = ref
-
-                        # TODO, so this is where we can possibly change things
-                        # and instead lever the `MktPair.bs_fqme: str` output?
-                        bs_fqme: str = cb_sym_to_deribit_inst(
-                            str_to_cb_sym(book.symbol)
-                        ).lower()
-
-                        piker_quote: dict = {
-                            'symbol': bs_fqme,
-                            'ticks': [
-
-                                {'type': 'bid',
-                                 'price': float(book.bid_price),
-                                 'size': float(book.bid_size)},
-
-                                {'type': 'bsize',
-                                 'price': float(book.bid_price),
-                                 'size': float(book.bid_size),},
-
-                                {'type': 'ask',
-                                 'price': float(book.ask_price),
-                                 'size': float(book.ask_size),},
-
-                                {'type': 'asize',
-                                 'price': float(book.ask_price),
-                                 'size': float(book.ask_size),}
-                            ]
-                        }
-
-                await send_chan.send({
-                    topic: piker_quote,
-                })
 
 
 @tractor.context
@@ -391,21 +174,12 @@ async def open_symbol_search(
     async with open_cached_client('deribit') as client:
 
         # load all symbols locally for fast search
-        # cache = client._pairs
+        cache = await client.cache_symbols()
         await ctx.started()
 
         async with ctx.open_stream() as stream:
-            pattern: str
+
             async for pattern in stream:
-
+                # repack in dict form
-                # NOTE: pattern fuzzy-matching is done within
+                await stream.send(
-                # the methd impl.
+                    await client.search_symbols(pattern))
-                pairs: dict[str, Pair] = await client.search_symbols(
-                    pattern,
-                )
-                # repack in fqme-keyed table
-                byfqme: dict[str, Pair] = {}
-                for pair in pairs.values():
-                    byfqme[pair.bs_fqme] = pair
-
-                await stream.send(byfqme)

piker/brokers/deribit/venues.py

@@ -1,196 +0,0 @@
-# piker: trading gear for hackers
-# Copyright (C) Tyler Goodlet (in stewardship for pikers)
-
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Affero General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU Affero General Public License for more details.
-
-# You should have received a copy of the GNU Affero General Public License
-# along with this program.  If not, see <https://www.gnu.org/licenses/>.
-
-"""
-Per market data-type definitions and schemas types.
-
-"""
-from __future__ import annotations
-import pendulum
-from typing import (
-    Literal,
-    Optional,
-)
-from decimal import Decimal
-
-from piker.types import Struct
-
-
-# API endpoint paths by venue / sub-API
-_domain: str = 'deribit.com'
-_url = f'https://www.{_domain}'
-
-# WEBsocketz
-_ws_url: str = f'wss://www.{_domain}/ws/api/v2'
-
-# test nets
-_testnet_ws_url: str = f'wss://test.{_domain}/ws/api/v2'
-
-MarketType = Literal[
-    'option'
-]
-
-
-def get_api_eps(venue: MarketType) -> tuple[str, str]:
-    '''
-    Return API ep root paths per venue.
-
-    '''
-    return {
-        'option': (
-            _ws_url,
-        ),
-    }[venue]
-
-
-class Pair(Struct, frozen=True, kw_only=True):
-
-    symbol: str
-
-    # src
-    quote_currency: str # 'BTC'
-
-    # dst
-    base_currency: str # "BTC",
-
-    tick_size: float # 0.0001 # [{'above_price': 0.005, 'tick_size': 0.0005}]
-    tick_size_steps: list[dict[str, float]] 
-
-    @property
-    def price_tick(self) -> Decimal:
-        return Decimal(str(self.tick_size_steps[0]['above_price']))
-
-    @property
-    def size_tick(self) -> Decimal:
-        return Decimal(str(self.tick_size))
-
-    @property
-    def bs_fqme(self) -> str:
-        return f'{self.symbol}'
-
-    @property
-    def bs_mktid(self) -> str:
-        return f'{self.symbol}.{self.venue}'
-
-
-class OptionPair(Pair, frozen=True):
-
-    taker_commission: float # 0.0003
-    strike: float # 5000.0
-    settlement_period: str # 'day'
-    settlement_currency: str # "BTC",
-    rfq: bool # false
-    price_index: str # 'btc_usd'
-    option_type: str # 'call'
-    min_trade_amount: float # 0.1
-    maker_commission: float # 0.0003
-    kind: str # 'option'
-    is_active: bool # true
-    instrument_type: str # 'reversed'
-    instrument_name: str # 'BTC-1SEP24-55000-C'
-    instrument_id: int # 364671
-    expiration_timestamp: int # 1725177600000
-    creation_timestamp: int # 1724918461000
-    counter_currency: str # 'USD' 
-    contract_size: float # '1.0'
-    block_trade_tick_size: float # '0.0001'
-    block_trade_min_trade_amount: int # '25'
-    block_trade_commission: float # '0.003'
-
-    # NOTE: see `.data._symcache.SymbologyCache.load()` for why
-    ns_path: str = 'piker.brokers.deribit:OptionPair'
-
-    # TODO, impl this without the MM:SS part of
-    # the `'THH:MM:SS..'` etc..
-    @property
-    def expiry(self) -> str:
-        iso_date = pendulum.from_timestamp(
-            self.expiration_timestamp / 1000
-        ).isoformat()
-        return iso_date 
-
-    @property
-    def venue(self) -> str:
-        return f'{self.instrument_type}_option'
-
-    @property
-    def bs_fqme(self) -> str:
-        return f'{self.symbol}'
-
-    @property
-    def bs_src_asset(self) -> str:
-        return f'{self.quote_currency}'
-
-    @property
-    def bs_dst_asset(self) -> str:
-        return f'{self.symbol}'
-
-
-PAIRTYPES: dict[MarketType, Pair] = {
-    'option': OptionPair,
-}
-
-
-class JSONRPCResult(Struct):
-    id: int
-    usIn: int
-    usOut: int
-    usDiff: int
-    testnet: bool
-    jsonrpc: str = '2.0'
-    error: Optional[dict] = None
-    result: Optional[list[dict]] = None
-
-
-class JSONRPCChannel(Struct):
-    method: str
-    params: dict
-    jsonrpc: str = '2.0'
-
-
-class KLinesResult(Struct):
-    low: list[float]
-    cost: list[float]
-    high: list[float]
-    open: list[float]
-    close: list[float]
-    ticks: list[int]
-    status: str
-    volume: list[float]
-
-
-class Trade(Struct):
-    iv: float
-    price: float
-    amount: float
-    trade_id: str
-    contracts: float
-    direction: str
-    trade_seq: int
-    timestamp: int
-    mark_price: float
-    index_price: float
-    tick_direction: int
-    instrument_name: str
-    combo_id: Optional[str] = '',
-    combo_trade_id: Optional[int] = 0,
-    block_trade_id: Optional[str] = '',
-    block_trade_leg_count: Optional[int] = 0,
-
-
-class LastTradesResult(Struct):
-    trades: list[Trade]
-    has_more: bool

piker/brokers/ib/api.py

@@ -96,10 +96,6 @@ from ._util import (
     get_logger,
 )
 
-# ?TODO? this can now be removed since it was originally to extend
-# with a `bar_vwap` field that we removed from the default ohlcv
-# dtype since it's better calculated in an FSP func
-#
 _bar_load_dtype: list[tuple[str, type]] = [
     # NOTE XXX: only part that's diff
     # from our default fields where

piker/brokers/kraken/broker.py

@@ -175,8 +175,9 @@ async def handle_order_requests(
 
             case {
                 'account': 'kraken.spot' as account,
-                'action': 'buy'|'sell',
+                'action': action,
-            }:
+            } if action in {'buy', 'sell'}:
+
                 # validate
                 order = BrokerdOrder(**msg)
 
@@ -261,12 +262,6 @@ async def handle_order_requests(
                 } | extra
 
                 log.info(f'Submitting WS order request:\n{pformat(req)}')
-
-                # NOTE HOWTO, debug order requests
-                #
-                # if 'XRP' in pair:
-                #     await tractor.pause()
-
                 await ws.send_msg(req)
 
                 # placehold for sanity checking in relay loop
@@ -1090,8 +1085,6 @@ async def handle_order_updates(
                         f'Failed to {action} order {reqid}:\n'
                         f'{errmsg}'
                     )
-                    # if tractor._state.debug_mode():
-                    #     await tractor.pause()
 
                     symbol: str = 'N/A'
                     if chain := apiflows.get(reqid):

piker/clearing/_ems.py

@@ -76,6 +76,7 @@ if TYPE_CHECKING:
 
 # TODO: numba all of this
 def mk_check(
+
     trigger_price: float,
     known_last: float,
     action: str,
@@ -161,7 +162,7 @@ async def clear_dark_triggers(
 
     router: Router,
     brokerd_orders_stream: tractor.MsgStream,
-    quote_stream: tractor.MsgStream,
+    quote_stream: tractor.ReceiveMsgStream,  # noqa
     broker: str,
     fqme: str,
 
@@ -177,7 +178,6 @@ async def clear_dark_triggers(
     '''
     # XXX: optimize this for speed!
     # TODO:
-    # - port to the new ringbuf stuff in `tractor.ipc`!
     # - numba all this!
     # - this stream may eventually contain multiple symbols
     quote_stream._raise_on_lag = False
@@ -1182,16 +1182,12 @@ async def process_client_order_cmds(
     submitting live orders immediately if requested by the client.
 
     '''
-    # TODO, only allow `msgspec.Struct` form!
+    # cmd: dict
-    cmd: dict
     async for cmd in client_order_stream:
-        log.info(
+        log.info(f'Received order cmd:\n{pformat(cmd)}')
-            f'Received order cmd:\n'
-            f'{pformat(cmd)}\n'
-        )
 
         # CAWT DAMN we need struct support!
-        oid: str = str(cmd['oid'])
+        oid = str(cmd['oid'])
 
         # register this stream as an active order dialog (msg flow) for
         # this order id such that translated message from the brokerd
@@ -1297,7 +1293,7 @@ async def process_client_order_cmds(
             case {
                 'oid': oid,
                 'symbol': fqme,
-                'price': price,
+                'price': trigger_price,
                 'size': size,
                 'action': ('buy' | 'sell') as action,
                 'exec_mode': ('live' | 'paper'),
@@ -1329,7 +1325,7 @@ async def process_client_order_cmds(
 
                     symbol=sym,
                     action=action,
-                    price=price,
+                    price=trigger_price,
                     size=size,
                     account=req.account,
                 )
@@ -1351,11 +1347,7 @@ async def process_client_order_cmds(
                 # (``translate_and_relay_brokerd_events()`` above) will
                 # handle relaying the ems side responses back to
                 # the client/cmd sender from this request
-                log.info(
+                log.info(f'Sending live order to {broker}:\n{pformat(msg)}')
-                    f'Sending live order to {broker}:\n'
-                    f'{pformat(msg)}'
-                )
-
                 await brokerd_order_stream.send(msg)
 
                 # an immediate response should be ``BrokerdOrderAck``
@@ -1371,7 +1363,7 @@ async def process_client_order_cmds(
             case {
                 'oid': oid,
                 'symbol': fqme,
-                'price': price,
+                'price': trigger_price,
                 'size': size,
                 'exec_mode': exec_mode,
                 'action': action,
@@ -1399,12 +1391,7 @@ async def process_client_order_cmds(
                 if isnan(last):
                     last = flume.rt_shm.array[-1]['close']
 
-                trigger_price: float = float(price)
+                pred = mk_check(trigger_price, last, action)
-                pred = mk_check(
-                    trigger_price,
-                    last,
-                    action,
-                )
 
                 # NOTE: for dark orders currently we submit
                 # the triggered live order at a price 5 ticks
@@ -1544,7 +1531,7 @@ async def _emsd_main(
     ctx: tractor.Context,
     fqme: str,
     exec_mode: str,  # ('paper', 'live')
-    loglevel: str|None = None,
+    loglevel: str | None = None,
 
 ) -> tuple[
     dict[

piker/clearing/_messages.py

@@ -19,7 +19,6 @@ Clearing sub-system message and protocols.
 
 """
 from __future__ import annotations
-from decimal import Decimal
 from typing import (
     Literal,
 )
@@ -72,15 +71,7 @@ class Order(Struct):
     symbol: str  # | MktPair
     account: str  # should we set a default as '' ?
 
-    # https://docs.python.org/3/library/decimal.html#decimal-objects
+    price: float
-    #
-    # ?TODO? decimal usage throughout?
-    # -[ ] possibly leverage the `Encoder(decimal_format='number')`
-    #  bit?
-    # |_https://jcristharif.com/msgspec/supported-types.html#decimal
-    # -[ ] should we also use it for .size?
-    #
-    price: Decimal
     size: float  # -ve is "sell", +ve is "buy"
 
     brokers: list[str] = []
@@ -187,7 +178,7 @@ class BrokerdOrder(Struct):
     time_ns: int
 
     symbol: str  # fqme
-    price: Decimal
+    price: float
     size: float
 
     # TODO: if we instead rely on a +ve/-ve size to determine

piker/clearing/_paper_engine.py

@@ -508,7 +508,7 @@ async def handle_order_requests(
                 reqid = await client.submit_limit(
                     oid=order.oid,
                     symbol=f'{order.symbol}.{client.broker}',
-                    price=float(order.price),
+                    price=order.price,
                     action=order.action,
                     size=order.size,
                     # XXX: by default 0 tells ``ib_insync`` methods that

piker/cli/__init__.py

@@ -335,7 +335,7 @@ def services(config, tl, ports):
                 name='service_query',
                 loglevel=config['loglevel'] if tl else None,
             ),
-            tractor.get_registry(
+            tractor.get_arbiter(
                 host=host,
                 port=ports[0]
             ) as portal

piker/data/_sampling.py

@@ -284,8 +284,7 @@ class Sampler:
 
                     except (
                         trio.BrokenResourceError,
-                        trio.ClosedResourceError,
+                        trio.ClosedResourceError
-                        trio.EndOfChannel,
                     ):
                         log.error(
                             f'{stream._ctx.chan.uid} dropped connection'
@@ -698,7 +697,7 @@ async def sample_and_broadcast(
 
                                 log.warning(
                                     f'Feed OVERRUN {sub_key}'
-                                    f'@{bus.brokername} -> \n'
+                                    '@{bus.brokername} -> \n'
                                     f'feed @ {chan.uid}\n'
                                     f'throttle = {throttle} Hz'
                                 )
@@ -877,7 +876,6 @@ async def uniform_rate_send(
         except tractor.RemoteActorError as rme:
             if rme.type is not tractor._exceptions.StreamOverrun:
                 raise
-
             ctx = stream._ctx
             chan = ctx.chan
             log.warning(
@@ -894,7 +892,6 @@ async def uniform_rate_send(
             trio.ClosedResourceError,
             trio.BrokenResourceError,
             ConnectionResetError,
-            trio.EndOfChannel,
         ):
             # if the feed consumer goes down then drop
             # out of this rate limiter

piker/log.py

@@ -18,11 +18,7 @@
 Log like a forester!
 """
 import logging
-import reprlib
 import json
-from typing import (
-    Callable,
-)
 
 import tractor
 from pygments import (
@@ -88,27 +84,3 @@ def colorize_json(
         # likeable styles: algol_nu, tango, monokai
         formatters.TerminalTrueColorFormatter(style=style)
     )
-
-
-def mk_repr(
-    **repr_kws,
-) -> Callable[[str], str]:
-    '''
-    Allocate and deliver a `repr.Repr` instance with provided input
-    settings using the std-lib's `reprlib` mod,
-     * https://docs.python.org/3/library/reprlib.html
-
-    ------ Ex. ------
-    An up to 6-layer-nested `dict` as multi-line:
-    - https://stackoverflow.com/a/79102479
-    - https://docs.python.org/3/library/reprlib.html#reprlib.Repr.maxlevel
-
-    '''
-    def_kws: dict[str, int] = dict(
-        indent=2,
-        maxlevel=6,  # recursion levels
-        maxstring=66,  # match editor line-len limit
-    )
-    def_kws |= repr_kws
-    reprr = reprlib.Repr(**def_kws)
-    return reprr.repr

piker/storage/__init__.py

@@ -138,16 +138,6 @@ class StorageClient(
     ) -> None:
         ...
 
-    async def write_oi(
-        self,
-        fqme: str,
-        oi: np.ndarray,
-        append_and_duplicate: bool = True,
-        limit: int = int(800e3),
-
-    ) -> None:
-        ...
-
 
 class TimeseriesNotFound(Exception):
     '''

piker/storage/nativedb.py

@@ -111,24 +111,6 @@ def mk_ohlcv_shm_keyed_filepath(
     return path
 
 
-def mk_oi_shm_keyed_filepath(
-    fqme: str,
-    period: float | int,
-    datadir: Path,
-
-) -> Path:
-
-    if period < 1.:
-        raise ValueError('Sample period should be >= 1.!?')
-
-    path: Path = (
-        datadir
-        /
-        f'{fqme}.oi{int(period)}s.parquet'
-    )
-    return path
-
-
 def unpack_fqme_from_parquet_filepath(path: Path) -> str:
 
     filename: str = str(path.name)
@@ -190,11 +172,7 @@ class NativeStorageClient:
 
             key: str = path.name.rstrip('.parquet')
             fqme, _, descr = key.rpartition('.')
-            if 'ohlcv' in descr: 
             prefix, _, suffix = descr.partition('ohlcv')
-            elif 'oi' in descr:
-                prefix, _, suffix = descr.partition('oi')
-
             period: int = int(suffix.strip('s'))
 
             # cache description data
@@ -391,61 +369,6 @@ class NativeStorageClient:
             timeframe,
         )
 
-    def _write_oi(
-        self,
-        fqme: str,
-        oi: np.ndarray,
-
-    ) -> Path:
-        '''
-        Sync version of the public interface meth, since we don't
-        currently actually need or support an async impl.
-
-        '''
-        path: Path = mk_oi_shm_keyed_filepath(
-            fqme=fqme,
-            period=1,
-            datadir=self._datadir,
-        )
-        if isinstance(oi, np.ndarray):
-            new_df: pl.DataFrame = tsp.np2pl(oi)
-        else:
-            new_df = oi
-
-        if path.exists():
-            old_df = pl.read_parquet(path)
-            df = pl.concat([old_df, new_df])
-        else:
-            df = new_df
-
-        start = time.time()
-        df.write_parquet(path)
-        delay: float = round(
-            time.time() - start,
-            ndigits=6,
-        )
-        log.info(
-            f'parquet write took {delay} secs\n'
-            f'file path: {path}'
-        )
-        return path
-
-    async def write_oi(
-        self,
-        fqme: str,
-        oi: np.ndarray,
-
-    ) -> Path:
-        '''
-        Write input oi time series for fqme and sampling period
-        to (local) disk.
-
-        '''
-        return self._write_oi(
-            fqme,
-            oi,
-        )
-
     async def delete_ts(
         self,
         key: str,

piker/ui/order_mode.py

@@ -21,7 +21,6 @@ Chart trading, the only way to scalp.
 from __future__ import annotations
 from contextlib import asynccontextmanager
 from dataclasses import dataclass, field
-from decimal import Decimal
 from functools import partial
 from pprint import pformat
 import time
@@ -42,6 +41,7 @@ from piker.accounting import (
     Position,
     mk_allocator,
     MktPair,
+    Symbol,
 )
 from piker.clearing import (
     open_ems,
@@ -143,15 +143,6 @@ class OrderMode:
     }
     _staged_order: Order | None = None
 
-    @property
-    def curr_mkt(self) -> MktPair:
-        '''
-        Deliver the currently selected `MktPair` according
-        chart state.
-
-        '''
-        return self.chart.linked.mkt
-
     def on_level_change_update_next_order_info(
         self,
         level: float,
@@ -181,11 +172,7 @@ class OrderMode:
         line.update_labels(order_info)
 
         # update bound-in staged order
-        mkt: MktPair = self.curr_mkt
+        order.price = level
-        order.price: Decimal = mkt.quantize(
-            size=level,
-            quantity_type='price',
-        )
         order.size = order_info['size']
 
         # when an order is changed we flip the settings side-pane to
@@ -200,9 +187,7 @@ class OrderMode:
 
     ) -> LevelLine:
 
-        # TODO, if we instead just always decimalize at the ems layer
+        level = order.price
-        # we can avoid this back-n-forth casting?
-        level = float(order.price)
 
         line = order_line(
             chart or self.chart,
@@ -239,11 +224,7 @@ class OrderMode:
             # the order mode allocator but we still need to update the
             # "staged" order message we'll send to the ems
             def update_order_price(y: float) -> None:
-                mkt: MktPair = self.curr_mkt
+                order.price = y
-                order.price: Decimal = mkt.quantize(
-                    size=y,
-                    quantity_type='price',
-                )
 
             line._on_level_change = update_order_price
 
@@ -294,31 +275,34 @@ class OrderMode:
         chart = cursor.linked.chart
         if (
             not chart
-            and
+            and cursor
-            cursor
+            and cursor.active_plot
-            and
-            cursor.active_plot
         ):
             return
 
         chart = cursor.active_plot
-        price: float = cursor._datum_xy[1]
+        price = cursor._datum_xy[1]
         if not price:
             # zero prices are not supported by any means
             # since that's illogical / a no-op.
             return
 
+        mkt: MktPair = self.chart.linked.mkt
+
+        # NOTE : we could also use instead,
+        # mkt.quantize(price, quantity_type='price')
+        # but it returns a Decimal and it's probably gonna
+        # be slower?
         # TODO: should we be enforcing this precision
-        # at a different layer in the stack?
+        # at a different layer in the stack? right now
-        # |_ might require `MktPair` tracking in the EMS?
+        # any precision error will literally be relayed
-        # |_ right now any precision error will be relayed
+        # all the way back from the backend.
-        #    all the way back from the backend and vice-versa..
+
-        #
+        price = round(
-        mkt: MktPair = self.curr_mkt
+            price,
-        price: Decimal = mkt.quantize(
+            ndigits=mkt.price_tick_digits,
-            size=price,
-            quantity_type='price',
         )
+
         order = self._staged_order = Order(
             action=action,
             price=price,
@@ -394,7 +378,7 @@ class OrderMode:
                 'oid': oid,
             })
 
-        if float(order.price) <= 0:
+        if order.price <= 0:
             log.error(
                 '*!? Invalid `Order.price <= 0` ?!*\n'
                 # TODO: make this present multi-line in object form
@@ -531,15 +515,14 @@ class OrderMode:
             # if an order msg is provided update the line
             # **from** that msg.
             if order:
-                price: float = float(order.price)
+                if order.price <= 0:
-                if price <= 0:
                     log.error(f'Order has 0 price, cancelling..\n{order}')
                     self.cancel_orders([order.oid])
                     return None
 
-                line.set_level(price)
+                line.set_level(order.price)
                 self.on_level_change_update_next_order_info(
-                    level=price,
+                    level=order.price,
                     line=line,
                     order=order,
                     # use the corresponding position tracker for the
@@ -698,9 +681,9 @@ class OrderMode:
     ) -> Dialog | None:
         # NOTE: the `.order` attr **must** be set with the
         # equivalent order msg in order to be loaded.
-        order: Order = msg.req
+        order = msg.req
         oid = str(msg.oid)
-        symbol: str = order.symbol
+        symbol = order.symbol
 
         # TODO: MEGA UGGG ZONEEEE!
         src = msg.src
@@ -719,22 +702,13 @@ class OrderMode:
         order.oid = str(order.oid)
         order.brokers = [brokername]
 
-        # ?TODO? change this over to `MktPair`, but it's gonna be
+        # TODO: change this over to `MktPair`, but it's
-        # tough since we don't have any such data really in our
+        # gonna be tough since we don't have any such data
-        # clearing msg schema..
+        # really in our clearing msg schema..
-        # BUT WAIT! WHY do we even want/need this!?
+        order.symbol = Symbol.from_fqme(
-        #
+            fqsn=fqme,
-        # order.symbol = self.curr_mkt
+            info={},
-        #
+        )
-        # XXX, the old approach.. which i don't quire member why..
-        # -[ ] verify we for sure don't require this any more!
-        #  |_https://github.com/pikers/piker/issues/517
-        #
-        # order.symbol = Symbol.from_fqme(
-        #     fqsn=fqme,
-        #     info={},
-        # )
-
         maybe_dialog: Dialog | None = self.submit_order(
             send_msg=False,
             order=order,
@@ -1127,7 +1101,7 @@ async def process_trade_msg(
                         )
                     )
                 ):
-                    msg.req: Order = order
+                    msg.req = order
                     dialog: (
                         Dialog
                         # NOTE: on an invalid order submission (eg.
@@ -1192,7 +1166,7 @@ async def process_trade_msg(
             tm = time.time()
             mode.on_fill(
                 oid,
-                price=float(req.price),
+                price=req.price,
                 time_s=tm,
             )
             mode.lines.remove_line(uuid=oid)
@@ -1247,7 +1221,7 @@ async def process_trade_msg(
             tm = details['broker_time']
             mode.on_fill(
                 oid,
-                price=float(details['price']),
+                price=details['price'],
                 time_s=tm,
                 pointing='up' if action == 'buy' else 'down',
             )

ruff.toml

@@ -62,9 +62,8 @@ ignore-init-module-imports = false
 fixable = ["ALL"]
 unfixable = []
 
-# TODO? uhh why no work!?
 # Allow unused variables when underscore-prefixed.
-# dummy-variable-rgx = "^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$"
+dummy-variable-rgx = "^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$"
 
 [format]
 # Use single quotes in `ruff format`.

tests/test_ems.py

@@ -179,7 +179,7 @@ def test_ems_err_on_bad_broker(
         # NOTE: emsd should error on the actor's enabled modules
         # import phase, when looking for a backend named `doggy`.
         except tractor.RemoteActorError as re:
-            assert re.type is ModuleNotFoundError
+            assert re.type == ModuleNotFoundError
 
     run_and_tollerate_cancels(load_bad_fqme)