binance: add `AggTrade.nq: float`: "normal quantity" field..

Handle new API field per 2025-12-02 update.

(this patch was generated in some part by [`claude-code`][claude-code-gh])
[claude-code-gh]: https://github.com/anthropics/claude-code

config/conf.toml

@@ -1,9 +1,7 @@
 [network]
-pikerd = [
+tsdb.backend = 'marketstore'
-  '/ipv4/127.0.0.1/tcp/6116',  # std localhost daemon-actor tree
+tsdb.host = 'localhost'
-  # '/uds/6116',  # TODO std uds socket file
+tsdb.grpc_port = 5995
-]
-
 
 [ui]
 # set custom font + size which will scale entire UI

examples/basic_order_bot.py

@@ -121,7 +121,6 @@ async def bot_main():
             # tick_throttle=10,
         ) as feed,
 
-        tractor.trionics.collapse_eg(),
         trio.open_nursery() as tn,
     ):
         assert accounts

piker/accounting/_pos.py

@@ -365,11 +365,7 @@ class Position(Struct):
         # added: bool = False
         tid: str = t.tid
         if tid in self._events:
-            log.debug(
+            log.warning(f'{t} is already added?!')
-                f'Txn is already added?\n'
-                f'\n'
-                f'{t}\n'
-            )
             # return added
 
         # TODO: apparently this IS possible with a dict but not
@@ -735,7 +731,7 @@ class Account(Struct):
                     else:
                         # TODO: we reallly need a diff set of
                         # loglevels/colors per subsys.
-                        log.debug(
+                        log.warning(
                             f'Recent position for {fqme} was closed!'
                         )
 

piker/accounting/calc.py

@@ -465,7 +465,7 @@ def ledger_to_dfs(
 
         df = dfs[key] = ldf.with_columns([
 
-            pl.cum_sum('size').alias('cumsize'),
+            pl.cumsum('size').alias('cumsize'),
 
             # amount of source asset "sent" (via buy txns in
             # the market) to acquire the dst asset, PER txn.
@@ -480,7 +480,7 @@ def ledger_to_dfs(
         ]).with_columns([
 
             # rolling balance in src asset units
-            (pl.col('dst_bot').cum_sum() * -1).alias('src_balance'),
+            (pl.col('dst_bot').cumsum() * -1).alias('src_balance'),
 
             # "position operation type" in terms of increasing the
             # amount in the dst asset (entering) or decreasing the
@@ -622,7 +622,7 @@ def ledger_to_dfs(
                 # cost that was included in the least-recently
                 # entered txn that is still part of the current CSi
                 # set.
-                # => we look up the cost-per-unit cum_sum and apply
+                # => we look up the cost-per-unit cumsum and apply
                 # if over the current txn size (by multiplication)
                 # and then reverse that previusly applied cost on
                 # the txn_cost for this record.

piker/brokers/_daemon.py

@@ -96,10 +96,7 @@ async def _setup_persistent_brokerd(
     # - `open_symbol_search()`
     # NOTE: see ep invocation details inside `.data.feed`.
     try:
-        async with (
+        async with trio.open_nursery() as service_nursery:
-            tractor.trionics.collapse_eg(),
-            trio.open_nursery() as service_nursery
-        ):
             bus: _FeedsBus = feed.get_feed_bus(
                 brokername,
                 service_nursery,

piker/brokers/binance/broker.py

@@ -440,7 +440,6 @@ async def open_trade_dialog(
             #   - ledger: TransactionLedger
 
             async with (
-                tractor.trionics.collapse_eg(),
                 trio.open_nursery() as tn,
                 ctx.open_stream() as ems_stream,
             ):

piker/brokers/binance/feed.py

@@ -450,6 +450,7 @@ async def subscribe(
 
 
 async def stream_quotes(
+
     send_chan: trio.abc.SendChannel,
     symbols: list[str],
     feed_is_live: trio.Event,
@@ -461,7 +462,6 @@ async def stream_quotes(
 ) -> None:
 
     async with (
-        tractor.trionics.maybe_raise_from_masking_exc(),
         send_chan as send_chan,
         open_cached_client('binance') as client,
     ):

piker/brokers/deribit/api.py

@@ -31,7 +31,7 @@ from typing import (
     Callable,
 )
 
-from pendulum import now
+import pendulum
 import trio
 from trio_typing import TaskStatus
 from rapidfuzz import process as fuzzy
@@ -39,7 +39,6 @@ import numpy as np
 from tractor.trionics import (
     broadcast_receiver,
     maybe_open_context
-    collapse_eg,
 )
 from tractor import to_asyncio
 # XXX WOOPS XD
@@ -433,7 +432,6 @@ async def get_client(
 ) -> Client:
 
     async with (
-        collapse_eg(),
         trio.open_nursery() as n,
         open_jsonrpc_session(
             _testnet_ws_url, dtype=JSONRPCResult) as json_rpc

piker/brokers/ib/api.py

@@ -48,7 +48,6 @@ from bidict import bidict
 import trio
 import tractor
 from tractor import to_asyncio
-from tractor import trionics
 from pendulum import (
     from_timestamp,
     DateTime,
@@ -1370,8 +1369,8 @@ async def load_clients_for_trio(
     '''
     Pure async mngr proxy to ``load_aio_clients()``.
 
-    This is a bootstrap entrypoint to call from
+    This is a bootstrap entrypoing to call from
-    a `tractor.to_asyncio.open_channel_from()`.
+    a ``tractor.to_asyncio.open_channel_from()``.
 
     '''
     async with load_aio_clients(
@@ -1392,10 +1391,7 @@ async def open_client_proxies() -> tuple[
     async with (
         tractor.trionics.maybe_open_context(
             acm_func=tractor.to_asyncio.open_channel_from,
-            kwargs={
+            kwargs={'target': load_clients_for_trio},
-                'target': load_clients_for_trio,
-                # ^XXX, kwarg to `open_channel_from()`
-            },
 
             # lock around current actor task access
             # TODO: maybe this should be the default in tractor?
@@ -1588,8 +1584,7 @@ async def open_client_proxy(
             event_consumers=event_table,
         ) as (first, chan),
 
-        trionics.collapse_eg(),  # loose-ify
+        trio.open_nursery() as relay_n,
-        trio.open_nursery() as relay_tn,
     ):
 
         assert isinstance(first, Client)
@@ -1629,7 +1624,7 @@ async def open_client_proxy(
 
                     continue
 
-        relay_tn.start_soon(relay_events)
+        relay_n.start_soon(relay_events)
 
         yield proxy
 

piker/brokers/ib/broker.py

@@ -34,7 +34,6 @@ import trio
 from trio_typing import TaskStatus
 import tractor
 from tractor.to_asyncio import LinkedTaskChannel
-from tractor import trionics
 from ib_insync.contract import (
     Contract,
 )
@@ -408,7 +407,7 @@ async def update_and_audit_pos_msg(
 
     # TODO: make this a "propaganda" log level?
     if ibpos.avgCost != msg.avg_price:
-        log.debug(
+        log.warning(
             f'IB "FIFO" avg price for {msg.symbol} is DIFF:\n'
             f'ib: {ibfmtmsg}\n'
             '---------------------------\n'
@@ -739,7 +738,7 @@ async def open_trade_dialog(
                                 f'UNEXPECTED POSITION says IB => {msg.symbol}\n'
                                 'Maybe they LIQUIDATED YOU or your ledger is wrong?\n'
                             )
-                            log.debug(logmsg)
+                            log.error(logmsg)
 
             await ctx.started((
                 all_positions,
@@ -748,22 +747,21 @@ async def open_trade_dialog(
 
             async with (
                 ctx.open_stream() as ems_stream,
-                trionics.collapse_eg(),
+                trio.open_nursery() as n,
-                trio.open_nursery() as tn,
             ):
                 # relay existing open orders to ems
                 for msg in order_msgs:
                     await ems_stream.send(msg)
 
                 for client in set(aioclients.values()):
-                    trade_event_stream: LinkedTaskChannel = await tn.start(
+                    trade_event_stream: LinkedTaskChannel = await n.start(
                         open_trade_event_stream,
                         client,
                     )
 
                     # start order request handler **before** local trades
                     # event loop
-                    tn.start_soon(
+                    n.start_soon(
                         handle_order_requests,
                         ems_stream,
                         accounts_def,
@@ -771,7 +769,7 @@ async def open_trade_dialog(
                     )
 
                     # allocate event relay tasks for each client connection
-                    tn.start_soon(
+                    n.start_soon(
                         deliver_trade_events,
 
                         trade_event_stream,

piker/clearing/_client.py

@@ -25,10 +25,7 @@ from typing import TYPE_CHECKING
 
 import trio
 import tractor
-from tractor.trionics import (
+from tractor.trionics import broadcast_receiver
-    broadcast_receiver,
-    collapse_eg,
-)
 
 from ._util import (
     log,  # sub-sys logger
@@ -288,11 +285,8 @@ async def open_ems(
             client._ems_stream = trades_stream
 
             # start sync code order msg delivery task
-            async with (
+            async with trio.open_nursery() as n:
-                collapse_eg(),
+                n.start_soon(
-                trio.open_nursery() as tn,
-            ):
-                tn.start_soon(
                     relay_orders_from_sync_code,
                     client,
                     fqme,
@@ -308,4 +302,4 @@ async def open_ems(
                 )
 
                 # stop the sync-msg-relay task on exit.
-                tn.cancel_scope.cancel()
+                n.cancel_scope.cancel()

piker/clearing/_ems.py

@@ -42,7 +42,6 @@ from bidict import bidict
 import trio
 from trio_typing import TaskStatus
 import tractor
-from tractor import trionics
 
 from ._util import (
     log,  # sub-sys logger
@@ -77,6 +76,7 @@ if TYPE_CHECKING:
 
 # TODO: numba all of this
 def mk_check(
+
     trigger_price: float,
     known_last: float,
     action: str,
@@ -162,7 +162,7 @@ async def clear_dark_triggers(
 
     router: Router,
     brokerd_orders_stream: tractor.MsgStream,
-    quote_stream: tractor.MsgStream,
+    quote_stream: tractor.ReceiveMsgStream,  # noqa
     broker: str,
     fqme: str,
 
@@ -178,7 +178,6 @@ async def clear_dark_triggers(
     '''
     # XXX: optimize this for speed!
     # TODO:
-    # - port to the new ringbuf stuff in `tractor.ipc`!
     # - numba all this!
     # - this stream may eventually contain multiple symbols
     quote_stream._raise_on_lag = False
@@ -501,7 +500,7 @@ class Router(Struct):
 
     '''
     # setup at actor spawn time
-    _tn: trio.Nursery
+    nursery: trio.Nursery
 
     # broker to book map
     books: dict[str, DarkBook] = {}
@@ -671,7 +670,7 @@ class Router(Struct):
                 # dark book clearing loop, also lives with parent
                 # daemon to allow dark order clearing while no
                 # client is connected.
-                self._tn.start_soon(
+                self.nursery.start_soon(
                     clear_dark_triggers,
                     self,
                     relay.brokerd_stream,
@@ -694,7 +693,7 @@ class Router(Struct):
 
                 # spawn a ``brokerd`` order control dialog stream
                 # that syncs lifetime with the parent `emsd` daemon.
-                self._tn.start_soon(
+                self.nursery.start_soon(
                     translate_and_relay_brokerd_events,
                     broker,
                     relay.brokerd_stream,
@@ -768,12 +767,10 @@ async def _setup_persistent_emsd(
 
     global _router
 
-    # open a root "service task-nursery" for the `emsd`-actor
+    # open a root "service nursery" for the ``emsd`` actor
-    async with (
+    async with trio.open_nursery() as service_nursery:
-        trionics.collapse_eg(),
+
-        trio.open_nursery() as tn
+        _router = Router(nursery=service_nursery)
-    ):
-        _router = Router(_tn=tn)
 
         # TODO: send back the full set of persistent
         # orders/execs?
@@ -1193,16 +1190,12 @@ async def process_client_order_cmds(
     submitting live orders immediately if requested by the client.
 
     '''
-    # TODO, only allow `msgspec.Struct` form!
+    # cmd: dict
-    cmd: dict
     async for cmd in client_order_stream:
-        log.info(
+        log.info(f'Received order cmd:\n{pformat(cmd)}')
-            f'Received order cmd:\n'
-            f'{pformat(cmd)}\n'
-        )
 
         # CAWT DAMN we need struct support!
-        oid: str = str(cmd['oid'])
+        oid = str(cmd['oid'])
 
         # register this stream as an active order dialog (msg flow) for
         # this order id such that translated message from the brokerd
@@ -1308,7 +1301,7 @@ async def process_client_order_cmds(
             case {
                 'oid': oid,
                 'symbol': fqme,
-                'price': price,
+                'price': trigger_price,
                 'size': size,
                 'action': ('buy' | 'sell') as action,
                 'exec_mode': ('live' | 'paper'),
@@ -1340,7 +1333,7 @@ async def process_client_order_cmds(
 
                     symbol=sym,
                     action=action,
-                    price=price,
+                    price=trigger_price,
                     size=size,
                     account=req.account,
                 )
@@ -1362,11 +1355,7 @@ async def process_client_order_cmds(
                 # (``translate_and_relay_brokerd_events()`` above) will
                 # handle relaying the ems side responses back to
                 # the client/cmd sender from this request
-                log.info(
+                log.info(f'Sending live order to {broker}:\n{pformat(msg)}')
-                    f'Sending live order to {broker}:\n'
-                    f'{pformat(msg)}'
-                )
-
                 await brokerd_order_stream.send(msg)
 
                 # an immediate response should be ``BrokerdOrderAck``
@@ -1382,7 +1371,7 @@ async def process_client_order_cmds(
             case {
                 'oid': oid,
                 'symbol': fqme,
-                'price': price,
+                'price': trigger_price,
                 'size': size,
                 'exec_mode': exec_mode,
                 'action': action,
@@ -1410,12 +1399,7 @@ async def process_client_order_cmds(
                 if isnan(last):
                     last = flume.rt_shm.array[-1]['close']
 
-                trigger_price: float = float(price)
+                pred = mk_check(trigger_price, last, action)
-                pred = mk_check(
-                    trigger_price,
-                    last,
-                    action,
-                )
 
                 # NOTE: for dark orders currently we submit
                 # the triggered live order at a price 5 ticks
@@ -1522,7 +1506,7 @@ async def maybe_open_trade_relays(
         loglevel: str = 'info',
     ):
 
-        fqme, relay, feed, client_ready = await _router._tn.start(
+        fqme, relay, feed, client_ready = await _router.nursery.start(
             _router.open_trade_relays,
             fqme,
             exec_mode,
@@ -1555,7 +1539,7 @@ async def _emsd_main(
     ctx: tractor.Context,
     fqme: str,
     exec_mode: str,  # ('paper', 'live')
-    loglevel: str|None = None,
+    loglevel: str | None = None,
 
 ) -> tuple[
     dict[

piker/clearing/_messages.py

@@ -19,7 +19,6 @@ Clearing sub-system message and protocols.
 
 """
 from __future__ import annotations
-from decimal import Decimal
 from typing import (
     Literal,
 )
@@ -72,15 +71,7 @@ class Order(Struct):
     symbol: str  # | MktPair
     account: str  # should we set a default as '' ?
 
-    # https://docs.python.org/3/library/decimal.html#decimal-objects
+    price: float
-    #
-    # ?TODO? decimal usage throughout?
-    # -[ ] possibly leverage the `Encoder(decimal_format='number')`
-    #  bit?
-    # |_https://jcristharif.com/msgspec/supported-types.html#decimal
-    # -[ ] should we also use it for .size?
-    #
-    price: Decimal
     size: float  # -ve is "sell", +ve is "buy"
 
     brokers: list[str] = []
@@ -187,7 +178,7 @@ class BrokerdOrder(Struct):
     time_ns: int
 
     symbol: str  # fqme
-    price: Decimal
+    price: float
     size: float
 
     # TODO: if we instead rely on a +ve/-ve size to determine

piker/clearing/_paper_engine.py

@@ -510,7 +510,7 @@ async def handle_order_requests(
                 reqid = await client.submit_limit(
                     oid=order.oid,
                     symbol=f'{order.symbol}.{client.broker}',
-                    price=float(order.price),
+                    price=order.price,
                     action=order.action,
                     size=order.size,
                     # XXX: by default 0 tells ``ib_insync`` methods that

piker/cli/__init__.py

@@ -134,65 +134,86 @@ def pikerd(
     Spawn the piker broker-daemon.
 
     '''
-    # from tractor.devx import maybe_open_crash_handler
+    from tractor.devx import maybe_open_crash_handler
-    # with maybe_open_crash_handler(pdb=False):
+    with maybe_open_crash_handler(pdb=pdb):
-    log = get_console_log(loglevel, name='cli')
+        log = get_console_log(loglevel, name='cli')
 
-    if pdb:
+        if pdb:
-        log.warning((
+            log.warning((
-            "\n"
+                "\n"
-            "!!! YOU HAVE ENABLED DAEMON DEBUG MODE !!!\n"
+                "!!! YOU HAVE ENABLED DAEMON DEBUG MODE !!!\n"
-            "When a `piker` daemon crashes it will block the "
+                "When a `piker` daemon crashes it will block the "
-            "task-thread until resumed from console!\n"
+                "task-thread until resumed from console!\n"
-            "\n"
+                "\n"
-        ))
-
-    # service-actor registry endpoint socket-address set
-    regaddrs: list[tuple[str, int]] = []
-
-    conf, _ = config.load(
-        conf_name='conf',
-    )
-    network: dict = conf.get('network')
-    if (
-        network is None
-        and not maddr
-    ):
-        regaddrs = [(
-            _default_registry_host,
-            _default_registry_port,
-        )]
-
-    else:
-        eps: dict = load_trans_eps(
-            network,
-            maddr,
-        )
-        for layers in eps['pikerd']:
-            regaddrs.append((
-                layers['ipv4']['addr'],
-                layers['tcp']['port'],
             ))
 
-    from .. import service
+        # service-actor registry endpoint socket-address set
+        regaddrs: list[tuple[str, int]] = []
 
-    async def main():
+        conf, _ = config.load(
-        service_mngr: service.Services
+            conf_name='conf',
-        async with (
+        )
-            service.open_pikerd(
+        network: dict = conf.get('network')
-                registry_addrs=regaddrs,
+        if (
-                loglevel=loglevel,
+            network is None
-                debug_mode=pdb,
+            and not maddr
-                enable_transports=['uds'],
-                # enable_transports=['tcp'],
-            ) as service_mngr,
         ):
-            assert service_mngr
+            regaddrs = [(
-            # ?TODO? spawn all other sub-actor daemons according to
+                _default_registry_host,
-            # multiaddress endpoint spec defined by user config
+                _default_registry_port,
-            await trio.sleep_forever()
+            )]
 
-    trio.run(main)
+        else:
+            eps: dict = load_trans_eps(
+                network,
+                maddr,
+            )
+            for layers in eps['pikerd']:
+                regaddrs.append((
+                    layers['ipv4']['addr'],
+                    layers['tcp']['port'],
+                ))
+
+        from .. import service
+
+        async def main():
+            service_mngr: service.Services
+
+            async with (
+                service.open_pikerd(
+                    registry_addrs=regaddrs,
+                    loglevel=loglevel,
+                    debug_mode=pdb,
+
+                ) as service_mngr,  # normally delivers a ``Services`` handle
+
+                # AsyncExitStack() as stack,
+            ):
+                # TODO: spawn all other sub-actor daemons according to
+                # multiaddress endpoint spec defined by user config
+                assert service_mngr
+
+                # if tsdb:
+                #     dname, conf = await stack.enter_async_context(
+                #         service.marketstore.start_ahab_daemon(
+                #             service_mngr,
+                #             loglevel=loglevel,
+                #         )
+                #     )
+                #     log.info(f'TSDB `{dname}` up with conf:\n{conf}')
+
+                # if es:
+                #     dname, conf = await stack.enter_async_context(
+                #         service.elastic.start_ahab_daemon(
+                #             service_mngr,
+                #             loglevel=loglevel,
+                #         )
+                #     )
+                #     log.info(f'DB `{dname}` up with conf:\n{conf}')
+
+                await trio.sleep_forever()
+
+        trio.run(main)
 
 
 @click.group(context_settings=config._context_defaults)
@@ -307,10 +328,6 @@ def services(config, tl, ports):
     if not ports:
         ports = [_default_registry_port]
 
-    addr = tractor._addr.wrap_address(
-        addr=(host, ports[0])
-    )
-
     async def list_services():
         nonlocal host
         async with (
@@ -318,18 +335,16 @@ def services(config, tl, ports):
                 name='service_query',
                 loglevel=config['loglevel'] if tl else None,
             ),
-            tractor.get_registry(
+            tractor.get_arbiter(
-                addr=addr,
+                host=host,
+                port=ports[0]
             ) as portal
         ):
-            registry = await portal.run_from_ns(
+            registry = await portal.run_from_ns('self', 'get_registry')
-                'self',
-                'get_registry',
-            )
             json_d = {}
             for key, socket in registry.items():
-                json_d[key] = f'{socket}'
+                host, port = socket
-
+                json_d[key] = f'{host}:{port}'
             click.echo(f"{colorize_json(json_d)}")
 
     trio.run(list_services)

piker/config.py

@@ -41,13 +41,10 @@ from .log import get_logger
 log = get_logger('broker-config')
 
 
-# XXX NOTE: taken from `click`
+# XXX NOTE: taken from ``click`` since apparently they have some
-# |_https://github.com/pallets/click/blob/main/src/click/utils.py#L449
+# super weirdness with sigint and sudo..no clue
-#
+# we're probably going to slowly just modify it to our own version over
-# (since apparently they have some super weirdness with SIGINT and
+# time..
-# sudo.. no clue we're probably going to slowly just modify it to our
-# own version over time..)
-#
 def get_app_dir(
     app_name: str,
     roaming: bool = True,
@@ -264,7 +261,7 @@ def load(
         MutableMapping,
     ] = tomllib.loads,
 
-    touch_if_dne: bool = True,
+    touch_if_dne: bool = False,
 
     **tomlkws,
 
@@ -273,7 +270,7 @@ def load(
     Load config file by name.
 
     If desired config is not in the top level piker-user config path then
-    pass the `path: Path` explicitly.
+    pass the ``path: Path`` explicitly.
 
     '''
     # create the $HOME/.config/piker dir if dne
@@ -288,8 +285,7 @@ def load(
 
     if (
         not path.is_file()
-        and
+        and touch_if_dne
-        touch_if_dne
     ):
         # only do a template if no path provided,
         # just touch an empty file with same name.

piker/data/_sampling.py

@@ -740,7 +740,7 @@ async def sample_and_broadcast(
 
                                 log.warning(
                                     f'Feed OVERRUN {sub_key}'
-                                    f'@{bus.brokername} -> \n'
+                                    '@{bus.brokername} -> \n'
                                     f'feed @ {chan.uid}\n'
                                     f'throttle = {throttle} Hz'
                                 )

piker/data/_symcache.py

@@ -91,18 +91,6 @@ class SymbologyCache(Struct):
     # provided by the backend pkg.
     mktmaps: dict[str, MktPair] = field(default_factory=dict)
 
-    def pformat(self) -> str:
-        return (
-            f'<{type(self).__name__}(\n'
-            f' .mod: {self.mod!r}\n'
-            f' .assets: {len(self.assets)!r}\n'
-            f' .pairs: {len(self.pairs)!r}\n'
-            f' .mktmaps: {len(self.mktmaps)!r}\n'
-            f')>'
-        )
-
-    __repr__ = pformat
-
     def write_config(self) -> None:
 
         # put the backend's pair-struct type ref at the top

piker/data/_web_bs.py

@@ -27,6 +27,7 @@ from functools import partial
 from types import ModuleType
 from typing import (
     Any,
+    Optional,
     Callable,
     AsyncContextManager,
     AsyncGenerator,
@@ -34,7 +35,6 @@ from typing import (
 )
 import json
 
-import tractor
 import trio
 from trio_typing import TaskStatus
 from trio_websocket import (
@@ -167,7 +167,7 @@ async def _reconnect_forever(
 
     async def proxy_msgs(
         ws: WebSocketConnection,
-        rent_cs: trio.CancelScope,  # parent cancel scope
+        pcs: trio.CancelScope,  # parent cancel scope
     ):
         '''
         Receive (under `timeout` deadline) all msgs from from underlying
@@ -192,7 +192,7 @@ async def _reconnect_forever(
                         f'{url} connection bail with:'
                     )
                     await trio.sleep(0.5)
-                    rent_cs.cancel()
+                    pcs.cancel()
 
                     # go back to reonnect loop in parent task
                     return
@@ -204,7 +204,7 @@ async def _reconnect_forever(
                         f'{src_mod}\n'
                         'WS feed seems down and slow af.. reconnecting\n'
                     )
-                    rent_cs.cancel()
+                    pcs.cancel()
 
                     # go back to reonnect loop in parent task
                     return
@@ -228,12 +228,7 @@ async def _reconnect_forever(
     nobsws._connected = trio.Event()
     task_status.started()
 
-    mc_state: trio._channel.MemoryChannelState = snd._state
+    while not snd._closed:
-    while (
-        mc_state.open_receive_channels > 0
-        and
-        mc_state.open_send_channels > 0
-    ):
         log.info(
             f'{src_mod}\n'
             f'{url} trying (RE)CONNECT'
@@ -242,11 +237,10 @@ async def _reconnect_forever(
         ws: WebSocketConnection
         try:
             async with (
+                trio.open_nursery() as n,
                 open_websocket_url(url) as ws,
-                tractor.trionics.collapse_eg(),
-                trio.open_nursery() as tn,
             ):
-                cs = nobsws._cs = tn.cancel_scope
+                cs = nobsws._cs = n.cancel_scope
                 nobsws._ws = ws
                 log.info(
                     f'{src_mod}\n'
@@ -254,7 +248,7 @@ async def _reconnect_forever(
                 )
 
                 # begin relay loop to forward msgs
-                tn.start_soon(
+                n.start_soon(
                     proxy_msgs,
                     ws,
                     cs,
@@ -268,7 +262,7 @@ async def _reconnect_forever(
 
                     # TODO: should we return an explicit sub-cs
                     # from this fixture task?
-                    await tn.start(
+                    await n.start(
                         open_fixture,
                         fixture,
                         nobsws,
@@ -278,23 +272,11 @@ async def _reconnect_forever(
                 # to let tasks run **inside** the ws open block above.
                 nobsws._connected.set()
                 await trio.sleep_forever()
-
+        except HandshakeError:
-        except (
-            HandshakeError,
-            ConnectionRejected,
-        ):
             log.exception('Retrying connection')
-            await trio.sleep(0.5)  # throttle
 
-        except BaseException as _berr:
+        # ws & nursery block ends
-            berr = _berr
-            log.exception(
-                'Reconnect-attempt failed ??\n'
-            )
-            await trio.sleep(0.2)  # throttle
-            raise berr
 
-        #|_ws & nursery block ends
         nobsws._connected = trio.Event()
         if cs.cancelled_caught:
             log.cancel(
@@ -342,25 +324,21 @@ async def open_autorecon_ws(
     connetivity errors, or some user defined recv timeout.
 
     You can provide a ``fixture`` async-context-manager which will be
-    entered/exitted around each connection reset; eg. for
+    entered/exitted around each connection reset; eg. for (re)requesting
-    (re)requesting subscriptions without requiring streaming setup
+    subscriptions without requiring streaming setup code to rerun.
-    code to rerun.
 
     '''
     snd: trio.MemorySendChannel
     rcv: trio.MemoryReceiveChannel
     snd, rcv = trio.open_memory_channel(616)
 
-    async with (
+    async with trio.open_nursery() as n:
-        tractor.trionics.collapse_eg(),
-        trio.open_nursery() as tn
-    ):
         nobsws = NoBsWs(
             url,
             rcv,
             msg_recv_timeout=msg_recv_timeout,
         )
-        await tn.start(
+        await n.start(
             partial(
                 _reconnect_forever,
                 url,
@@ -373,10 +351,11 @@ async def open_autorecon_ws(
         await nobsws._connected.wait()
         assert nobsws._cs
         assert nobsws.connected()
+
         try:
             yield nobsws
         finally:
-            tn.cancel_scope.cancel()
+            n.cancel_scope.cancel()
 
 
 '''
@@ -389,8 +368,8 @@ of msgs over a `NoBsWs`.
 class JSONRPCResult(Struct):
     id: int
     jsonrpc: str = '2.0'
-    result: dict|None = None
+    result: Optional[dict] = None
-    error: dict|None = None
+    error: Optional[dict] = None
 
 
 @acm

piker/data/feed.py

@@ -39,7 +39,6 @@ from typing import (
     AsyncContextManager,
     Awaitable,
     Sequence,
-    TYPE_CHECKING,
 )
 
 import trio
@@ -76,10 +75,6 @@ from ._sampling import (
     uniform_rate_send,
 )
 
-if TYPE_CHECKING:
-    from tractor._addr import Address
-    from tractor.msg.types import Aid
-
 
 class Sub(Struct, frozen=True):
     '''
@@ -357,9 +352,7 @@ async def allocate_persistent_feed(
 
     # yield back control to starting nursery once we receive either
     # some history or a real-time quote.
-    log.info(
+    log.info(f'loading OHLCV history: {fqme}')
-        f'loading OHLCV history: {fqme!r}\n'
-    )
     await some_data_ready.wait()
 
     flume = Flume(
@@ -730,10 +723,7 @@ class Feed(Struct):
                 async for msg in stream:
                     await tx.send(msg)
 
-        async with (
+        async with trio.open_nursery() as nurse:
-            tractor.trionics.collapse_eg(),
-            trio.open_nursery() as nurse
-        ):
             # spawn a relay task for each stream so that they all
             # multiplex to a common channel.
             for brokername in mods:
@@ -796,6 +786,7 @@ async def install_brokerd_search(
 
 @acm
 async def maybe_open_feed(
+
     fqmes: list[str],
     loglevel: str | None = None,
 
@@ -849,12 +840,13 @@ async def maybe_open_feed(
 
 @acm
 async def open_feed(
+
     fqmes: list[str],
 
-    loglevel: str|None = None,
+    loglevel: str | None = None,
     allow_overruns: bool = True,
     start_stream: bool = True,
-    tick_throttle: float|None = None,  # Hz
+    tick_throttle: float | None = None,  # Hz
 
     allow_remote_ctl_ui: bool = False,
 
@@ -907,19 +899,19 @@ async def open_feed(
             feed.portals[brokermod] = portal
 
             # fill out "status info" that the UI can show
-            chan: tractor.Channel = portal.chan
+            host, port = portal.channel.raddr
-            raddr: Address = chan.raddr
+            if host == '127.0.0.1':
-            aid: Aid = chan.aid
+                host = 'localhost'
-            # TAG_feed_status_update
+
             feed.status.update({
-                'actor_id': aid,
+                'actor_name': portal.channel.uid[0],
-                'actor_short_id': f'{aid.name}@{aid.pid}',
+                'host': host,
-                'ipc': chan.raddr.proto_key,
+                'port': port,
-                'ipc_addr': raddr,
                 'hist_shm': 'NA',
                 'rt_shm': 'NA',
-                'throttle_hz': tick_throttle,
+                'throttle_rate': tick_throttle,
             })
+            # feed.status.update(init_msg.pop('status', {}))
 
             # (allocate and) connect to any feed bus for this broker
             bus_ctxs.append(

piker/data/flows.py

@@ -36,10 +36,10 @@ from ._sharedmem import (
     ShmArray,
     _Token,
 )
-from piker.accounting import MktPair
 
 if TYPE_CHECKING:
-    from piker.data.feed import Feed
+    from ..accounting import MktPair
+    from .feed import Feed
 
 
 class Flume(Struct):
@@ -82,7 +82,7 @@ class Flume(Struct):
 
     # TODO: do we need this really if we can pull the `Portal` from
     # ``tractor``'s internals?
-    feed: Feed|None = None
+    feed: Feed | None = None
 
     @property
     def rt_shm(self) -> ShmArray:

piker/data/validate.py

@@ -113,9 +113,9 @@ def validate_backend(
             )
             if ep is None:
                 log.warning(
-                    f'Provider backend {mod.name!r} is missing '
+                    f'Provider backend {mod.name} is missing '
-                    f'{daemon_name!r} support?\n'
+                    f'{daemon_name} support :(\n'
-                    f'|_module endpoint-func missing: {name!r}\n'
+                    f'The following endpoint is missing: {name}'
                 )
 
     inits: list[

piker/fsp/_engine.py

@@ -498,7 +498,6 @@ async def cascade(
 
         func_name: str = func.__name__
         async with (
-            tractor.trionics.collapse_eg(),  # avoid multi-taskc tb in console
             trio.open_nursery() as tn,
         ):
             # TODO: might be better to just make a "restart" method where

piker/service/_actor_runtime.py

@@ -107,22 +107,17 @@ async def open_piker_runtime(
         async with (
             tractor.open_root_actor(
 
-                # passed through to `open_root_actor`
+                # passed through to ``open_root_actor``
                 registry_addrs=registry_addrs,
                 name=name,
-                start_method=start_method,
                 loglevel=loglevel,
                 debug_mode=debug_mode,
-
+                start_method=start_method,
-                # XXX NOTE MEMBER DAT der's a perf hit yo!!
-                # https://greenback.readthedocs.io/en/latest/principle.html#performance
-                maybe_enable_greenback=True,
 
                 # TODO: eventually we should be able to avoid
                 # having the root have more then permissions to
                 # spawn other specialized daemons I think?
                 enable_modules=enable_modules,
-                hide_tb=False,
 
                 **tractor_kwargs,
             ) as actor,
@@ -205,8 +200,7 @@ async def open_pikerd(
             reg_addrs,
         ),
         tractor.open_nursery() as actor_nursery,
-        tractor.trionics.collapse_eg(),
+        trio.open_nursery() as service_nursery,
-        trio.open_nursery() as service_tn,
     ):
         for addr in reg_addrs:
             if addr not in root_actor.accept_addrs:
@@ -217,7 +211,7 @@ async def open_pikerd(
 
         # assign globally for future daemon/task creation
         Services.actor_n = actor_nursery
-        Services.service_n = service_tn
+        Services.service_n = service_nursery
         Services.debug_mode = debug_mode
 
         try:
@@ -227,7 +221,7 @@ async def open_pikerd(
             # TODO: is this more clever/efficient?
             # if 'samplerd' in Services.service_tasks:
             #     await Services.cancel_service('samplerd')
-            service_tn.cancel_scope.cancel()
+            service_nursery.cancel_scope.cancel()
 
 
 # TODO: do we even need this?
@@ -262,10 +256,7 @@ async def maybe_open_pikerd(
     loglevel: str | None = None,
     **kwargs,
 
-) -> (
+) -> tractor._portal.Portal | ClassVar[Services]:
-    tractor._portal.Portal
-    |ClassVar[Services]
-):
     '''
     If no ``pikerd`` daemon-root-actor can be found start it and
     yield up (we should probably figure out returning a portal to self
@@ -290,11 +281,10 @@ async def maybe_open_pikerd(
 
     registry_addrs: list[tuple[str, int]] = (
         registry_addrs
-        or
+        or [_default_reg_addr]
-        [_default_reg_addr]
     )
 
-    pikerd_portal: tractor.Portal|None
+    pikerd_portal: tractor.Portal | None
     async with (
         open_piker_runtime(
             name=query_name,

piker/service/_daemon.py

@@ -28,7 +28,6 @@ from contextlib import (
 )
 
 import tractor
-from trio.lowlevel import current_task
 
 from ._util import (
     log,  # sub-sys logger
@@ -71,84 +70,69 @@ async def maybe_spawn_daemon(
     lock = Services.locks[service_name]
     await lock.acquire()
 
-    try:
+    async with find_service(
-        async with find_service(
+        service_name,
-            service_name,
+        registry_addrs=[('127.0.0.1', 6116)],
-            registry_addrs=[('127.0.0.1', 6116)],
+    ) as portal:
-        ) as portal:
+        if portal is not None:
-            if portal is not None:
-                lock.release()
-                yield portal
-                return
-
-        log.warning(
-            f"Couldn't find any existing {service_name}\n"
-            'Attempting to spawn new daemon-service..'
-        )
-
-        # ask root ``pikerd`` daemon to spawn the daemon we need if
-        # pikerd is not live we now become the root of the
-        # process tree
-        async with maybe_open_pikerd(
-            loglevel=loglevel,
-            **pikerd_kwargs,
-
-        ) as pikerd_portal:
-
-            # we are the root and thus are `pikerd`
-            # so spawn the target service directly by calling
-            # the provided target routine.
-            # XXX: this assumes that the target is well formed and will
-            # do the right things to setup both a sub-actor **and** call
-            # the ``_Services`` api from above to start the top level
-            # service task for that actor.
-            started: bool
-            if pikerd_portal is None:
-                started = await service_task_target(
-                    loglevel=loglevel,
-                    **spawn_args,
-                )
-
-            else:
-                # request a remote `pikerd` (service manager) to start the
-                # target daemon-task, the target can't return
-                # a non-serializable value since it is expected that service
-                # starting is non-blocking and the target task will persist
-                # running "under" or "within" the `pikerd` actor tree after
-                # the questing client disconnects. in other words this
-                # spawns a persistent daemon actor that continues to live
-                # for the lifespan of whatever the service manager inside
-                # `pikerd` says it should.
-                started = await pikerd_portal.run(
-                    service_task_target,
-                    loglevel=loglevel,
-                    **spawn_args,
-                )
-
-            if started:
-                log.info(f'Service {service_name} started!')
-
-            # block until we can discover (by IPC connection) to the newly
-            # spawned daemon-actor and then deliver the portal to the
-            # caller.
-            async with tractor.wait_for_actor(service_name) as portal:
-                lock.release()
-                yield portal
-                await portal.cancel_actor()
-
-    except BaseException as _err:
-        err = _err
-        if (
-            lock.locked()
-            and
-            lock.statistics().owner is current_task()
-        ):
-            log.exception(
-                f'Releasing stale lock after crash..?'
-                f'{err!r}\n'
-            )
             lock.release()
-            raise err
+            yield portal
+            return
+
+    log.warning(
+        f"Couldn't find any existing {service_name}\n"
+        'Attempting to spawn new daemon-service..'
+    )
+
+    # ask root ``pikerd`` daemon to spawn the daemon we need if
+    # pikerd is not live we now become the root of the
+    # process tree
+    async with maybe_open_pikerd(
+        loglevel=loglevel,
+        **pikerd_kwargs,
+
+    ) as pikerd_portal:
+
+        # we are the root and thus are `pikerd`
+        # so spawn the target service directly by calling
+        # the provided target routine.
+        # XXX: this assumes that the target is well formed and will
+        # do the right things to setup both a sub-actor **and** call
+        # the ``_Services`` api from above to start the top level
+        # service task for that actor.
+        started: bool
+        if pikerd_portal is None:
+            started = await service_task_target(
+                loglevel=loglevel,
+                **spawn_args,
+            )
+
+        else:
+            # request a remote `pikerd` (service manager) to start the
+            # target daemon-task, the target can't return
+            # a non-serializable value since it is expected that service
+            # starting is non-blocking and the target task will persist
+            # running "under" or "within" the `pikerd` actor tree after
+            # the questing client disconnects. in other words this
+            # spawns a persistent daemon actor that continues to live
+            # for the lifespan of whatever the service manager inside
+            # `pikerd` says it should.
+            started = await pikerd_portal.run(
+                service_task_target,
+                loglevel=loglevel,
+                **spawn_args,
+            )
+
+        if started:
+            log.info(f'Service {service_name} started!')
+
+        # block until we can discover (by IPC connection) to the newly
+        # spawned daemon-actor and then deliver the portal to the
+        # caller.
+        async with tractor.wait_for_actor(service_name) as portal:
+            lock.release()
+            yield portal
+            await portal.cancel_actor()
 
 
 async def spawn_emsd(

piker/service/_mngr.py

@@ -109,7 +109,7 @@ class Services:
                         # wait on any context's return value
                         # and any final portal result from the
                         # sub-actor.
-                        ctx_res: Any = await ctx.wait_for_result()
+                        ctx_res: Any = await ctx.result()
 
                         # NOTE: blocks indefinitely until cancelled
                         # either by error from the target context

piker/service/_registry.py

@@ -101,15 +101,13 @@ async def open_registry(
 
     if (
         not tractor.is_root_process()
-        and
+        and not Registry.addrs
-        not Registry.addrs
     ):
         Registry.addrs.extend(actor.reg_addrs)
 
     if (
         ensure_exists
-        and
+        and not Registry.addrs
-        not Registry.addrs
     ):
         raise RuntimeError(
             f"`{uid}` registry should already exist but doesn't?"
@@ -148,7 +146,7 @@ async def find_service(
     | list[Portal]
     | None
 ):
-    # try:
+
     reg_addrs: list[tuple[str, int]]
     async with open_registry(
         addrs=(
@@ -159,39 +157,22 @@ async def find_service(
             or Registry.addrs
         ),
     ) as reg_addrs:
+        log.info(f'Scanning for service `{service_name}`')
 
-        log.info(
+        maybe_portals: list[Portal] | Portal | None
-            f'Scanning for service {service_name!r}'
-        )
 
         # attach to existing daemon by name if possible
-        maybe_portals: list[Portal]|Portal|None
         async with tractor.find_actor(
             service_name,
             registry_addrs=reg_addrs,
             only_first=first_only,  # if set only returns single ref
         ) as maybe_portals:
             if not maybe_portals:
-                # log.info(
-                print(
-                    f'Could NOT find service {service_name!r} -> {maybe_portals!r}'
-                )
                 yield None
                 return
 
-            # log.info(
-            print(
-                f'Found service {service_name!r} -> {maybe_portals}'
-            )
             yield maybe_portals
 
-    # except BaseException as _berr:
-    #     berr = _berr
-    #     log.exception(
-    #         'tractor.find_actor() failed with,\n'
-    #     )
-    #     raise berr
-
 
 async def check_for_service(
     service_name: str,

piker/tsp/__init__.py

@@ -963,10 +963,7 @@ async def tsdb_backfill(
         # concurrently load the provider's most-recent-frame AND any
         # pre-existing tsdb history already saved in `piker` storage.
         dt_eps: list[DateTime, DateTime] = []
-        async with (
+        async with trio.open_nursery() as tn:
-            tractor.trionics.collapse_eg(),
-            trio.open_nursery() as tn
-        ):
             tn.start_soon(
                 push_latest_frame,
                 dt_eps,
@@ -1015,16 +1012,9 @@ async def tsdb_backfill(
                 int,
                 Duration,
             ]|None = config.get('frame_types', None)
-
             if def_frame_durs:
                 def_frame_size: Duration = def_frame_durs[timeframe]
-
+                assert def_frame_size == calced_frame_size
-                if def_frame_size != calced_frame_size:
-                    log.warning(
-                        f'Expected frame size {def_frame_size}\n'
-                        f'Rxed frame {calced_frame_size}\n'
-                    )
-                    # await tractor.pause()
             else:
                 # use what we calced from first frame above.
                 def_frame_size = calced_frame_size
@@ -1053,9 +1043,7 @@ async def tsdb_backfill(
             # if there is a gap to backfill from the first
             # history frame until the last datum loaded from the tsdb
             # continue that now in the background
-            async with trio.open_nursery(
+            async with trio.open_nursery() as tn:
-                strict_exception_groups=False,
-            ) as tn:
 
                 bf_done = await tn.start(
                     partial(
@@ -1320,7 +1308,6 @@ async def manage_history(
         # sampling period) data set since normally differently
         # sampled timeseries can be loaded / process independently
         # ;)
-        tractor.trionics.collapse_eg(),
         trio.open_nursery() as tn,
     ):
         log.info(

piker/tsp/_anal.py

@@ -517,7 +517,7 @@ def with_dts(
 
     '''
     return df.with_columns([
-        pl.col(time_col).shift(1).name.suffix('_prev'),
+        pl.col(time_col).shift(1).suffix('_prev'),
         pl.col(time_col).diff().alias('s_diff'),
         pl.from_epoch(pl.col(time_col)).alias('dt'),
     ]).with_columns([
@@ -623,7 +623,7 @@ def detect_vlm_gaps(
 
 ) -> pl.DataFrame:
 
-    vnull: pl.DataFrame = df.filter(
+    vnull: pl.DataFrame = w_dts.filter(
         pl.col(col) == 0
     )
     return vnull

piker/ui/_app.py

@@ -21,7 +21,6 @@ Main app startup and run.
 from functools import partial
 from types import ModuleType
 
-import tractor
 import trio
 
 from piker.ui.qt import (
@@ -117,7 +116,6 @@ async def _async_main(
         needed_brokermods[brokername] = brokers[brokername]
 
     async with (
-        tractor.trionics.collapse_eg(),
         trio.open_nursery() as root_n,
     ):
         # set root nursery and task stack for spawning other charts/feeds

piker/ui/_chart.py

@@ -33,6 +33,7 @@ import trio
 
 from piker.ui.qt import (
     QtCore,
+    QtWidgets,
     Qt,
     QLineF,
     QFrame,

piker/ui/_display.py

@@ -1445,10 +1445,7 @@ async def display_symbol_data(
         # for pause/resume on mouse interaction
         rt_chart.feed = feed
 
-        async with (
+        async with trio.open_nursery() as ln:
-            tractor.trionics.collapse_eg(),
-            trio.open_nursery() as ln,
-        ):
             # if available load volume related built-in display(s)
             vlm_charts: dict[
                 str,

piker/ui/_event.py

@@ -22,10 +22,7 @@ from contextlib import asynccontextmanager as acm
 from typing import Callable
 
 import trio
-from tractor.trionics import (
+from tractor.trionics import gather_contexts
-    gather_contexts,
-    collapse_eg,
-)
 
 from piker.ui.qt import (
     QtCore,
@@ -210,10 +207,7 @@ async def open_signal_handler(
         async for args in recv:
             await async_handler(*args)
 
-    async with (
+    async with trio.open_nursery() as tn:
-        collapse_eg(),
-        trio.open_nursery() as tn
-    ):
         tn.start_soon(proxy_to_handler)
         async with send:
             yield
@@ -248,7 +242,6 @@ async def open_handlers(
     widget: QWidget
     streams: list[trio.abc.ReceiveChannel]
     async with (
-        collapse_eg(),
         trio.open_nursery() as tn,
         gather_contexts([
             open_event_stream(

piker/ui/_feedstatus.py

@@ -18,11 +18,10 @@
 Feed status and controls widget(s) for embedding in a UI-pane.
 
 """
+
 from __future__ import annotations
-from typing import (
+from textwrap import dedent
-    Any,
+from typing import TYPE_CHECKING
-    TYPE_CHECKING,
-)
 
 # from PyQt5.QtCore import Qt
 
@@ -50,55 +49,35 @@ def mk_feed_label(
     a feed control protocol.
 
     '''
-    status: dict[str, Any] = feed.status
+    status = feed.status
     assert status
 
-    # SO tips on ws/nls,
+    msg = dedent("""
-    # https://stackoverflow.com/a/15721400
+        actor: **{actor_name}**\n
-    ws: str = ' '
+        |_ @**{host}:{port}**\n
-    # nl: str = '<br>'  # dun work?
+    """)
-    actor_info_repr: str = (
-        f')> **{status["actor_short_id"]}**\n'
-        '\n'  # bc md?
-    )
 
-    # fields to select *IN* for display
+    for key, val in status.items():
-    # (see `.data.feed.open_feed()` status
+        if key in ('host', 'port', 'actor_name'):
-    #  update -> TAG_feed_status_update)
+            continue
-    for key in [
+        msg += f'\n|_ {key}: **{{{key}}}**\n'
-        'ipc',
-        'hist_shm',
-        'rt_shm',
-        'throttle_hz',
-    ]:
-        # NOTE, the 2nd key is filled via `.format()` updates.
-        actor_info_repr += (
-            f'\n'  # bc md?
-            f'{ws}|_{key}: **{{{key}}}**\n'
-        )
-        # ^TODO? formatting and content..
-        # -[ ] showing which fqme is "forward" on the
-        #    chart/fsp/order-mode?
-        #  '|_ flows: **{symbols}**\n'
-        #
-        # -[x] why isn't the indent working?
-        #  => markdown, now solved..
 
     feed_label = FormatLabel(
-        fmt_str=actor_info_repr,
+        fmt_str=msg,
+        # |_ streams: **{symbols}**\n
         font=_font.font,
         font_size=_font_small.px_size,
         font_color='default_lightest',
     )
 
-    # ?TODO, remove this?
     # form.vbox.setAlignment(feed_label, Qt.AlignBottom)
     # form.vbox.setAlignment(Qt.AlignBottom)
-    # _ = chart.height() - (
+    _ = chart.height() - (
-    #     form.height() +
+        form.height() +
-    #     form.fill_bar.height()
+        form.fill_bar.height()
-    #     # feed_label.height()
+        # feed_label.height()
-    # )
+    )
 
     feed_label.format(**feed.status)
+
     return feed_label

piker/ui/_fsp.py

@@ -600,7 +600,6 @@ async def open_fsp_admin(
             kwargs=kwargs,
         ) as (cache_hit, cluster_map),
 
-        tractor.trionics.collapse_eg(),
         trio.open_nursery() as tn,
     ):
         if cache_hit:
@@ -614,8 +613,6 @@ async def open_fsp_admin(
         )
         try:
             yield admin
-
-        # ??TODO, does this *need* to be inside a finally?
         finally:
             # terminate all tasks via signals
             for key, entry in admin._registry.items():

piker/ui/_label.py

@@ -285,20 +285,18 @@ class FormatLabel(QLabel):
         font_size: int,
         font_color: str,
 
-        use_md: bool = True,
-
         parent=None,
 
     ) -> None:
 
         super().__init__(parent)
 
-        # by default set the format string verbatim and expect user
+        # by default set the format string verbatim and expect user to
-        # to call ``.format()`` later (presumably they'll notice the
+        # call ``.format()`` later (presumably they'll notice the
         # unformatted content if ``fmt_str`` isn't meant to be
         # unformatted).
         self.fmt_str = fmt_str
-        # self.setText(fmt_str)  # ?TODO, why here?
+        self.setText(fmt_str)
 
         self.setStyleSheet(
             f"""QLabel {{
@@ -308,10 +306,9 @@ class FormatLabel(QLabel):
             """
         )
         self.setFont(_font.font)
-        if use_md:
+        self.setTextFormat(
-            self.setTextFormat(
+            Qt.TextFormat.MarkdownText
-                Qt.TextFormat.MarkdownText
+        )
-            )
         self.setMargin(0)
 
         self.setSizePolicy(
@@ -319,10 +316,7 @@ class FormatLabel(QLabel):
             size_policy.Expanding,
         )
         self.setAlignment(
-            Qt.AlignLeft
+            Qt.AlignVCenter | Qt.AlignLeft
-            |
-            Qt.AlignBottom
-            # Qt.AlignVCenter
         )
         self.setText(self.fmt_str)
 

piker/ui/_search.py

@@ -15,8 +15,7 @@
 # along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 """
-qompleterz: embeddable search and complete using trio, Qt and
+qompleterz: embeddable search and complete using trio, Qt and rapidfuzz.
-rapidfuzz.
 
 """
 
@@ -47,7 +46,6 @@ import time
 from pprint import pformat
 
 from rapidfuzz import process as fuzzy
-import tractor
 import trio
 from trio_typing import TaskStatus
 
@@ -55,7 +53,7 @@ from piker.ui.qt import (
     size_policy,
     align_flag,
     Qt,
-    # QtCore,
+    QtCore,
     QtWidgets,
     QModelIndex,
     QItemSelectionModel,
@@ -922,10 +920,7 @@ async def fill_results(
 
             # issue multi-provider fan-out search request and place
             # "searching.." statuses on outstanding results providers
-            async with (
+            async with trio.open_nursery() as n:
-                tractor.trionics.collapse_eg(),
-                trio.open_nursery() as tn
-            ):
 
                 for provider, (search, pause) in (
                     _searcher_cache.copy().items()
@@ -949,7 +944,7 @@ async def fill_results(
                                 status_field='-> searchin..',
                             )
 
-                        await tn.start(
+                        await n.start(
                             pack_matches,
                             view,
                             has_results,
@@ -1009,14 +1004,12 @@ async def handle_keyboard_input(
     view.set_font_size(searchbar.dpi_font.px_size)
     send, recv = trio.open_memory_channel(616)
 
-    async with (
+    async with trio.open_nursery() as n:
-        tractor.trionics.collapse_eg(),  # needed?
+
-        trio.open_nursery() as tn
-    ):
         # start a background multi-searcher task which receives
         # patterns relayed from this keyboard input handler and
         # async updates the completer view's results.
-        tn.start_soon(
+        n.start_soon(
             partial(
                 fill_results,
                 searchw,

piker/ui/_style.py

@@ -269,8 +269,6 @@ def hcolor(name: str) -> str:
 
         # default ohlc-bars/curve gray
         'bracket': '#666666',  # like the logo
-        'pikers': '#616161',  # a trader shade of..
-        'beast': '#161616',  # in the dark alone.
 
         # bluish
         'charcoal': '#36454F',

piker/ui/order_mode.py

@@ -21,7 +21,6 @@ Chart trading, the only way to scalp.
 from __future__ import annotations
 from contextlib import asynccontextmanager
 from dataclasses import dataclass, field
-from decimal import Decimal
 from functools import partial
 from pprint import pformat
 import time
@@ -42,6 +41,7 @@ from piker.accounting import (
     Position,
     mk_allocator,
     MktPair,
+    Symbol,
 )
 from piker.clearing import (
     open_ems,
@@ -143,15 +143,6 @@ class OrderMode:
     }
     _staged_order: Order | None = None
 
-    @property
-    def curr_mkt(self) -> MktPair:
-        '''
-        Deliver the currently selected `MktPair` according
-        chart state.
-
-        '''
-        return self.chart.linked.mkt
-
     def on_level_change_update_next_order_info(
         self,
         level: float,
@@ -181,11 +172,7 @@ class OrderMode:
         line.update_labels(order_info)
 
         # update bound-in staged order
-        mkt: MktPair = self.curr_mkt
+        order.price = level
-        order.price: Decimal = mkt.quantize(
-            size=level,
-            quantity_type='price',
-        )
         order.size = order_info['size']
 
         # when an order is changed we flip the settings side-pane to
@@ -200,9 +187,7 @@ class OrderMode:
 
     ) -> LevelLine:
 
-        # TODO, if we instead just always decimalize at the ems layer
+        level = order.price
-        # we can avoid this back-n-forth casting?
-        level = float(order.price)
 
         line = order_line(
             chart or self.chart,
@@ -239,11 +224,7 @@ class OrderMode:
             # the order mode allocator but we still need to update the
             # "staged" order message we'll send to the ems
             def update_order_price(y: float) -> None:
-                mkt: MktPair = self.curr_mkt
+                order.price = y
-                order.price: Decimal = mkt.quantize(
-                    size=y,
-                    quantity_type='price',
-                )
 
             line._on_level_change = update_order_price
 
@@ -294,31 +275,34 @@ class OrderMode:
         chart = cursor.linked.chart
         if (
             not chart
-            and
+            and cursor
-            cursor
+            and cursor.active_plot
-            and
-            cursor.active_plot
         ):
             return
 
         chart = cursor.active_plot
-        price: float = cursor._datum_xy[1]
+        price = cursor._datum_xy[1]
         if not price:
             # zero prices are not supported by any means
             # since that's illogical / a no-op.
             return
 
+        mkt: MktPair = self.chart.linked.mkt
+
+        # NOTE : we could also use instead,
+        # mkt.quantize(price, quantity_type='price')
+        # but it returns a Decimal and it's probably gonna
+        # be slower?
         # TODO: should we be enforcing this precision
-        # at a different layer in the stack?
+        # at a different layer in the stack? right now
-        # |_ might require `MktPair` tracking in the EMS?
+        # any precision error will literally be relayed
-        # |_ right now any precision error will be relayed
+        # all the way back from the backend.
-        #    all the way back from the backend and vice-versa..
+
-        #
+        price = round(
-        mkt: MktPair = self.curr_mkt
+            price,
-        price: Decimal = mkt.quantize(
+            ndigits=mkt.price_tick_digits,
-            size=price,
-            quantity_type='price',
         )
+
         order = self._staged_order = Order(
             action=action,
             price=price,
@@ -394,7 +378,7 @@ class OrderMode:
                 'oid': oid,
             })
 
-        if float(order.price) <= 0:
+        if order.price <= 0:
             log.error(
                 '*!? Invalid `Order.price <= 0` ?!*\n'
                 # TODO: make this present multi-line in object form
@@ -531,15 +515,14 @@ class OrderMode:
             # if an order msg is provided update the line
             # **from** that msg.
             if order:
-                price: float = float(order.price)
+                if order.price <= 0:
-                if price <= 0:
                     log.error(f'Order has 0 price, cancelling..\n{order}')
                     self.cancel_orders([order.oid])
                     return None
 
-                line.set_level(price)
+                line.set_level(order.price)
                 self.on_level_change_update_next_order_info(
-                    level=price,
+                    level=order.price,
                     line=line,
                     order=order,
                     # use the corresponding position tracker for the
@@ -698,9 +681,9 @@ class OrderMode:
     ) -> Dialog | None:
         # NOTE: the `.order` attr **must** be set with the
         # equivalent order msg in order to be loaded.
-        order: Order = msg.req
+        order = msg.req
         oid = str(msg.oid)
-        symbol: str = order.symbol
+        symbol = order.symbol
 
         # TODO: MEGA UGGG ZONEEEE!
         src = msg.src
@@ -719,22 +702,13 @@ class OrderMode:
         order.oid = str(order.oid)
         order.brokers = [brokername]
 
-        # ?TODO? change this over to `MktPair`, but it's gonna be
+        # TODO: change this over to `MktPair`, but it's
-        # tough since we don't have any such data really in our
+        # gonna be tough since we don't have any such data
-        # clearing msg schema..
+        # really in our clearing msg schema..
-        # BUT WAIT! WHY do we even want/need this!?
+        order.symbol = Symbol.from_fqme(
-        #
+            fqsn=fqme,
-        # order.symbol = self.curr_mkt
+            info={},
-        #
+        )
-        # XXX, the old approach.. which i don't quire member why..
-        # -[ ] verify we for sure don't require this any more!
-        #  |_https://github.com/pikers/piker/issues/517
-        #
-        # order.symbol = Symbol.from_fqme(
-        #     fqsn=fqme,
-        #     info={},
-        # )
-
         maybe_dialog: Dialog | None = self.submit_order(
             send_msg=False,
             order=order,
@@ -792,7 +766,6 @@ async def open_order_mode(
             brokerd_accounts,
             ems_dialog_msgs,
         ),
-        tractor.trionics.collapse_eg(),
         trio.open_nursery() as tn,
 
     ):
@@ -1128,7 +1101,7 @@ async def process_trade_msg(
                         )
                     )
                 ):
-                    msg.req: Order = order
+                    msg.req = order
                     dialog: (
                         Dialog
                         # NOTE: on an invalid order submission (eg.
@@ -1193,7 +1166,7 @@ async def process_trade_msg(
             tm = time.time()
             mode.on_fill(
                 oid,
-                price=float(req.price),
+                price=req.price,
                 time_s=tm,
             )
             mode.lines.remove_line(uuid=oid)
@@ -1248,7 +1221,7 @@ async def process_trade_msg(
             tm = details['broker_time']
             mode.on_fill(
                 oid,
-                price=float(details['price']),
+                price=details['price'],
                 time_s=tm,
                 pointing='up' if action == 'buy' else 'down',
             )

snippets/qt_screen_info.py

@@ -1,22 +1,4 @@
-# piker: trading gear for hackers
+"""
-# Copyright (C) Tyler Goodlet (in stewardship for pikers)
-
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Affero General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU Affero General Public License for more details.
-
-# You should have received a copy of the GNU Affero General Public License
-# along with this program.  If not, see <https://www.gnu.org/licenses/>.
-
-'''
-A per-display, DPI (scaling) info dumper.
-
 Resource list for mucking with DPIs on multiple screens:
 
 - https://stackoverflow.com/questions/42141354/convert-pixel-size-to-point-size-for-fonts-on-multiple-platforms
@@ -30,86 +12,89 @@ Resource list for mucking with DPIs on multiple screens:
 - https://stackoverflow.com/questions/16561879/what-is-the-difference-between-logicaldpix-and-physicaldpix-in-qt
 - https://doc.qt.io/qt-5/qguiapplication.html#screenAt
 
-'''
+"""
 
 from pyqtgraph import QtGui
-from PyQt6 import (
+from PyQt5.QtCore import (
-    QtCore,
+     Qt, QCoreApplication
-    QtWidgets,
-)
-from PyQt6.QtCore import (
-    Qt,
-    QCoreApplication,
-    QSize,
-    QRect,
 )
 
 # Proper high DPI scaling is available in Qt >= 5.6.0. This attibute
 # must be set before creating the application
 if hasattr(Qt, 'AA_EnableHighDpiScaling'):
-    QCoreApplication.setAttribute(
+    QCoreApplication.setAttribute(Qt.AA_EnableHighDpiScaling, True)
-        Qt.AA_EnableHighDpiScaling,
-        True,
-    )
 
 if hasattr(Qt, 'AA_UseHighDpiPixmaps'):
-    QCoreApplication.setAttribute(
+    QCoreApplication.setAttribute(Qt.AA_UseHighDpiPixmaps, True)
-        Qt.AA_UseHighDpiPixmaps,
-        True,
-    )
 
-app = QtWidgets.QApplication([])
+
-window = QtWidgets.QMainWindow()
+app = QtGui.QApplication([])
-main_widget = QtWidgets.QWidget()
+window = QtGui.QMainWindow()
+main_widget = QtGui.QWidget()
 window.setCentralWidget(main_widget)
 window.show()
 
-pxr: float = main_widget.devicePixelRatioF()
+pxr = main_widget.devicePixelRatioF()
 
-# explicitly get main widget and primary displays
+# screen_num = app.desktop().screenNumber()
-current_screen: QtGui.QScreen = app.screenAt(
+# screen = app.screens()[screen_num]
-    main_widget.geometry().center()
+
+screen = app.screenAt(main_widget.geometry().center())
+
+name = screen.name()
+size = screen.size()
+geo = screen.availableGeometry()
+phydpi = screen.physicalDotsPerInch()
+logdpi = screen.logicalDotsPerInch()
+
+print(
+    # f'screen number: {screen_num}\n',
+    f'screen name: {name}\n'
+    f'screen size: {size}\n'
+    f'screen geometry: {geo}\n\n'
+    f'devicePixelRationF(): {pxr}\n'
+    f'physical dpi: {phydpi}\n'
+    f'logical dpi: {logdpi}\n'
 )
-primary_screen: QtGui.QScreen = app.primaryScreen()
 
-screen: QtGui.QScreen
+print('-'*50)
-for screen in app.screens():
-    name: str = screen.name()
-    model: str = screen.model().rstrip()
-    size: QSize = screen.size()
-    geo: QRect = screen.availableGeometry()
-    phydpi: float = screen.physicalDotsPerInch()
-    logdpi: float = screen.logicalDotsPerInch()
-    is_primary: bool = screen is primary_screen
-    is_current: bool = screen is current_screen
 
-    print(
+screen = app.primaryScreen()
-        f'------ screen name: {name} ------\n'
-        f'|_primary: {is_primary}\n'
-        f' _current: {is_current}\n'
-        f' _model: {model}\n'
-        f' _screen size: {size}\n'
-        f' _screen geometry: {geo}\n'
-        f' _devicePixelRationF(): {pxr}\n'
-        f' _physical dpi: {phydpi}\n'
-        f' _logical dpi: {logdpi}\n'
-    )
 
-# app-wide font info
+name = screen.name()
+size = screen.size()
+geo = screen.availableGeometry()
+phydpi = screen.physicalDotsPerInch()
+logdpi = screen.logicalDotsPerInch()
+
+print(
+    # f'screen number: {screen_num}\n',
+    f'screen name: {name}\n'
+    f'screen size: {size}\n'
+    f'screen geometry: {geo}\n\n'
+    f'devicePixelRationF(): {pxr}\n'
+    f'physical dpi: {phydpi}\n'
+    f'logical dpi: {logdpi}\n'
+)
+
+
+# app-wide font
 font = QtGui.QFont("Hack")
 # use pixel size to be cross-resolution compatible?
 font.setPixelSize(6)
 
-fm = QtGui.QFontMetrics(font)
-fontdpi: float = fm.fontDpi()
-font_h: int = fm.height()
 
-string: str = '10000'
+fm = QtGui.QFontMetrics(font)
-str_br: QtCore.QRect = fm.boundingRect(string)
+fontdpi = fm.fontDpi()
-str_w: int = str_br.width()
+font_h = fm.height()
+
+string = '10000'
+str_br = fm.boundingRect(string)
+str_w = str_br.width()
+
 
 print(
-    f'------ global font settings ------\n'
+    # f'screen number: {screen_num}\n',
     f'font dpi: {fontdpi}\n'
     f'font height: {font_h}\n'
     f'string bounding rect: {str_br}\n'

tags

@@ -1 +0,0 @@
-TAG_feed_status_update	./piker/data/feed.py	/TAG_feed_status_update/

tests/conftest.py

@@ -15,12 +15,6 @@ from piker.service import (
 from piker.log import get_console_log
 
 
-# include `tractor`'s built-in fixtures!
-pytest_plugins: tuple[str] = (
-    "tractor._testing.pytest",
-)
-
-
 def pytest_addoption(parser):
     parser.addoption("--ll", action="store", dest='loglevel',
                      default=None, help="logging level to set when testing")

tests/test_ems.py

@@ -179,7 +179,7 @@ def test_ems_err_on_bad_broker(
         # NOTE: emsd should error on the actor's enabled modules
         # import phase, when looking for a backend named `doggy`.
         except tractor.RemoteActorError as re:
-            assert re.type is ModuleNotFoundError
+            assert re.type == ModuleNotFoundError
 
     run_and_tollerate_cancels(load_bad_fqme)
 

tests/test_questrade.py

@@ -142,12 +142,7 @@ async def test_concurrent_tokens_refresh(us_symbols, loglevel):
         # async with tractor.open_nursery() as n:
         #     await n.run_in_actor('other', intermittently_refresh_tokens)
 
-        async with (
+        async with trio.open_nursery() as n:
-            tractor.trionics.collapse_eg(),
-            trio.open_nursery(
-            # strict_exception_groups=False,
-            ) as n
-        ):
 
             quoter = await qt.stock_quoter(client, us_symbols)
 
@@ -388,9 +383,7 @@ async def test_quote_streaming(tmx_symbols, loglevel, stream_what):
             else:
                 symbols = [tmx_symbols]
 
-            async with trio.open_nursery(
+            async with trio.open_nursery() as n:
-                strict_exception_groups=False,
-            ) as n:
                 for syms, func in zip(symbols, stream_what):
                     n.start_soon(func, feed, syms)