From e2e5191ded68e3cff1663405eecbebffdf5f626a Mon Sep 17 00:00:00 2001
From: jaredgoldman <jaredgoldmandev@gmail.com>
Date: Fri, 24 Mar 2023 19:56:38 -0400
Subject: [PATCH] Remove breaking useless condition for determining if res is
 list of ohlc values

---
 piker/brokers/kucoin.py | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/piker/brokers/kucoin.py b/piker/brokers/kucoin.py
index 50222fa5..a8eae81b 100644
--- a/piker/brokers/kucoin.py
+++ b/piker/brokers/kucoin.py
@@ -164,7 +164,7 @@ class Client:
         config: BrokerConfig | None = get_config()
 
         if (
-            config and config.key_id and config.key_secret and config.key_passphrase
+            config and float(config.key_id) and config.key_secret and config.key_passphrase
         ):
             self._authenticated = True
             self._key_id = config.key_id
@@ -343,17 +343,19 @@ class Client:
 
         for i in range(10):
 
-            res = await self._request(
+            data = await self._request(
                 "GET",
                 url,
                 api_v="v1",
             )
 
-            if not isinstance(res, list) or not len(bars):
+            if not isinstance(data, list):
                 # Do a gradual backoff if Kucoin is rate limiting us
-                await trio.sleep(i + (randint(0, 1000) / 1000))
+                backoff_interval = i + (randint(0, 1000) / 1000)
+                log.warn(f'History call failed, backing off for {backoff_interval}s')
+                await trio.sleep(backoff_interval)
             else:
-                bars = res
+                bars = data
                 break
 
         # Map to OHLC values to dict then to np array
@@ -392,6 +394,8 @@ class Client:
 def fqsn_to_kucoin_sym(
     fqsn: str,
     pairs: dict[str, KucoinMktPair]
+
+
 ) -> str:
     pair_data = pairs[fqsn]
     return pair_data.baseCurrency + "-" + pair_data.quoteCurrency
@@ -401,7 +405,7 @@ def kucoin_sym_to_fqsn(sym: str) -> str:
     return sym.lower().replace("-", "")
 
 
-@acm
+@ acm
 async def get_client() -> AsyncGenerator[Client, None]:
 
     client = Client()
@@ -410,7 +414,7 @@ async def get_client() -> AsyncGenerator[Client, None]:
     yield client
 
 
-@tractor.context
+@ tractor.context
 async def open_symbol_search(
     ctx: tractor.Context,
 ) -> None:
@@ -581,6 +585,7 @@ async def open_history_client(
     type: str = "1m",
 ) -> AsyncGenerator[Callable, None]:
     async with open_cached_client("kucoin") as client:
+        log.info("Attempting to open kucoin history client")
 
         async def get_ohlc_history(