From accb0eee6c759c1b2d8f15d498a78db766b1072e Mon Sep 17 00:00:00 2001
From: Guillermo Rodriguez <guillermo@telos.net>
Date: Wed, 24 Aug 2022 19:32:54 -0300
Subject: [PATCH] Add brokercheck guard on deribit.get_client && drop method
 running in brokercheck

---
 piker/brokers/cli.py         | 49 +++++++++++++++++-------------------
 piker/brokers/deribit/api.py |  9 ++++++-
 2 files changed, 31 insertions(+), 27 deletions(-)

diff --git a/piker/brokers/cli.py b/piker/brokers/cli.py
index 7b3a98ed..4079a236 100644
--- a/piker/brokers/cli.py
+++ b/piker/brokers/cli.py
@@ -58,36 +58,36 @@ def brokercheck(config, broker):
     def print_error(s: str, **kwargs):
         print(FAIL + s + ENDC, **kwargs)
 
-    async def run_method(client, meth_name: str, **kwargs):
+    def get_method(client, meth_name: str):
         print(f'checking client for method \'{meth_name}\'...', end='', flush=True)
         method = getattr(client, meth_name, None)
         assert method
-        print_ok('found!, running...', end='', flush=True)
-        result = await method(**kwargs)
-        print_ok(f'done! result: {type(result)}')
-        return result
+        print_ok('found!.')
+        return method
 
     async def run_test(broker_name: str):
         brokermod = get_brokermod(broker_name)
         total = 0
         passed = 0
         failed = 0
-        
+
         print(f'getting client...', end='', flush=True)
         if not hasattr(brokermod, 'get_client'):
             print_error('fail! no \'get_client\' context manager found.')
             return
 
-        async with brokermod.get_client() as client:
+        async with brokermod.get_client(is_brokercheck=True) as client:
             print_ok(f'done! inside client context.')
 
             # check for methods present on brokermod
             method_list = [
-                'stream_messages',
-                'open_history_client',
                 'backfill_bars',
+                'get_client',
+                'trades_dialogue',
+                'open_history_client',
+                'open_symbol_search',
                 'stream_quotes',
-                'open_symbol_search'
+
             ]
 
             for method in method_list:
@@ -106,25 +106,22 @@ def brokercheck(config, broker):
             # check for methods present con brokermod.Client and their
             # results
 
-            syms = await run_method(client, 'symbol_info')
-            total += 1
-            
-            if len(syms) == 0:
-                raise BaseException('Empty Symbol list?')
-
-            passed += 1
-
-            first_sym = tuple(syms.keys())[0]
-
+            # for private methods only check is present
             method_list = [
-                ('cache_symbols', {}),
-                ('search_symbols', {'pattern': first_sym[:-1]}),
-                ('bars', {'symbol': first_sym})
+                'get_balances',
+                'get_assets',
+                'get_trades',
+                'get_xfers',
+                'submit_limit',
+                'submit_cancel',
+                'cache_symbols',
+                'search_symbols',
+                'bars'
             ]
-            
-            for method_name, method_kwargs in method_list:
+
+            for method_name in method_list:
                 try:
-                    await run_method(client, method_name, **method_kwargs)
+                    get_method(client, method_name)
                     passed += 1
 
                 except AssertionError:
diff --git a/piker/brokers/deribit/api.py b/piker/brokers/deribit/api.py
index 96adac9e..15f90e29 100644
--- a/piker/brokers/deribit/api.py
+++ b/piker/brokers/deribit/api.py
@@ -410,7 +410,14 @@ class Client:
 
 
 @acm
-async def get_client() -> Client:
+async def get_client(
+    is_brokercheck: bool = False
+) -> Client:
+
+    if is_brokercheck:
+        yield Client
+        return
+
     async with (
         trio.open_nursery() as n,
         open_autorecon_ws(_testnet_ws_url) as ws