From a2934b7d183dd324dfa5526155776d7904c5a72b Mon Sep 17 00:00:00 2001 From: Tyler Goodlet Date: Thu, 9 Feb 2023 14:57:00 -0500 Subject: [PATCH] Go back to caching on all curves Despite there being artifacts when interacting, the speedups when cross-hair-ing are just too good to ignore. We can always play with disabling caches when interaction takes place much like we do with feed pausing. --- piker/ui/_curve.py | 4 ++-- piker/ui/_ohlc.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/piker/ui/_curve.py b/piker/ui/_curve.py index 1e3c4e75..42064173 100644 --- a/piker/ui/_curve.py +++ b/piker/ui/_curve.py @@ -410,7 +410,7 @@ class FlattenedOHLC(Curve): # avoids strange dragging/smearing artifacts when panning # as well as mouse over artefacts when the vlm chart series # is "shorter" then some overlay.. - cache_mode: int = QGraphicsItem.NoCache + # cache_mode: int = QGraphicsItem.NoCache def draw_last_datum( self, @@ -440,7 +440,7 @@ class StepCurve(Curve): # avoids strange dragging/smearing artifacts when panning # as well as mouse over artefacts when the vlm chart series # is "shorter" then some overlay.. - cache_mode: int = QGraphicsItem.NoCache + # cache_mode: int = QGraphicsItem.NoCache def declare_paintables( self, diff --git a/piker/ui/_ohlc.py b/piker/ui/_ohlc.py index 104b860c..344805e8 100644 --- a/piker/ui/_ohlc.py +++ b/piker/ui/_ohlc.py @@ -93,7 +93,7 @@ class BarItems(FlowGraphic): ''' # XXX: causes this weird jitter bug when click-drag panning # where the path curve will awkwardly flicker back and forth? - cache_mode: int = QGraphicsItem.NoCache + # cache_mode: int = QGraphicsItem.NoCache def __init__( self,