pikers
/
piker
3
0
Fork 0
Code Issues 5 Pull Requests 7 Packages Projects Releases Wiki Activity

Merge pull request #460 from pikers/fnf_notify-send 

Fix crash on notification daemon not found
backend_spec
Guillermo Rodriguez 2023-02-13 18:22:27 -03:00 committed by GitHub
parent 42d2f9e461 ffd707db62
commit 71b2f24a2e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
piker/ui/_notify.py
View File

@ -83,22 +83,26 @@ async def notify_from_ems_status_msg(
f'unix:path=/run/user/{_dbus_uid}/bus' f'unix:path=/run/user/{_dbus_uid}/bus'
) )
result = await trio.run_process( try:
[ result = await trio.run_process(
'notify-send', [
'-u', 'normal', 'notify-send',
'-t', f'{duration}', '-u', 'normal',
'piker', '-t', f'{duration}',
'piker',
# TODO: add in standard fill/exec info that maybe we # TODO: add in standard fill/exec info that maybe we
# pack in a broker independent way? # pack in a broker independent way?
f"'{msg.pformat()}'", f"'{msg.pformat()}'",
], ],
capture_stdout=True, capture_stdout=True,
capture_stderr=True, capture_stderr=True,
check=False, check=False,
) )
if result.returncode != 0: if result.returncode != 0:
log.warn(f'No notification daemon installed stderr: {result.stderr}') log.warn(f'Notification daemon crashed stderr: {result.stderr}')
log.runtime(result) log.runtime(result)
except FileNotFoundError:
log.warn('Tried to send a notification but \'notify-send\' not present')