Cleanups and doc tweaks to `.ui._fsp`
Expand read-race warning log for clarity, add TODO for reading `tractor` transport config from `conf.toml`, and reflow docstring in `open_vlm_displays()`. Also, - whitespace cleanup: `Type | None` -> `Type|None` - clarify "Volume" -> "Vlm (volume)" in docstr (this commit msg was generated in some part by [`claude-code`][claude-code-gh]) [claude-code-gh]: https://github.com/anthropics/claude-codehist_backfill_fixes
parent
2d678e1582
commit
6f8a361e80
|
|
@ -87,7 +87,11 @@ def update_fsp_chart(
|
||||||
|
|
||||||
# guard against unreadable case
|
# guard against unreadable case
|
||||||
if not last_row:
|
if not last_row:
|
||||||
log.warning(f'Read-race on shm array: {graphics_name}@{shm.token}')
|
log.warning(
|
||||||
|
f'Read-race on shm array,\n'
|
||||||
|
f'graphics_name: {graphics_name!r}\n'
|
||||||
|
f'shm.token: {shm.token}\n'
|
||||||
|
)
|
||||||
return
|
return
|
||||||
|
|
||||||
# update graphics
|
# update graphics
|
||||||
|
|
@ -203,7 +207,6 @@ async def open_fsp_actor_cluster(
|
||||||
|
|
||||||
|
|
||||||
async def run_fsp_ui(
|
async def run_fsp_ui(
|
||||||
|
|
||||||
linkedsplits: LinkedSplits,
|
linkedsplits: LinkedSplits,
|
||||||
flume: Flume,
|
flume: Flume,
|
||||||
started: trio.Event,
|
started: trio.Event,
|
||||||
|
|
@ -623,8 +626,10 @@ async def open_fsp_admin(
|
||||||
event.set()
|
event.set()
|
||||||
|
|
||||||
|
|
||||||
|
# TODO, passing in `pikerd` related settings here!
|
||||||
|
# [ ] read in the `tractor` setting for `enable_transports: list`
|
||||||
|
# from the root `conf.toml`!
|
||||||
async def open_vlm_displays(
|
async def open_vlm_displays(
|
||||||
|
|
||||||
linked: LinkedSplits,
|
linked: LinkedSplits,
|
||||||
flume: Flume,
|
flume: Flume,
|
||||||
dvlm: bool = True,
|
dvlm: bool = True,
|
||||||
|
|
@ -634,12 +639,12 @@ async def open_vlm_displays(
|
||||||
|
|
||||||
) -> None:
|
) -> None:
|
||||||
'''
|
'''
|
||||||
Volume subchart displays.
|
Vlm (volume) subchart displays.
|
||||||
|
|
||||||
Since "volume" is often included directly alongside OHLCV price
|
Since "volume" is often included directly alongside OHLCV price
|
||||||
data, we don't really need a separate FSP-actor + shm array for it
|
data, we don't really need a separate FSP-actor + shm array for
|
||||||
since it's likely already directly adjacent to OHLC samples from the
|
it since it's likely already directly adjacent to OHLC samples
|
||||||
data provider.
|
from the data provider.
|
||||||
|
|
||||||
Further only if volume data is detected (it sometimes isn't provided
|
Further only if volume data is detected (it sometimes isn't provided
|
||||||
eg. forex, certain commodities markets) will volume dependent FSPs
|
eg. forex, certain commodities markets) will volume dependent FSPs
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue