From 2e31ecbbe7643df4000e83415592b1ac1642675c Mon Sep 17 00:00:00 2001 From: goodboy Date: Sun, 8 Feb 2026 23:53:51 -0500 Subject: [PATCH] .brokers._daemon: enable `tractor` log in `brokerd` Also, - capture `Actor.loglevel` in `tll` var for reuse (when `loglevel` is null) and pass `bool`-ed as new `with_tractor_log`-flag. - add `with_tractor_log=bool(tll)` to `.get_console_log()` - add assertion check for logger name. - comment-out `tractor.trionics.collapse_eg()` context for now, pretty sure we don't need it and it just ends up adding extra logging overhead for no good reason (warnings on various `trio` internal cancelled-maskings, etc). - change type annotation: `str|None` vs `str | None`. (this commit msg was generated in some part by [`claude-code`][claude-code-gh]) [claude-code-gh]: https://github.com/anthropics/claude-code --- piker/brokers/_daemon.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/piker/brokers/_daemon.py b/piker/brokers/_daemon.py index 5414bfb9..eb5c2021 100644 --- a/piker/brokers/_daemon.py +++ b/piker/brokers/_daemon.py @@ -59,7 +59,7 @@ _data_mods: str = [ async def _setup_persistent_brokerd( ctx: tractor.Context, brokername: str, - loglevel: str | None = None, + loglevel: str|None = None, ) -> None: ''' @@ -72,10 +72,14 @@ async def _setup_persistent_brokerd( # since all hosted daemon tasks will reference this same # log instance's (actor local) state and thus don't require # any further (level) configuration on their own B) + actor: tractor.Actor = tractor.current_actor() + tll: str = actor.loglevel log = _util.get_console_log( - loglevel or tractor.current_actor().loglevel, + level=loglevel or tll, name=f'{_util.subsys}.{brokername}', + with_tractor_log=bool(tll), ) + assert log.name == _util.subsys # set global for this actor to this new process-wide instance B) _util.log = log @@ -97,7 +101,7 @@ async def _setup_persistent_brokerd( # NOTE: see ep invocation details inside `.data.feed`. try: async with ( - tractor.trionics.collapse_eg(), + # tractor.trionics.collapse_eg(), trio.open_nursery() as service_nursery ): bus: _FeedsBus = feed.get_feed_bus(