Revert "Drop extra method"
This reverts commit 6fa8958acf.
We actually do need it since the selection widget of course won't tell
you its "key" that we assign and further we'd have to use a (value, key)
style invocation which isn't super pythonic.
fsp_feeds
parent
f81d47efc4
commit
1fe29dc86b
|
|
@ -62,6 +62,19 @@ class SettingsPane:
|
||||||
# encompasing high level namespace
|
# encompasing high level namespace
|
||||||
order_mode: Optional['OrderMode'] = None # typing: ignore # noqa
|
order_mode: Optional['OrderMode'] = None # typing: ignore # noqa
|
||||||
|
|
||||||
|
def on_selection_change(
|
||||||
|
self,
|
||||||
|
|
||||||
|
text: str,
|
||||||
|
key: str,
|
||||||
|
|
||||||
|
) -> None:
|
||||||
|
'''Called on any order pane drop down selection change.
|
||||||
|
|
||||||
|
'''
|
||||||
|
log.info(f'selection input: {text}')
|
||||||
|
self.on_ui_settings_change(key, text)
|
||||||
|
|
||||||
def on_ui_settings_change(
|
def on_ui_settings_change(
|
||||||
self,
|
self,
|
||||||
|
|
||||||
|
|
@ -72,7 +85,6 @@ class SettingsPane:
|
||||||
'''Called on any order pane edit field value change.
|
'''Called on any order pane edit field value change.
|
||||||
|
|
||||||
'''
|
'''
|
||||||
log.info(f'selection input: {value}')
|
|
||||||
mode = self.order_mode
|
mode = self.order_mode
|
||||||
|
|
||||||
# an account switch request
|
# an account switch request
|
||||||
|
|
|
||||||
|
|
@ -733,7 +733,7 @@ async def open_order_mode(
|
||||||
|
|
||||||
w.currentTextChanged.connect(
|
w.currentTextChanged.connect(
|
||||||
partial(
|
partial(
|
||||||
order_pane.on_ui_settings_change,
|
order_pane.on_selection_change,
|
||||||
key=key,
|
key=key,
|
||||||
)
|
)
|
||||||
)
|
)
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue