43 lines
1.6 KiB
Markdown
43 lines
1.6 KiB
Markdown
|
---
|
||
|
|
model: openai/gpt-5.6-sol
|
||
|
|
service: opencode
|
||
|
|
session: c3a1b1ba-65c6-4c8e-bd12-e596031b0eb0
|
||
|
|
timestamp: 2026-09-01T02:42:35Z
|
||
|
|
git_ref: e09e306a
|
||
|
|
scope: code
|
||
|
|
substantive: true
|
||
|
|
raw_file: 20260901T024235Z_e09e306a_prompt_io.raw.md
|
||
|
|
---
|
||
|
|
|
||
|
|
## Prompt
|
||
|
|
|
||
|
|
Address the Tuicr review by separating generic websocket reconnect
|
||
|
|
changes from Binance-specific work and testing the real reconnect task
|
||
|
|
hierarchy rather than a reimplementation.
|
||
|
|
|
||
|
|
## Response summary
|
||
|
|
|
||
|
|
Preserves structured cancellation and safe first-handshake retries in
|
||
|
|
`_web_bs`. Adds three focused regressions in a dedicated websocket test
|
||
|
|
module and packages them as an independent commit boundary.
|
||
|
|
|
||
|
|
## Files changed
|
||
|
|
|
||
|
|
- `piker/data/_web_bs.py` - restart handled handshake failures and let
|
||
|
|
cancellation bypass the reconnect throttle.
|
||
|
|
- `tests/test_websocket.py` - exercise real reconnect startup, retry,
|
||
|
|
and cancellation task paths with controlled transport boundaries.
|
||
|
|
- `ai/prompt-io/opencode/20260901T024235Z_e09e306a_prompt_io.raw.md`
|
||
|
|
- retain the review prompt, generated-code summary, and verification.
|
||
|
|
- `ai/prompt-io/opencode/20260901T024235Z_e09e306a_prompt_io.md` - record
|
||
|
|
structured provenance for the generic reconnect boundary.
|
||
|
|
|
||
|
|
## Human edits
|
||
|
|
|
||
|
|
The user identified that these changes were generic rather than
|
||
|
|
Binance-specific, required a separate commit and test module, requested
|
||
|
|
coverage of the real reconnect hierarchy, and corrected code prose to
|
||
|
|
refer to `trio` consistently. A follow-up review required the production
|
||
|
|
code to explain why `trio.Cancelled` bypasses the broad reconnect-error
|
||
|
|
handler and cite the regression which audits that teardown invariant.
|