From 9f4e497b9ce1054655ef6062f81f662402fb62b9 Mon Sep 17 00:00:00 2001 From: Tyler Goodlet Date: Fri, 8 Jan 2021 20:36:57 -0500 Subject: [PATCH] Don't shield proc waits --- tractor/_spawn.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tractor/_spawn.py b/tractor/_spawn.py index 31a414c..f8528ac 100644 --- a/tractor/_spawn.py +++ b/tractor/_spawn.py @@ -273,10 +273,14 @@ async def new_proc( # ``trio.Process.__aexit__()`` (it tears down stdio # which will kill any waiting remote pdb trace). + # TODO: No idea how we can enforce zombie + # reaping more stringently without the shield + # we used to have below... + # always "hard" join sub procs: # no actor zombies allowed - with trio.CancelScope(shield=True): - await proc.wait() + # with trio.CancelScope(shield=True): + await proc.wait() else: # `multiprocessing` assert _ctx