forked from goodboy/tractor
				
			Adjust linked-loop-task tear down sequence
Close the mem chan before cancelling the `trio` task in order to ensure we retrieve whatever error is shuttled from `asyncio` before the channel read is potentially cancelled (previously a race?). Handle `asyncio.CancelledError` specially such that we raise it directly (instead of `raise aio_cancelled from other_err`) since it *is* the source error in the case where the cancellation is `asyncio` internal.infect_asyncio
							parent
							
								
									56357242e9
								
							
						
					
					
						commit
						1114b6980e
					
				| 
						 | 
				
			
			@ -3,6 +3,7 @@ Infection apis for ``asyncio`` loops running ``trio`` using guest mode.
 | 
			
		|||
 | 
			
		||||
'''
 | 
			
		||||
import asyncio
 | 
			
		||||
from asyncio.exceptions import CancelledError
 | 
			
		||||
from contextlib import asynccontextmanager as acm
 | 
			
		||||
import inspect
 | 
			
		||||
from typing import (
 | 
			
		||||
| 
						 | 
				
			
			@ -15,7 +16,7 @@ from typing import (
 | 
			
		|||
 | 
			
		||||
import trio
 | 
			
		||||
 | 
			
		||||
from .log import get_logger, get_console_log
 | 
			
		||||
from .log import get_logger
 | 
			
		||||
from ._state import current_actor
 | 
			
		||||
 | 
			
		||||
log = get_logger(__name__)
 | 
			
		||||
| 
						 | 
				
			
			@ -110,14 +111,16 @@ def _run_asyncio_task(
 | 
			
		|||
        nonlocal aio_err
 | 
			
		||||
        try:
 | 
			
		||||
            aio_err = task.exception()
 | 
			
		||||
        except asyncio.CancelledError as cerr:
 | 
			
		||||
        except CancelledError as cerr:
 | 
			
		||||
            log.exception("infected task was cancelled")
 | 
			
		||||
            # raise
 | 
			
		||||
            aio_err = cerr
 | 
			
		||||
 | 
			
		||||
        if aio_err:
 | 
			
		||||
            log.exception(f"asyncio task errorred:\n{aio_err}")
 | 
			
		||||
            log.exception(f"infected task errorred with {type(aio_err)}")
 | 
			
		||||
            from_aio._err = aio_err
 | 
			
		||||
            cancel_scope.cancel()
 | 
			
		||||
            from_aio.close()
 | 
			
		||||
            cancel_scope.cancel()
 | 
			
		||||
 | 
			
		||||
    task.add_done_callback(cancel_trio)
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			@ -132,10 +135,11 @@ async def run_task(
 | 
			
		|||
    **kwargs,
 | 
			
		||||
 | 
			
		||||
) -> Any:
 | 
			
		||||
    """Run an ``asyncio`` async function or generator in a task, return
 | 
			
		||||
    '''
 | 
			
		||||
    Run an ``asyncio`` async function or generator in a task, return
 | 
			
		||||
    or stream the result back to ``trio``.
 | 
			
		||||
 | 
			
		||||
    """
 | 
			
		||||
    '''
 | 
			
		||||
    # simple async func
 | 
			
		||||
    try:
 | 
			
		||||
        task, from_aio, to_trio, cs, _ = _run_asyncio_task(
 | 
			
		||||
| 
						 | 
				
			
			@ -151,24 +155,36 @@ async def run_task(
 | 
			
		|||
            return await from_aio.receive()
 | 
			
		||||
 | 
			
		||||
        if cs.cancelled_caught:
 | 
			
		||||
            aio_err = from_aio._err
 | 
			
		||||
 | 
			
		||||
            # always raise from any captured asyncio error
 | 
			
		||||
            if from_aio._err:
 | 
			
		||||
                raise from_aio._err
 | 
			
		||||
            if aio_err:
 | 
			
		||||
                raise aio_err
 | 
			
		||||
 | 
			
		||||
    # Do we need this?
 | 
			
		||||
    except BaseException as err:
 | 
			
		||||
    except (
 | 
			
		||||
        Exception,
 | 
			
		||||
        CancelledError,
 | 
			
		||||
    ) as err:
 | 
			
		||||
 | 
			
		||||
        aio_err = from_aio._err
 | 
			
		||||
 | 
			
		||||
        if aio_err is not None:
 | 
			
		||||
        if (
 | 
			
		||||
            aio_err is not None and
 | 
			
		||||
            type(aio_err) != CancelledError
 | 
			
		||||
        ):
 | 
			
		||||
            # always raise from any captured asyncio error
 | 
			
		||||
            raise err from aio_err
 | 
			
		||||
        else:
 | 
			
		||||
            raise
 | 
			
		||||
 | 
			
		||||
    finally:
 | 
			
		||||
        if not task.done():
 | 
			
		||||
            task.cancel()
 | 
			
		||||
 | 
			
		||||
        # if task.cancelled():
 | 
			
		||||
        #     ... do what ..
 | 
			
		||||
 | 
			
		||||
 | 
			
		||||
# TODO: explicitly api for the streaming case where
 | 
			
		||||
# we pull from the mem chan in an async generator?
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue