jc211
/
tractor
forked from goodboy/tractor
1
0
Fork 0
Code Pull Requests Activity
706 Commits
211 Branches
0 Tags
9.3 MiB
Commit Graph

706 Commits (e3591092311468d33a16086790751c0487d15d3e)

Author SHA1 Message Date
Tyler Goodlet e359109231 Go back to only logging tbs on no debugger 2021-07-02 13:12:59 -04:00
Tyler Goodlet b87afa5e8b De-densify some code 2021-07-02 13:12:59 -04:00
Tyler Goodlet 4e53605dd4 Comment hard-kill-sidestep for now since nursery version covers it? 2021-07-02 13:12:59 -04:00
Tyler Goodlet ecefca8756 Go back to only logging crashes if no pdb gets engaged 2021-07-02 13:12:59 -04:00
Tyler Goodlet 900f04a31d Solve the root-cancels-child-in-tty-lock race 
Finally this makes a cancelled root actor nursery not clobber child
tasks which request and lock the root's tty for the debugger repl.

Using an edge triggered event which is set after all fifo-lock-queued
tasks are complete, we can be sure that no lingering child tasks are
going to get interrupted during pdb use and tty lock acquisition.
Further, even if new tasks do queue up to get the lock, the root will
incrementally send cancel msgs to each sub-actor only once the tty is
not locked by a (set of) child request task(s). Add shielding around all
the critical sections where the child attempts to allocate the lock from
the root such that it won't be disrupted from cancel messages from the
root after the acquire lock transaction has started.
 2021-07-02 13:12:59 -04:00
Tyler Goodlet 9fa451fdd3 Always shield cancel the caller on cancel-causing-errors, add teardown logging 2021-07-02 13:12:59 -04:00
Tyler Goodlet 4d0c5f04c6 Distinguish between a local pdb unlock and the tty unlock in root 2021-07-02 13:12:59 -04:00
Tyler Goodlet ec918ad4bd First try: pack cancelled tracebacks and ship to caller 2021-07-02 13:12:59 -04:00
Tyler Goodlet a257f5b49d Add temp warning msg for context cancel call 2021-07-02 13:12:59 -04:00
Tyler Goodlet b414d7b8ba Add some brief todo notes on idea of shielded breakpoint 2021-07-02 13:12:59 -04:00
Tyler Goodlet 119cf6d9fc Fix hard kill in debug mode; only do it when debug lock is empty 2021-07-02 13:12:59 -04:00
Tyler Goodlet 0629a72269 Move some infos to runtime level 2021-07-02 13:12:59 -04:00
Tyler Goodlet 3c21210d8b Add PDB level and make runtime below info but above debug 2021-07-02 13:12:59 -04:00
Tyler Goodlet 6bbc51a147 Consider relaying context error via raised-in-scope-nursery task 2021-07-02 13:12:59 -04:00
Tyler Goodlet c8eb49147f Move debugger wait inside OCA nursery 2021-07-02 12:12:35 -04:00
Tyler Goodlet 308adce35c Don't shield debugger status wait; it causes hangs 2021-07-02 12:12:35 -04:00
Tyler Goodlet ecc7c9d346 Catch and delay errors in the root if debugger is active 2021-07-02 12:12:35 -04:00
Tyler Goodlet cdddf54b1d Don't shield on root cancel it can causes hangs 2021-07-02 12:12:35 -04:00
Tyler Goodlet 1335a6f043 Experiment: only disable SIGINT handling in children 2021-07-02 12:12:35 -04:00
Tyler Goodlet 8d003c5116 Don't kill root's immediate children when in debug 
If the root calls `trio.Process.kill()` on immediate child proc teardown
when the child is using pdb, we can get stdstreams clobbering that
results in a pdb++ repl where the user can't see what's been typed. Not
killing such children on cancellation / error seems to resolve this
issue whilst still giving reliable termination. For now, code that
special path until a time it becomes a problem for ensuring zombie
reaps.
 2021-07-02 12:12:35 -04:00
Tyler Goodlet 6d05de6a0c Add debug example that causes pdb stdin clobbering 2021-07-02 12:12:35 -04:00
Tyler Goodlet 0118931229 Add a specially handled `ContextCancelled` error 2021-07-02 12:11:50 -04:00
Tyler Goodlet a1603709ab Set stream "end of channel" after shielded check! 
Another face palm that was causing serious issues for code that is using
the `.shielded` feature..

Add a bunch more detailed comments for all this subtlety and hopefully
get it right once and for all. Also aggregated the `trio` errors that
should trigger closure inside `.aclose()`, hopefully that's right too.
 2021-07-02 11:59:12 -04:00
Tyler Goodlet 78b4eef7ee Don't clobber msg loop mem chan on rx stream close 
Revert this change since it really is poking at internals and doesn't
make a lot of sense. If the context is going to be cancelled then the
msg loop will tear down the feed memory channel when ready, we don't
need to be clobbering it and confusing the runtime machinery lol.
 2021-07-02 11:59:12 -04:00
Tyler Goodlet 211fb07074 Modernize streaming tests 2021-07-02 11:59:12 -04:00
Tyler Goodlet ae45b5ff1d Speedup the dynamic pubsub test 2021-07-02 11:59:12 -04:00
Tyler Goodlet c542b915d6 Add detailed ``@tractor.context`` cancellation/termination tests 2021-07-02 11:59:12 -04:00
Tyler Goodlet 6bd16749f0 Drop trailing comma 2021-07-02 11:59:12 -04:00
Tyler Goodlet 8f468a8c86 Adjustments for non-frozen context dataclass change 2021-07-02 11:59:12 -04:00
Tyler Goodlet 3fa36f64ac Wait for debugger lock task context termination 2021-07-02 11:59:12 -04:00
Tyler Goodlet be39ff38e4 Fix exception typing 2021-07-02 11:59:12 -04:00
Tyler Goodlet 9cd5d2d7b9 Explicitly formalize context/streaming teardown 
Add clear teardown semantics for `Context` such that the remote side
cancellation propagation happens only on error or if client code
explicitly requests it (either by exit flag to `Portal.open_context()`
or by manually calling `Context.cancel()`).  Add `Context.result()`
to wait on and capture the final result from a remote context function;
any lingering msg sequence will be consumed/discarded.

Changes in order to make this possible:
- pass the runtime msg loop's feeder receive channel in to the context
  on the calling (portal opening) side such that a final 'return' msg
  can be waited upon using `Context.result()` which delivers the final
  return value from the callee side `@tractor.context` async function.
- always await a final result from the target context function in
  `Portal.open_context()`'s `__aexit__()` if the context has not
  been (requested to be) cancelled by client code on block exit.
- add an internal `Context._cancel_called` for context "cancel
  requested" tracking (much like `trio`'s cancel scope).
- allow flagging a stream as terminated using an internal
  `._eoc` flag which will mark the stream as stopped for iteration.
- drop `StopAsyncIteration` catching in `.receive()`; it does
  nothing.
 2021-07-02 11:59:12 -04:00
Tyler Goodlet 4601c88574 Specially raise a `ContextCancelled` for a task-context rpc 2021-07-02 11:59:07 -04:00
Tyler Goodlet a1488a1773 Expose streaming components at top level 2021-07-02 11:58:45 -04:00
Tyler Goodlet e058506a00 Add a specially handled `ContextCancelled` error 2021-07-02 11:58:44 -04:00
Tyler Goodlet 19a23fefa9 Add a multi-task streaming test 2021-07-02 11:58:01 -04:00
Tyler Goodlet 40ad00ce02 Avoid mutate on iterate race 2021-07-02 11:58:01 -04:00
Tyler Goodlet b3caf846fc Only close recv chan if we get a ref 2021-07-02 11:58:01 -04:00
Tyler Goodlet 40cb3585c1 Add error case 2021-07-02 11:58:01 -04:00
Tyler Goodlet 88dbaff11b Support no arg to `Context.started()` like trio 2021-07-02 11:58:01 -04:00
Tyler Goodlet 3e34f0a374 Fix up var naming and typing 2021-07-02 11:58:01 -04:00
Tyler Goodlet 9e7bed646d Only send stop msg if not received from far end 2021-07-02 11:58:01 -04:00
Tyler Goodlet 0b73a4b61e Expose msg stream types at top level 2021-07-02 11:58:01 -04:00
Tyler Goodlet eb237f24cd Add dynamic pubsub test using new bidir stream apis 2021-07-02 11:58:01 -04:00
Tyler Goodlet 83f1e79fdd Use context for remote debugger locking 
A context is the natural fit (vs. a receive stream) for locking the root
proc's tty usage via it's `.started()` sync point. Simplify the
`_breakpoin()` routine to be a simple async func instead of all this
"returning a coroutine" stuff from before we decided that
`tractor.breakpoint()` must be async. Use `runtime` level for locking
logging making it easier to trace.
 2021-07-02 11:58:01 -04:00
Tyler Goodlet 1192541623 Be more pedantic with error handling 2021-07-02 11:58:01 -04:00
Tyler Goodlet 15b63b7190 Fix typing 2021-07-02 11:58:01 -04:00
Tyler Goodlet c4d5f9d41e Parametrize with async for style tests 2021-07-02 11:58:01 -04:00
Tyler Goodlet b7089bb4e0 Support passing `shield` at stream contruction 2021-07-02 11:58:01 -04:00
Tyler Goodlet ecb9655519 Add basic test set 2021-07-02 11:58:01 -04:00