jc211
/
tractor
forked from goodboy/tractor
1
0
Fork 0
Code Pull Requests Activity

Always log actor errors

dereg_on_channel_aclose
Tyler Goodlet 2020-08-13 11:55:22 -04:00
parent 863a4b7933
commit ec5d443ee5
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tractor/_actor.py
View File

@ -588,7 +588,6 @@ class Actor:
f"Failed to connect to parent @ {parent_addr}," f"Failed to connect to parent @ {parent_addr},"
" closing server") " closing server")
await self.cancel() await self.cancel()
# self._parent_chan = None
raise raise
async def _async_main( async def _async_main(
@ -631,8 +630,8 @@ class Actor:
self.load_modules() self.load_modules()
# The "root" nursery ensures the channel with the immediate # The "root" nursery ensures the channel with the immediate
# parent is kept alive as a reslient service until # parent is kept alive as a resilient service until
# cancellation steps have (mostly) ocurred in # cancellation steps have (mostly) occurred in
# a deterministic way. # a deterministic way.
async with trio.open_nursery() as root_nursery: async with trio.open_nursery() as root_nursery:
self._root_n = root_nursery self._root_n = root_nursery
@ -647,7 +646,7 @@ class Actor:
assert self._service_n assert self._service_n
# Startup up the channel server with, # Startup up the channel server with,
# - subactor: the bind address sent to us by our parent # - subactor: the bind address is sent by our parent
# over our established channel # over our established channel
# - root actor: the ``accept_addr`` passed to this method # - root actor: the ``accept_addr`` passed to this method
assert accept_addr assert accept_addr
@ -721,15 +720,15 @@ class Actor:
log.error( log.error(
f"Failed to ship error to parent " f"Failed to ship error to parent "
f"{self._parent_chan.uid}, channel was closed") f"{self._parent_chan.uid}, channel was closed")
log.exception("Actor errored:")
# always! # always!
log.exception("Actor errored:")
raise raise
finally: finally:
log.info("Root nursery complete") log.info("Root nursery complete")
# UNregister actor from the arbiter # Unregister actor from the arbiter
if registered_with_arbiter and ( if registered_with_arbiter and (
self._arb_addr is not None self._arb_addr is not None
): ):