From 9bd534df83cf74c8b2aaa66ae2a3e8b4d7dac2e2 Mon Sep 17 00:00:00 2001 From: Tyler Goodlet Date: Wed, 3 Aug 2022 15:38:27 -0400 Subject: [PATCH 1/6] Drop 3.9 from CI jobs --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7934044..c5ecbac 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,7 +57,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest] - python: ['3.9', '3.10'] + python: ['3.10'] spawn_backend: ['trio', 'mp'] steps: @@ -97,7 +97,7 @@ jobs: fail-fast: false matrix: os: [windows-latest] - python: ['3.9', '3.10'] + python: ['3.10'] spawn_backend: ['trio', 'mp'] steps: From c3cdeeb3baf83f41fb3f06b145179356feaed670 Mon Sep 17 00:00:00 2001 From: Tyler Goodlet Date: Tue, 6 Sep 2022 08:26:02 -0400 Subject: [PATCH 2/6] Drop `pytest` full trace flag, use `pip list` --- .github/workflows/ci.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c5ecbac..bcfe8f2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,6 +28,8 @@ jobs: - name: Run MyPy check run: mypy tractor/ --ignore-missing-imports + # test that we can generate a software distribution and install it + # thus avoid missing file issues after packaging. sdist-linux: name: 'sdist' runs-on: ubuntu-latest @@ -74,7 +76,7 @@ jobs: run: pip install -U . -r requirements-test.txt -r requirements-docs.txt --upgrade-strategy eager - name: List dependencies - run: pip freeze + run: pip list - name: Run tests run: pytest tests/ --spawn-backend=${{ matrix.spawn_backend }} -rsx @@ -114,7 +116,7 @@ jobs: run: pip install -U . -r requirements-test.txt -r requirements-docs.txt --upgrade-strategy eager - name: List dependencies - run: pip freeze + run: pip list - name: Run tests - run: pytest tests/ --spawn-backend=${{ matrix.spawn_backend }} -rs --full-trace + run: pytest tests/ --spawn-backend=${{ matrix.spawn_backend }} -rsx From e24645eec8e454e7e74a28f6e477ce58a91db525 Mon Sep 17 00:00:00 2001 From: Tyler Goodlet Date: Thu, 15 Sep 2022 15:36:29 -0400 Subject: [PATCH 3/6] Drop `pytest` 3.10 issue comment, add todo for `pyreadline3` --- .github/workflows/ci.yml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bcfe8f2..b98e28b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -81,9 +81,9 @@ jobs: - name: Run tests run: pytest tests/ --spawn-backend=${{ matrix.spawn_backend }} -rsx - # We skip 3.10 on windows for now due to - # https://github.com/pytest-dev/pytest/issues/8733 - # some kinda weird `pyreadline` issue.. + # We skip 3.10 on windows for now due to not having any collabs to + # debug the CI failures. Anyone wanting to hack and solve them is very + # welcome, but our primary user base is not using that OS. # TODO: use job filtering to accomplish instead of repeated # boilerplate as is above XD: @@ -115,6 +115,11 @@ jobs: - name: Install dependencies run: pip install -U . -r requirements-test.txt -r requirements-docs.txt --upgrade-strategy eager + # TODO: pretty sure this solves debugger deps-issues on windows, but it needs to + # be verified by someone with a native setup. + # - name: Force pyreadline3 + # run: pip uninstall pyreadline; pip install -U pyreadline3 + - name: List dependencies run: pip list From 71f9881a6061568f6a87d1ebff7466b6d7d1ea64 Mon Sep 17 00:00:00 2001 From: Tyler Goodlet Date: Thu, 15 Sep 2022 15:37:03 -0400 Subject: [PATCH 4/6] Drop windows from CI until we get a collab that actually uses it XD --- .github/workflows/ci.yml | 54 ++++++++++++++++++++-------------------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b98e28b..15a2763 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -90,38 +90,38 @@ jobs: # - https://docs.github.com/en/actions/learn-github-actions/managing-complex-workflows # - https://docs.github.com/en/actions/learn-github-actions/managing-complex-workflows#using-a-build-matrix # - https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idif - testing-windows: - name: '${{ matrix.os }} Python ${{ matrix.python }} - ${{ matrix.spawn_backend }}' - timeout-minutes: 12 - runs-on: ${{ matrix.os }} + # testing-windows: + # name: '${{ matrix.os }} Python ${{ matrix.python }} - ${{ matrix.spawn_backend }}' + # timeout-minutes: 12 + # runs-on: ${{ matrix.os }} - strategy: - fail-fast: false - matrix: - os: [windows-latest] - python: ['3.10'] - spawn_backend: ['trio', 'mp'] + # strategy: + # fail-fast: false + # matrix: + # os: [windows-latest] + # python: ['3.10'] + # spawn_backend: ['trio', 'mp'] - steps: + # steps: - - name: Checkout - uses: actions/checkout@v2 + # - name: Checkout + # uses: actions/checkout@v2 - - name: Setup python - uses: actions/setup-python@v2 - with: - python-version: '${{ matrix.python }}' + # - name: Setup python + # uses: actions/setup-python@v2 + # with: + # python-version: '${{ matrix.python }}' - - name: Install dependencies - run: pip install -U . -r requirements-test.txt -r requirements-docs.txt --upgrade-strategy eager + # - name: Install dependencies + # run: pip install -U . -r requirements-test.txt -r requirements-docs.txt --upgrade-strategy eager - # TODO: pretty sure this solves debugger deps-issues on windows, but it needs to - # be verified by someone with a native setup. - # - name: Force pyreadline3 - # run: pip uninstall pyreadline; pip install -U pyreadline3 + # # TODO: pretty sure this solves debugger deps-issues on windows, but it needs to + # # be verified by someone with a native setup. + # # - name: Force pyreadline3 + # # run: pip uninstall pyreadline; pip install -U pyreadline3 - - name: List dependencies - run: pip list + # - name: List dependencies + # run: pip list - - name: Run tests - run: pytest tests/ --spawn-backend=${{ matrix.spawn_backend }} -rsx + # - name: Run tests + # run: pytest tests/ --spawn-backend=${{ matrix.spawn_backend }} -rsx From 1f2001020e87a3fdd90fcdb5f220a2525e4cde5c Mon Sep 17 00:00:00 2001 From: Tyler Goodlet Date: Thu, 15 Sep 2022 17:02:18 -0400 Subject: [PATCH 5/6] Mention disabled windows CI in readme --- docs/README.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/docs/README.rst b/docs/README.rst index e98f8ea..9d80627 100644 --- a/docs/README.rst +++ b/docs/README.rst @@ -567,6 +567,13 @@ Help us push toward the future of distributed `Python`. - Typed capability-based (dialog) protocols ( see `#196 `_ with draft work started in `#311 `_) +- We **recently disabled CI-testing on windows** and need help getting + it running again! (see `#322 + `_). **We do have windows + support** (and have for quite a while) but since no active hacker + exists in the user-base to help test on that OS, for now we're not + actively maintaining testing due to the added hassle and general + latency.. Feel like saying hi? From 83b44cf469eae30fba714a03594796c103e2b5ac Mon Sep 17 00:00:00 2001 From: Tyler Goodlet Date: Thu, 15 Sep 2022 18:54:51 -0400 Subject: [PATCH 6/6] Flip over PR number in readme --- docs/README.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/README.rst b/docs/README.rst index 9d80627..992d3f2 100644 --- a/docs/README.rst +++ b/docs/README.rst @@ -568,8 +568,8 @@ Help us push toward the future of distributed `Python`. `_ with draft work started in `#311 `_) - We **recently disabled CI-testing on windows** and need help getting - it running again! (see `#322 - `_). **We do have windows + it running again! (see `#327 + `_). **We do have windows support** (and have for quite a while) but since no active hacker exists in the user-base to help test on that OS, for now we're not actively maintaining testing due to the added hassle and general