From cd636b270ea950107535e97ceb844786b0f1f7e3 Mon Sep 17 00:00:00 2001 From: Tyler Goodlet Date: Wed, 24 Feb 2021 13:38:20 -0500 Subject: [PATCH] Update debug tests to expect 'root' actor name --- tests/test_debugger.py | 8 ++++---- tractor/_root.py | 3 --- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/tests/test_debugger.py b/tests/test_debugger.py index 9f62653..8f850df 100644 --- a/tests/test_debugger.py +++ b/tests/test_debugger.py @@ -82,7 +82,7 @@ def test_root_actor_error(spawn, user_in_out): before = str(child.before.decode()) # make sure expected logging and error arrives - assert "Attaching to pdb in crashed actor: ('arbiter'" in before + assert "Attaching to pdb in crashed actor: ('root'" in before assert 'AssertionError' in before # send user command @@ -170,7 +170,7 @@ def test_subactor_error(spawn): before = str(child.before.decode()) # root actor gets debugger engaged - assert "Attaching to pdb in crashed actor: ('arbiter'" in before + assert "Attaching to pdb in crashed actor: ('root'" in before # error is a remote error propagated from the subactor assert "RemoteActorError: ('name_error'" in before @@ -276,7 +276,7 @@ def test_multi_subactors(spawn): child.sendline('q') child.expect(r"\(Pdb\+\+\)") before = str(child.before.decode()) - assert "Attaching to pdb in crashed actor: ('arbiter'" in before + assert "Attaching to pdb in crashed actor: ('root'" in before assert "RemoteActorError: ('breakpoint_forever'" in before assert 'bdb.BdbQuit' in before @@ -344,7 +344,7 @@ def test_multi_subactors_root_errors(spawn): before = str(child.before.decode()) # should have come just after priot prompt - assert "Attaching to pdb in crashed actor: ('arbiter'" in before + assert "Attaching to pdb in crashed actor: ('root'" in before assert "AssertionError" in before # warnings assert we probably don't need diff --git a/tractor/_root.py b/tractor/_root.py index 1206864..7123eb5 100644 --- a/tractor/_root.py +++ b/tractor/_root.py @@ -165,9 +165,6 @@ async def open_root_actor( try: yield actor - # except BaseException as err: - # breakpoint() - except (Exception, trio.MultiError) as err: logger.exception("Actor crashed:") await _debug._maybe_enter_pm(err)