From b0b35284f4a7d962486cbb290a9ba4b26ffe8f54 Mon Sep 17 00:00:00 2001
From: Tyler Goodlet <tgoodlet@gmail.com>
Date: Fri, 25 Jan 2019 00:13:13 -0500
Subject: [PATCH] Add call/decorate time type checking tests

---
 tests/test_pubsub.py | 60 +++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 57 insertions(+), 3 deletions(-)

diff --git a/tests/test_pubsub.py b/tests/test_pubsub.py
index e5f37ef..f0c4beb 100644
--- a/tests/test_pubsub.py
+++ b/tests/test_pubsub.py
@@ -1,5 +1,4 @@
 import time
-from functools import partial
 from itertools import cycle
 
 import pytest
@@ -9,6 +8,23 @@ from async_generator import aclosing
 from tractor.testing import tractor_test
 
 
+def test_type_checks():
+
+    with pytest.raises(TypeError) as err:
+        @tractor.msg.pub
+        async def no_get_topics(yo):
+            yield
+
+    assert "must define a `get_topics`" in str(err.value)
+
+    with pytest.raises(TypeError) as err:
+        @tractor.msg.pub
+        def not_async_gen(yo):
+            pass
+
+    assert "must be an async generator function" in str(err.value)
+
+
 def is_even(i):
     return i % 2 == 0
 
@@ -31,9 +47,11 @@ async def subs(which, pub_actor_name):
         if which[0] == 'even':
             pred = is_even
         else:
-            pred = lambda i: not is_even(i)
+            def pred(i):
+                return not is_even(i)
     else:
-        pred = lambda i: isinstance(i, int)
+        def pred(i):
+            return isinstance(i, int)
 
     async with tractor.find_actor(pub_actor_name) as portal:
         agen = await portal.run(__name__, 'pubber', topics=which)
@@ -43,6 +61,42 @@ async def subs(which, pub_actor_name):
                     assert pred(value)
 
 
+@tractor.msg.pub(tasks=['one', 'two'])
+async def multilock_pubber(get_topics):
+    yield {'doggy': 10}
+
+
+@pytest.mark.parametrize(
+    'callwith_expecterror',
+    [
+        (pubber, {}, TypeError),
+        # missing a `topics`
+        (multilock_pubber, {'ctx': None}, TypeError),
+        # missing a `task_name`
+        (multilock_pubber, {'ctx': None, 'topics': ['topic1']}, TypeError),
+        # should work
+        (multilock_pubber,
+         {'ctx': None, 'topics': ['topic1'], 'task_name': 'one'},
+         None),
+    ],
+)
+@tractor_test
+async def test_required_args(callwith_expecterror):
+    func, kwargs, err = callwith_expecterror
+
+    if err is not None:
+        with pytest.raises(err):
+            await func(**kwargs)
+    else:
+        async with tractor.open_nursery() as n:
+            # await func(**kwargs)
+            portal = await n.run_in_actor(
+                'sub', multilock_pubber, **kwargs)
+
+            async for val in await portal.result():
+                assert val == {'doggy': 10}
+
+
 @pytest.mark.parametrize(
     'pub_actor',
     ['streamer', 'arbiter']