jc211
/
tractor
forked from goodboy/tractor
1
0
Fork 0
Code Pull Requests Activity

Don't need to pack an `Error` with send-side MTEs

runtime_to_msgspec
Tyler Goodlet 2024-05-30 09:05:23 -04:00
parent 02a7c7c276
commit 28af4749cc
1 changed files with 16 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
tractor/msg/_ops.py
View File

@ -269,19 +269,6 @@ class PldRx(Struct):
is_invalid_payload=True, is_invalid_payload=True,
expected_msg=expect_msg, expected_msg=expect_msg,
) )
err_msg: Error = pack_error(
exc=mte,
cid=msg.cid,
src_uid=(
ipc.chan.uid
if not is_started_send_side
else ipc._actor.uid
),
# tb=valerr.__traceback__,
tb_str=mte._message,
)
mte._ipc_msg = err_msg
# NOTE: just raise the MTE inline instead of all # NOTE: just raise the MTE inline instead of all
# the pack-unpack-repack non-sense when this is # the pack-unpack-repack non-sense when this is
# a "send side" validation error. # a "send side" validation error.
@ -301,6 +288,22 @@ class PldRx(Struct):
# ctx: Context = getattr(ipc, 'ctx', ipc) # ctx: Context = getattr(ipc, 'ctx', ipc)
# ctx._maybe_cancel_and_set_remote_error(mte) # ctx._maybe_cancel_and_set_remote_error(mte)
# NOTE: the `.message` is automatically
# transferred into the message as long as we
# define it as a `Error.message` field.
err_msg: Error = pack_error(
exc=mte,
cid=msg.cid,
src_uid=(
ipc.chan.uid
if not is_started_send_side
else ipc._actor.uid
),
# tb=valerr.__traceback__,
# tb_str=mte._message,
# message=mte._message,
)
mte._ipc_msg = err_msg
# XXX override the `msg` passed to # XXX override the `msg` passed to
# `_raise_from_unexpected_msg()` (below) so so # `_raise_from_unexpected_msg()` (below) so so