All 5 flagged items were valid (4 real bugs + 1 dead assert),
- fix an inverted `sys.version_info < (3, 14)` guard in
`ipc._linux` — the "`cffi` has no 3.14 support" import note now
fires on 3.14+ (where it applies) instead of on older pys.
- use `os.environ.get('PYTHON_COLORS')` in the `sync_bp` example
so it doesn't `KeyError` when run outside the test harness.
- correct `dump_task_tree()`'s docstring: the `/tmp` + `/dev/tty`
tee is gated on `write_file`/`write_tty`, not "unconditional".
- tidy the `ActorTooSlowError` message spacing in `cancel_actor`.
- replace a tautological `applied is True or applied is False` in
`test_patches` with `isinstance(applied, bool)` (the value is
order-dependent across the module).
Review: PR #462 (copilot-pull-request-reviewer)
https://github.com/goodboy/tractor/pull/462#pullrequestreview-4527179852
(this patch was generated in some part by [`claude-code`][claude-code-gh])
[claude-code-gh]: https://github.com/anthropics/claude-code
|
||
|---|---|---|
| .. | ||
| asyncio_bp.py | ||
| debug_mode_hang.py | ||
| fast_error_in_root_after_spawn.py | ||
| multi_daemon_subactors.py | ||
| multi_nested_subactors_error_up_through_nurseries.py | ||
| multi_subactor_root_errors.py | ||
| multi_subactors.py | ||
| open_ctx_modnofound.py | ||
| per_actor_debug.py | ||
| pm_in_subactor.py | ||
| restore_builtin_breakpoint.py | ||
| root_actor_breakpoint.py | ||
| root_actor_breakpoint_forever.py | ||
| root_actor_error.py | ||
| root_cancelled_but_child_is_in_tty_lock.py | ||
| root_self_cancelled_w_error.py | ||
| root_timeout_while_child_crashed.py | ||
| shield_hang_in_sub.py | ||
| shielded_pause.py | ||
| subactor_bp_in_ctx.py | ||
| subactor_breakpoint.py | ||
| subactor_error.py | ||
| sync_bp.py | ||