goodboy
/
tractor
1
0
Fork 1
Code Issues 1 Pull Requests 4 Packages Projects Releases Wiki Activity

Adjust nested error tests for racy nursery error collection

raise_runinactor_error
Tyler Goodlet 2022-01-05 10:03:28 -05:00
parent 97b79064f5
commit f4cab2ddb3
1 changed files with 17 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
tests/test_cancellation.py
View File

@ -326,16 +326,19 @@ async def spawn_and_error(breadth, depth) -> None:
) )
kwargs = { kwargs = {
'name': f'{name}_errorer_{i}', 'name': f'{name}_errorer_{i}',
# 'delay': 1,
} }
await nursery.run_in_actor(*args, **kwargs) await nursery.run_in_actor(*args, **kwargs)
@tractor_test @tractor_test
async def test_nested_multierrors(loglevel, start_method): async def test_nested_multierrors(loglevel, start_method):
"""Test that failed actor sets are wrapped in `trio.MultiError`s. '''
Test that failed actor sets are wrapped in `trio.MultiError`s.
This test goes only 2 nurseries deep but we should eventually have tests This test goes only 2 nurseries deep but we should eventually have tests
for arbitrary n-depth actor trees. for arbitrary n-depth actor trees.
"""
'''
if start_method == 'trio': if start_method == 'trio':
depth = 3 depth = 3
subactor_breadth = 2 subactor_breadth = 2
@ -359,6 +362,7 @@ async def test_nested_multierrors(loglevel, start_method):
breadth=subactor_breadth, breadth=subactor_breadth,
depth=depth, depth=depth,
) )
except trio.MultiError as err: except trio.MultiError as err:
assert len(err.exceptions) == subactor_breadth assert len(err.exceptions) == subactor_breadth
for subexc in err.exceptions: for subexc in err.exceptions:
@ -394,16 +398,13 @@ async def test_nested_multierrors(loglevel, start_method):
assert isinstance(subexc, tractor.RemoteActorError) assert isinstance(subexc, tractor.RemoteActorError)
if depth > 0 and subactor_breadth > 1: if depth > 0 and subactor_breadth > 1:
# XXX not sure what's up with this.. # XXX it's race whether or not a parent containing
# on windows sometimes spawning is just too slow and # a nursery *may* get multiple child failures before
# we get back the (sent) cancel signal instead # it cancels and tears down.
if platform.system() == 'Windows':
if isinstance(subexc, tractor.RemoteActorError): if isinstance(subexc, tractor.RemoteActorError):
assert subexc.type in (trio.MultiError, tractor.RemoteActorError) assert subexc.type in (trio.MultiError, tractor.RemoteActorError)
else: else:
assert isinstance(subexc, trio.MultiError) assert isinstance(subexc, trio.MultiError)
else:
assert subexc.type is trio.MultiError
else: else:
assert subexc.type in (tractor.RemoteActorError, trio.Cancelled) assert subexc.type in (tractor.RemoteActorError, trio.Cancelled)
@ -486,9 +487,11 @@ def test_cancel_while_childs_child_in_sync_sleep(
start_method, start_method,
spawn_backend, spawn_backend,
): ):
"""Verify that a child cancelled while executing sync code is torn """
down even when that cancellation is triggered by the parent Verify that a child cancelled while executing sync code is torn down
even when that cancellation is triggered by the parent
2 nurseries "up". 2 nurseries "up".
""" """
if start_method == 'forkserver': if start_method == 'forkserver':
pytest.skip("Forksever sux hard at resuming from sync sleep...") pytest.skip("Forksever sux hard at resuming from sync sleep...")
@ -500,7 +503,7 @@ def test_cancel_while_childs_child_in_sync_sleep(
spawn, spawn,
name='spawn', name='spawn',
) )
await trio.sleep(1) await trio.sleep(0.5)
assert 0 assert 0
with pytest.raises(AssertionError): with pytest.raises(AssertionError):