Go back to skipping since xfail is wack

signint_saviour
Tyler Goodlet 2022-08-01 12:29:06 -04:00
parent a9aaee9dbd
commit e4771eec16
1 changed files with 25 additions and 9 deletions

View File

@ -58,18 +58,21 @@ def mk_cmd(ex_name: str) -> str:
) )
# TODO: was trying to this xfail style but some weird bug i see in CI
# that's happening at collect time.. pretty soon gonna dump actions i'm
# thinkin...
# in CI we skip tests which >= depth 1 actor trees due to there # in CI we skip tests which >= depth 1 actor trees due to there
# still being an oustanding issue with relaying the debug-mode-state # still being an oustanding issue with relaying the debug-mode-state
# through intermediary parents. # through intermediary parents.
has_nested_actors = pytest.mark.xfail( has_nested_actors = pytest.mark.has_nested_actors #.xfail(
os.environ.get('CI', False), # os.environ.get('CI', False),
reason=( # reason=(
'This test uses nested actors and fails in CI\n' # 'This test uses nested actors and fails in CI\n'
'The test seems to run fine locally but until we solve the ' # 'The test seems to run fine locally but until we solve the '
'following issue this CI test will be xfail:\n' # 'following issue this CI test will be xfail:\n'
'<#issue>' # '<#issue>'
) # )
) # )
@pytest.fixture @pytest.fixture
@ -116,6 +119,7 @@ def assert_before(
def ctlc( def ctlc(
request, request,
ci_env: bool, ci_env: bool,
) -> bool: ) -> bool:
use_ctlc = request.param use_ctlc = request.param
@ -132,6 +136,18 @@ def ctlc(
# be 3.10+ mega-asap. # be 3.10+ mega-asap.
pytest.skip('Py3.9 and `pdbpp` son no bueno..') pytest.skip('Py3.9 and `pdbpp` son no bueno..')
if ci_env:
node = request.node
markers = node.own_markers
for mark in markers:
if mark.name == 'has_nested_actors':
pytest.skip(
f'Test for {node} uses nested actors and fails in CI\n'
f'The test seems to run fine locally but until we solve the following '
'issue this CI test will be xfail:\n'
f'<#issue>'
)
if use_ctlc: if use_ctlc:
# XXX: disable pygments highlighting for auto-tests # XXX: disable pygments highlighting for auto-tests
# since some envs (like actions CI) will struggle # since some envs (like actions CI) will struggle