From e24645eec8e454e7e74a28f6e477ce58a91db525 Mon Sep 17 00:00:00 2001 From: Tyler Goodlet Date: Thu, 15 Sep 2022 15:36:29 -0400 Subject: [PATCH] Drop `pytest` 3.10 issue comment, add todo for `pyreadline3` --- .github/workflows/ci.yml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bcfe8f2..b98e28b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -81,9 +81,9 @@ jobs: - name: Run tests run: pytest tests/ --spawn-backend=${{ matrix.spawn_backend }} -rsx - # We skip 3.10 on windows for now due to - # https://github.com/pytest-dev/pytest/issues/8733 - # some kinda weird `pyreadline` issue.. + # We skip 3.10 on windows for now due to not having any collabs to + # debug the CI failures. Anyone wanting to hack and solve them is very + # welcome, but our primary user base is not using that OS. # TODO: use job filtering to accomplish instead of repeated # boilerplate as is above XD: @@ -115,6 +115,11 @@ jobs: - name: Install dependencies run: pip install -U . -r requirements-test.txt -r requirements-docs.txt --upgrade-strategy eager + # TODO: pretty sure this solves debugger deps-issues on windows, but it needs to + # be verified by someone with a native setup. + # - name: Force pyreadline3 + # run: pip uninstall pyreadline; pip install -U pyreadline3 + - name: List dependencies run: pip list