goodboy
/
tractor
1
0
Fork 2
Code Issues 5 Pull Requests 6 Packages Projects Releases Wiki Activity

Use a short UDS reaper test bindspace 

Darwin's pytest `tmp_path` can already exceed the 104-byte AF_UNIX
budget before appending either synthetic socket filename. That made
the new sentinel-policy regression fail identically in both macOS
matrix legs without exercising reaper behavior.

Allocate the test's real socket files under a short
`/tmp/tractor-reap-*` directory and retain scoped cleanup.

Review: PR #480 (goodboy)
https://github.com/goodboy/tractor/pull/480

(this patch was generated in some part by `opencode` using
`gpt-5.6-sol` (`openai`))
wkt/uds_macos_473
Gud Boi 2026-08-14 10:59:07 -04:00
parent 584ea4e9ad
commit ac61d7a5bf
1 changed files with 30 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tests/ipc/test_each_tpt.py
View File

@ -8,6 +8,7 @@ from pathlib import Path
import socket import socket
import stat import stat
import sys import sys
import tempfile
from types import SimpleNamespace from types import SimpleNamespace
from unittest.mock import Mock from unittest.mock import Mock
@ -127,7 +128,6 @@ def test_reaper_uses_default_uds_bindspace(
def test_automatic_reaper_preserves_registry_sentinel( def test_automatic_reaper_preserves_registry_sentinel(
monkeypatch: pytest.MonkeyPatch, monkeypatch: pytest.MonkeyPatch,
tmp_path: Path,
): ):
''' '''
Reserve unconditional registry cleanup for the explicit CLI. Reserve unconditional registry cleanup for the explicit CLI.
@ -141,8 +141,13 @@ def test_automatic_reaper_preserves_registry_sentinel(
''' '''
from tractor._testing import _reap from tractor._testing import _reap
registry_path: Path = tmp_path / 'registry@1616.sock' with tempfile.TemporaryDirectory(
actor_path: Path = tmp_path / 'worker@1234.sock' prefix='tractor-reap-',
dir='/tmp',
) as tmpdir:
bindspace: Path = Path(tmpdir)
registry_path: Path = bindspace / 'registry@1616.sock'
actor_path: Path = bindspace / 'worker@1234.sock'
socks: list[socket.socket] = [] socks: list[socket.socket] = []
for path in (registry_path, actor_path): for path in (registry_path, actor_path):
sock = socket.socket(socket.AF_UNIX) sock = socket.socket(socket.AF_UNIX)
@ -152,11 +157,11 @@ def test_automatic_reaper_preserves_registry_sentinel(
monkeypatch.setattr(_reap, '_is_alive', lambda pid: False) monkeypatch.setattr(_reap, '_is_alive', lambda pid: False)
try: try:
assert _reap.find_orphaned_uds( assert _reap.find_orphaned_uds(
uds_dir=str(tmp_path), uds_dir=str(bindspace),
) == [str(actor_path)] ) == [str(actor_path)]
assert set( assert set(
_reap.find_orphaned_uds( _reap.find_orphaned_uds(
uds_dir=str(tmp_path), uds_dir=str(bindspace),
include_registry_sentinel=True, include_registry_sentinel=True,
) )
) == { ) == {