goodboy
/
tractor
1
0
Fork 1
Code Issues 1 Pull Requests 4 Packages Projects Releases Wiki Activity

Don't shield proc waits

we_aint_got_zombie_shields
Tyler Goodlet 2021-01-08 20:36:57 -05:00
parent 14d60147fa
commit 9f4e497b9c
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tractor/_spawn.py
View File

@ -273,10 +273,14 @@ async def new_proc(
# ``trio.Process.__aexit__()`` (it tears down stdio # ``trio.Process.__aexit__()`` (it tears down stdio
# which will kill any waiting remote pdb trace). # which will kill any waiting remote pdb trace).
# TODO: No idea how we can enforce zombie
# reaping more stringently without the shield
# we used to have below...
# always "hard" join sub procs: # always "hard" join sub procs:
# no actor zombies allowed # no actor zombies allowed
with trio.CancelScope(shield=True): # with trio.CancelScope(shield=True):
await proc.wait() await proc.wait()
else: else:
# `multiprocessing` # `multiprocessing`
assert _ctx assert _ctx