From 9e09dc5eee1592ec1d512abc7cc9db22879e5d86 Mon Sep 17 00:00:00 2001 From: goodboy Date: Fri, 1 May 2026 00:18:18 -0400 Subject: [PATCH] Default `--ll` to `None` in test harness MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Only override `tractor.log._default_loglevel` when the flag is explicitly passed — lets per-spawn and per-example `loglevel` kwargs take effect instead of being clobbered by the hard-coded `'ERROR'` default. (this commit msg was generated in some part by [`claude-code`][claude-code-gh]) [claude-code-gh]: https://github.com/anthropics/claude-code (cherry picked from commit 72a0465c5218c2c06b50841fcf890eb7d139d30d) --- tests/conftest.py | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/tests/conftest.py b/tests/conftest.py index 09c6a9fd..46f9c072 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -134,23 +134,30 @@ def pytest_addoption( "--ll", action="store", dest='loglevel', - default='ERROR', help="logging level to set when testing" + default=None, + help="logging level to set when testing", ) @pytest.fixture(scope='session', autouse=True) -def loglevel(request) -> str: +def loglevel( + request: pytest.FixtureRequest, +) -> str|None: import tractor orig = tractor.log._default_loglevel - level = tractor.log._default_loglevel = request.config.option.loglevel + flag_level: str|None = request.config.option.loglevel + + if flag_level is not None: + tractor.log._default_loglevel = flag_level + log = tractor.log.get_console_log( - level=level, + level=flag_level, name='tractor', # <- enable root logger ) log.info( - f'Test-harness set runtime loglevel: {level!r}\n' + f'Test-harness set runtime loglevel: {flag_level!r}\n' ) - yield level + yield flag_level tractor.log._default_loglevel = orig