From 8f17c89cf9be2c890145a57c50faf0222d448fc6 Mon Sep 17 00:00:00 2001 From: Tyler Goodlet Date: Wed, 29 Jul 2020 09:57:32 -0400 Subject: [PATCH] Skip **every** quad test for mp on ci --- tests/test_streaming.py | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/tests/test_streaming.py b/tests/test_streaming.py index 6d278b8..00b07cb 100644 --- a/tests/test_streaming.py +++ b/tests/test_streaming.py @@ -202,7 +202,11 @@ async def cancel_after(wait): @pytest.fixture(scope='module') -def time_quad_ex(arb_addr): +def time_quad_ex(arb_addr, travis, spawn_backend): + if travis and spawn_backend == 'mp' and (platform.system() != 'Windows'): + # no idea, but the travis, mp, linux runs are flaking out here often + pytest.skip("Test is too flaky on mp in CI") + timeout = 7 if platform.system() == 'Windows' else 4 start = time.time() results = tractor.run(cancel_after, timeout, arbiter_addr=arb_addr) @@ -213,9 +217,6 @@ def time_quad_ex(arb_addr): def test_a_quadruple_example(time_quad_ex, travis, spawn_backend): """This also serves as a kind of "we'd like to be this fast test".""" - if travis and spawn_backend == 'mp' and (platform.system() != 'Windows'): - # no idea, but the travis, mp, linux runs are flaking out here often - pytest.skip("Test is too flaky on mp in CI") results, diff = time_quad_ex assert results @@ -233,10 +234,6 @@ def test_not_fast_enough_quad( """Verify we can cancel midway through the quad example and all actors cancel gracefully. """ - if travis and spawn_backend == 'mp' and (platform.system() != 'Windows'): - # no idea, but the travis, mp, linux runs are flaking out here often - pytest.skip("Test is too flaky on mp in CI") - results, diff = time_quad_ex delay = max(diff - cancel_delay, 0) results = tractor.run(cancel_after, delay, arbiter_addr=arb_addr)