From 9bc1c6f3855eed8aa8b47a3f70afacce7602e9b4 Mon Sep 17 00:00:00 2001 From: Tyler Goodlet Date: Mon, 11 Jul 2022 20:15:35 -0400 Subject: [PATCH 1/3] Try windows CI on py 3.10 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index edef2d8..ea9d2ba 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -123,7 +123,7 @@ jobs: fail-fast: false matrix: os: [windows-latest] - python: ['3.9'] + python: ['3.9', '3.10'] spawn_backend: ['trio', 'mp'] steps: From b700dc34a8b749d5b6593ada10f66116ed49134a Mon Sep 17 00:00:00 2001 From: Tyler Goodlet Date: Tue, 12 Jul 2022 10:10:39 -0400 Subject: [PATCH 2/3] Use `pyreadline3` on windows for py3.10 --- setup.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/setup.py b/setup.py index 3aa1b96..6f45356 100755 --- a/setup.py +++ b/setup.py @@ -51,13 +51,17 @@ setup( 'tricycle', 'trio_typing', + # serialization + 'msgpack>=1.0.3', + # tooling 'colorlog', 'wrapt', 'pdbpp', - - # serialization - 'msgpack>=1.0.3', + # windows deps workaround for ``pdbpp`` + # https://github.com/pdbpp/pdbpp/issues/498 + # https://github.com/pdbpp/fancycompleter/issues/37 + 'pyreadline3 ; platform_system == "Windows"', ], extras_require={ From 9740a585d3cc7dbcd07114e00ce63768c4bcd211 Mon Sep 17 00:00:00 2001 From: Tyler Goodlet Date: Tue, 12 Jul 2022 10:24:44 -0400 Subject: [PATCH 3/3] Add nooz for win on py3.10 --- nooz/316.misc.rst | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 nooz/316.misc.rst diff --git a/nooz/316.misc.rst b/nooz/316.misc.rst new file mode 100644 index 0000000..bcae2fd --- /dev/null +++ b/nooz/316.misc.rst @@ -0,0 +1,5 @@ +Run windows CI jobs on python 3.10 after some +hacks for ``pdbpp`` dependency issues. + +Issue was to do with the now deprecated `pyreadline` project which +should be changed over to `pyreadline3`.