From 6b0cb17c047422660e41afe46c3b919e7c21cd7f Mon Sep 17 00:00:00 2001 From: goodboy Date: Wed, 17 Jun 2026 15:42:24 -0400 Subject: [PATCH] Address Copilot review nits on PR #461 Per the GH Copilot review, clean a few metadata/comment inconsistencies that would otherwise live on `main`, - drop the `3.12` Trove classifier since `requires-python` is now `>=3.13`. - remove the `ci.yml` comment referencing the not-yet-landed `--spawn-method=main_thread_forkserver` (misleading on `main`, and leaks the MTF name early). - fix the `//tmp` double-slash typo in the local `Read()` permission pattern. Review: PR #461 (copilot-pull-request-reviewer) https://github.com/goodboy/tractor/pull/461#pullrequestreview-4510034938 (this patch was generated in some part by [`claude-code`][claude-code-gh]) [claude-code-gh]: https://github.com/anthropics/claude-code --- .claude/settings.local.json | 2 +- .github/workflows/ci.yml | 1 - pyproject.toml | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.claude/settings.local.json b/.claude/settings.local.json index ac895510..415594e9 100644 --- a/.claude/settings.local.json +++ b/.claude/settings.local.json @@ -32,7 +32,7 @@ "Bash(UV_PROJECT_ENVIRONMENT=py* uv run:*)", "Bash(echo EXIT:$?:*)", "Bash(echo \"EXIT=$?\")", - "Read(//tmp/**)" + "Read(/tmp/**)" ], "deny": [], "ask": [] diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6eff3bcb..d89e2049 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -154,7 +154,6 @@ jobs: --spawn-backend=${{ matrix.spawn_backend }} --tpt-proto=${{ matrix.tpt_proto }} --capture=fd - # ^XXX^ can't work with --spawn-method=main_thread_forkserver # XXX legacy NOTE XXX # diff --git a/pyproject.toml b/pyproject.toml index db2aa7d3..0a905115 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -29,7 +29,6 @@ classifiers = [ "License :: OSI Approved :: GNU Affero General Public License v3 or later (AGPLv3+)", "Programming Language :: Python :: Implementation :: CPython", "Programming Language :: Python :: 3 :: Only", - "Programming Language :: Python :: 3.12", "Programming Language :: Python :: 3.13", "Programming Language :: Python :: 3.14", "Topic :: System :: Distributed Computing",