Tighten orphan-SIGINT xfail to `strict=True`

Re-classify `test_orphaned_subactor_sigint_cleanup_DRAFT` from
flakey-env-sensitive (`strict=False` w/ "passes in isolation, flakey in
full suite") to a hard known-gap (`strict=True`) with the orphan-SIGINT
hang as the documented cause. The previous framing ("env pollution") let
the test silently pass when ordering happened to favor it; the new
framing forces an XPASS-as-FAIL the moment the underlying gap is
actually closed, so we can drop the mark intentionally instead of
accidentally.

Reason text + leading `# Known-gap test —` comment both point at
`ai/conc-anal/subint_forkserver_orphan_sigint_hang_issue.md`
for the full diagnosis.

(this patch was generated in some part by [`claude-code`][claude-code-gh])
[claude-code-gh]: https://github.com/anthropics/claude-code

(cherry picked from commit 44bdb1697c)
Gud Boi 2026-04-24 22:48:35 -04:00
parent 1457299b84
commit 644a39fdb3
1 changed files with 9 additions and 11 deletions

View File

@ -446,21 +446,19 @@ def _process_alive(pid: int) -> bool:
return False
# Regressed back to xfail: previously passed after the
# fork-child FD-hygiene fix in `_close_inherited_fds()`,
# but the recent `wait_for_no_more_peers(move_on_after=3.0)`
# bound in `async_main`'s teardown added up to 3s to the
# orphan subactor's exit timeline, pushing it past the
# test's 10s poll window. Real fix requires making the
# bounded wait faster when the actor is orphaned, or
# increasing the test's poll window. See tracker doc
# Known-gap test — `subint_forkserver` orphan-SIGINT
# handling. See
# `ai/conc-anal/subint_forkserver_orphan_sigint_hang_issue.md`.
# `strict=True` so if a future fix closes the gap the
# XPASS surfaces as a FAIL and forces us to drop the
# mark intentionally.
@pytest.mark.xfail(
strict=True,
reason=(
'Regressed to xfail after `wait_for_no_more_peers` '
'bound added ~3s teardown latency. Needs either '
'faster orphan-side teardown or 15s test poll window.'
'Orphan subactor SIGINT delivery: trio event loop '
'on non-main thread post-fork doesn\'t see the '
'external SIGINT → KBI path. See tracker doc.\n'
'ai/conc-anal/subint_forkserver_orphan_sigint_hang_issue.md'
),
)
@pytest.mark.timeout(