From 359fe75ced677ce2bfaee054f99dc2f1ddbc243c Mon Sep 17 00:00:00 2001 From: goodboy Date: Mon, 17 Aug 2026 17:04:20 -0400 Subject: [PATCH] Tolerate only Windows `pytest` failures Job-level `continue-on-error` made setup and import-smoke failures non-blocking even though the smoke is the hard Windows support signal. Move tolerance to the `pytest` step so the incomplete suite remains informational while install, dependency, and `HAS_UDS` smoke failures fail the job. When only the known suite fails, the job and PR rollup remain green with the failed step still visible. (this patch was generated in some part by `opencode` using `gpt-5.6-sol` (`openai`)) --- .github/workflows/ci.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0a973ff0..d07ebf49 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -91,11 +91,10 @@ jobs: name: '${{ matrix.os }} Python${{ matrix.python-version }} spawn_backend=${{ matrix.spawn_backend }} tpt_proto=${{ matrix.tpt_proto }}' timeout-minutes: 16 runs-on: ${{ matrix.os }} - # Windows support is nascent: keep its legs informational so a - # known-incomplete area doesn't block merges. The `import - # tractor` smoke step below is the hard signal for this job; - # promote the whole leg to required once the suite is green. - continue-on-error: ${{ matrix.os == 'windows-latest' }} + # Windows support is nascent: its full test suite remains + # informational, while setup and the `import tractor` smoke below + # are hard signals. Promote the test step to required once the + # suite is green. strategy: fail-fast: false @@ -163,6 +162,7 @@ jobs: run: uv run python -c "import sys; import tractor; from tractor.ipc._uds import HAS_UDS; assert sys.platform != 'win32' or not HAS_UDS; print('import tractor OK | HAS_UDS=', HAS_UDS)" - name: Run tests + continue-on-error: ${{ matrix.os == 'windows-latest' }} run: > uv run pytest